[tool] Build all_packages command against Flutter Android SDK version to match example app compileSdk constraints#8345
Conversation
|
|
Error now is that the legacy variant is using a lower version of AGP and needs 8.1
|
There was a problem hiding this comment.
From triage: Is one of these the legacy file? If so, can we make that file use compileSdk 35 (just copying discussion from internal conversation).
There was a problem hiding this comment.
Also, can we eliminate this conditional logic by just using compileSdk = 35 in both cases? I think that is valid Groovy as well as Kotlin
There was a problem hiding this comment.
I could swap them both to compileSdk since compileSdkVersion is deprecated.
Never mind, that didn't make sense. I see what you mean.
|
Note from Android triage: @jmagman are you still working on this? |
… to match example apps
f53e99e to
cd50629
Compare
|
Greetings from stale PR triage 👋 @jmagman is this still on your radar? |
|
Closing this, I haven't gotten back to it. |
|
(Done in #9168) |
A few dependency bumps are failing due to the all_packages test targeting a lower version of Android SDK than the example apps. Instead of hardcoding an SDK version which needs to be updated manually (https://github.com/flutter/packages/pull/7891/files#r1815169527), instead use flutter.compileSdkVersion, similar to #3847.
Unblocks attempts to increase dependencies versions that require SDK 35 or higher
#7985
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.