[webview_flutter] Add an option to bypass SSL checks#7893
Closed
Colman wants to merge 46 commits intoflutter:mainfrom
Closed
[webview_flutter] Add an option to bypass SSL checks#7893Colman wants to merge 46 commits intoflutter:mainfrom
Colman wants to merge 46 commits intoflutter:mainfrom
Conversation
Author
|
I still have some tests to add, but I would like a first pass to check for bigger issues |
ditman
reviewed
Oct 22, 2024
Member
ditman
left a comment
There was a problem hiding this comment.
Looks like webview_flutter_web (at least) doesn't have any significant changes and can be reverted?
Author
Those changes are needed temporarily because this is a federated plugin. Please see: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins |
Contributor
|
This is blocked by the |
Collaborator
|
from triage: iOS proxy updates are close to landing, at which point this will finally be unblocked. |
Collaborator
|
@bparrishMines Can you take a look at updating this to the new wrapper? |
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
…dates native wrapper for `SecTrust` and `SecCertificate` (#9016) Adds support to the native wrapper to handle `SecTrust` and `SecCertificate`. This is a part of landing #7893 by splitting of the native wrapper implementation. Also fixes flutter/flutter#162938 and adds an integration test for `loadFlutterAsset`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Contributor
|
Greetings from stale PR triage, @stuartmorgan-g is this one still blocked? |
Collaborator
|
No, it's unblocked now and needs to be updated to the new wrapper generator. @bparrishMines is planning on doing that, but has been on higher priority work. It should be pretty soon though. |
nick-llewellyn
pushed a commit
to labrystechnology/flutter_packages
that referenced
this pull request
Apr 23, 2025
…dates native wrapper for `SecTrust` and `SecCertificate` (flutter#9016) Adds support to the native wrapper to handle `SecTrust` and `SecCertificate`. This is a part of landing flutter#7893 by splitting of the native wrapper implementation. Also fixes flutter/flutter#162938 and adds an integration test for `loadFlutterAsset`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
nick-llewellyn
pushed a commit
to labrystechnology/flutter_packages
that referenced
this pull request
Apr 23, 2025
…ebViewClient`. (flutter#8964) This adds the SSL classes for flutter#7893 and a few extra `WebViewClient` methods. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Contributor
|
This PR doesn't allow me to edit so I took over this feature with: #9150. Closing. |
CodixNinja
pushed a commit
to CodixNinja/packages
that referenced
this pull request
May 15, 2025
…dates native wrapper for `SecTrust` and `SecCertificate` (#9016) Adds support to the native wrapper to handle `SecTrust` and `SecCertificate`. This is a part of landing flutter/packages#7893 by splitting of the native wrapper implementation. Also fixes flutter/flutter#162938 and adds an integration test for `loadFlutterAsset`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
CodixNinja
pushed a commit
to CodixNinja/packages
that referenced
this pull request
May 15, 2025
…ebViewClient`. (#8964) This adds the SSL classes for flutter/packages#7893 and a few extra `WebViewClient` methods. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…dates native wrapper for `SecTrust` and `SecCertificate` (flutter#9016) Adds support to the native wrapper to handle `SecTrust` and `SecCertificate`. This is a part of landing flutter#7893 by splitting of the native wrapper implementation. Also fixes flutter/flutter#162938 and adds an integration test for `loadFlutterAsset`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…ebViewClient`. (flutter#8964) This adds the SSL classes for flutter#7893 and a few extra `WebViewClient` methods. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…dates native wrapper for `SecTrust` and `SecCertificate` (flutter#9016) Adds support to the native wrapper to handle `SecTrust` and `SecCertificate`. This is a part of landing flutter#7893 by splitting of the native wrapper implementation. Also fixes flutter/flutter#162938 and adds an integration test for `loadFlutterAsset`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…ebViewClient`. (flutter#8964) This adds the SSL classes for flutter#7893 and a few extra `WebViewClient` methods. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Jyndigo
pushed a commit
to uesp/wkwebview_flutter
that referenced
this pull request
Jun 24, 2025
…dates native wrapper for `SecTrust` and `SecCertificate` (#9016) Adds support to the native wrapper to handle `SecTrust` and `SecCertificate`. This is a part of landing flutter/packages#7893 by splitting of the native wrapper implementation. Also fixes flutter/flutter#162938 and adds an integration test for `loadFlutterAsset`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…dates native wrapper for `SecTrust` and `SecCertificate` (flutter#9016) Adds support to the native wrapper to handle `SecTrust` and `SecCertificate`. This is a part of landing flutter#7893 by splitting of the native wrapper implementation. Also fixes flutter/flutter#162938 and adds an integration test for `loadFlutterAsset`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…ebViewClient`. (flutter#8964) This adds the SSL classes for flutter#7893 and a few extra `WebViewClient` methods. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the webview encounters an SSL error, there is no option to be able to bypass the error. This PR implements a callback that gets called with the SSL error and certificate details. A decision can be returned to either ignore the error and proceed, or cancel the request.
flutter/flutter#36925
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.