[camera] Manual roll and skip failing tests by bparrishMines · Pull Request #7891 · flutter/packages

bparrishMines · 2024-10-18T19:22:47Z

Also updates the build_all_packages test to handle android/app/build.gradle(.kts) filename.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

stuartmorgan-g · 2024-10-21T16:21:09Z

What's the status of this? Are we planning on landing this (or something like it), or getting the roll started again blocked on the failing tests?

bparrishMines · 2024-10-23T17:29:47Z

@stuartmorgan I reran this multiple times, but it looks like the video_player tests began failing and I wasn't able to finish investigating why.

bparrishMines · 2024-10-23T18:06:40Z

I updated to the lasts flutter/flutter version. Will try and skip additional tests if this doesn't work.

bparrishMines · 2024-10-24T00:13:43Z

@stuartmorgan
@flutter/android-reviewers FYI

The build all packages test was failing because it looks like android/app/build.gradle moved to .../build.gradle.kts.

Changed 52 dependencies!
12 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
Unhandled exception:
PathNotFoundException: Cannot open file, path = './all_packages/android/app/build.gradle' (OS Error: No such file or directory, errno = 2)
#0      _File.throwIfError (dart:io/file_impl.dart:675:7)
#1      _File.openSync (dart:io/file_impl.dart:490:5)
#2      _File.readAsBytesSync (dart:io/file_impl.dart:574:18)
#3      _File.readAsStringSync (dart:io/file_impl.dart:624:18)
#4      ForwardingFile.readAsStringSync (package:file/src/forwarding/forwarding_file.dart:99:16)
#5      CreateAllPackagesAppCommand._updateAppGradle (package:flutter_plugin_tools/src/create_all_packages_app_command.dart:224:39)
#6      CreateAllPackagesAppCommand.run (package:flutter_plugin_tools/src/create_all_packages_app_command.dart:109:7)
<asynchronous suspension>
#7      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#8      main.<anonymous closure> (package:flutter_plugin_tools/src/main.dart:105:12)
<asynchronous suspension>

Edit
Whoops, now new errors are popping up. Fixing the script now.

* Where:
Build file '/b/s/w/ir/x/w/packages/all_packages/android/app/build.gradle.kts' line: 10

* What went wrong:
Script compilation errors:

  Line 10: compileSdk 34
                      ^ Unexpected tokens (use ';' to separate expressions on the same line)

  Line 23:         multiDexEnabled true
                                  ^ Unexpected tokens (use ';' to separate expressions on the same line)

  Line 28: minSdkVersion 21
                         ^ Unexpected tokens (use ';' to separate expressions on the same line)

  Line 28: minSdkVersion 21
           ^ Function invocation 'minSdkVersion(...)' expected

  Line 28: minSdkVersion 21
           ^ None of the following functions can be called with the arguments supplied: 
               public abstract fun minSdkVersion(minSdkVersion: Int): Unit defined in com.android.build.api.dsl.ApplicationDefaultConfig
               public abstract fun minSdkVersion(minSdkVersion: String?): Unit defined in com.android.build.api.dsl.ApplicationDefaultConfig

  Line 48:     implementation 'androidx.lifecycle:lifecycle-runtime:2.2.0-rc01'
                              ^ Unexpected tokens (use ';' to separate expressions on the same line)

  Line 48:     implementation 'androidx.lifecycle:lifecycle-runtime:2.2.0-rc01'
               ^ Unresolved reference. None of the following candidates is applicable because of receiver type mismatch: 
                   public val NamedDomainObjectContainer<Configuration>.implementation: NamedDomainObjectProvider<Configuration> defined in org.gradle.kotlin.dsl

reidbaker

I thought create all packages ran as part of presubmit and would have been caught before we merged the kts migration.

reidbaker · 2024-10-24T14:55:57Z

script/tool/lib/src/create_all_packages_app_command.dart

-        // minSdkVersion 21 is required by camera_android.
-        'minSdkVersion': <String>['minSdkVersion 21'],
-        'compileSdkVersion': <String>['compileSdk 34'],
+        if (gradleFileIsKotlin)


Formatting nit can you include {} around this case?

Collection conditionals can't use braces, unfortunately.

reidbaker · 2024-10-24T14:56:31Z

script/tool/lib/src/create_all_packages_app_command.dart

-        'minSdkVersion': <String>['minSdkVersion 21'],
-        'compileSdkVersion': <String>['compileSdk 34'],
+        if (gradleFileIsKotlin)
+          'compileSdk': <String>['compileSdk = 34']


Not part of this pr but this should probably be 35.

stuartmorgan-g · 2024-10-24T15:08:30Z

I thought create all packages ran as part of presubmit and would have been caught before we merged the kts migration.

I assume that was a flutter/flutter change? The only flutter/packages test we run in flutter/flutter is Dart analysis.

reidbaker · 2024-10-24T15:10:58Z

I thought create all packages ran as part of presubmit and would have been caught before we merged the kts migration.

I assume that was a flutter/flutter change? The only flutter/packages test we run in flutter/flutter is Dart analysis.

Ah you are right, I reviewed that framework pr from bartek then worked with jesswrd on a packages pr and my brain mixed them up. Also her pr has not landed. Either way sorry for the breakage as we migrate to kotlin code in more places.

stuartmorgan-g

LGTM; thanks for getting this over the line and the roller unblocked!

stuartmorgan-g · 2024-10-24T15:12:03Z

script/tool/lib/src/create_all_packages_app_command.dart

+            '        multiDexEnabled = true'
+          else
+            '        multiDexEnabled true'
+        ],


I think we can remove this due to the minSdkVersion being 21, but I'll look into that as a follow-up.

stuartmorgan-g · 2024-10-24T15:14:34Z

Either way sorry for the breakage as we migrate to kotlin code in more places.

The surgery we do to the project in create-all-packages is inherently fragile; it's totally expected that it would break from time to time and we'd need to fix it in rolls.

…#7891)

flutter/packages@5e03bb1...a556f0f 2024-10-24 10687576+bparrishMines@users.noreply.github.com [camera] Manual roll and skip failing tests (flutter/packages#7891) 2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/image_picker/image_picker_android/android (flutter/packages#7898) 2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7906) 2024-10-23 48524817+wamynobe@users.noreply.github.com [pigeon] Allows swift generator to skip error class generation (flutter/packages#7849) 2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7903) 2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/file_selector/file_selector_android/android (flutter/packages#7900) 2024-10-23 43054281+camsim99@users.noreply.github.com [video_player_android] Give `can pause` integration test range to test for (flutter/packages#7913) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

man roll and test skip

257d8e5

github-actions bot added the p: camera label Oct 18, 2024

bparrishMines changed the title ~~man roll and test skip~~ [camera] Manual roll and skip failing tests Oct 18, 2024

bparrishMines added 2 commits October 23, 2024 14:04

Merge branch 'main' of github.com:flutter/packages into man_roll

f7ee717

bump version

6fa495e

bparrishMines added 2 commits October 23, 2024 18:35

Merge branch 'main' of github.com:flutter/packages into man_roll

ed35216

fix gradle file name

f675957

bparrishMines added 4 commits October 23, 2024 20:30

try fix script

5437d92

second try lol

1506f12

no needed comment

c701327

support kotlin and normal

8e2cc76

bparrishMines requested review from a team and stuartmorgan-g October 24, 2024 03:44

bparrishMines marked this pull request as ready for review October 24, 2024 03:44

bparrishMines requested a review from camsim99 as a code owner October 24, 2024 03:44

bparrishMines requested a review from tarrinneal October 24, 2024 03:45

tarrinneal approved these changes Oct 24, 2024

View reviewed changes

reidbaker approved these changes Oct 24, 2024

View reviewed changes

stuartmorgan-g approved these changes Oct 24, 2024

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2024

auto-submit bot merged commit a556f0f into flutter:main Oct 24, 2024

engine-flutter-autoroll mentioned this pull request Oct 24, 2024

Roll Packages from 5e03bb1da411 to a556f0f52825 (7 revisions) flutter/flutter#157512

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 24, 2024

a556f0f [camera] Manual roll and skip failing tests (flutter/packages…

76f78ee

…#7891)

bparrishMines deleted the man_roll branch October 24, 2024 16:13

engine-flutter-autoroll mentioned this pull request Oct 24, 2024

Roll Packages from 5e03bb1da411 to a556f0f52825 (7 revisions) flutter/flutter#157539

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 24, 2024

a556f0f [camera] Manual roll and skip failing tests (flutter/packages…

ef9af1c

…#7891)

Conversation

bparrishMines commented Oct 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

stuartmorgan-g commented Oct 21, 2024

Uh oh!

bparrishMines commented Oct 23, 2024

Uh oh!

bparrishMines commented Oct 23, 2024

Uh oh!

bparrishMines commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reidbaker left a comment

Choose a reason for hiding this comment

Uh oh!

reidbaker Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

reidbaker Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Oct 24, 2024

Uh oh!

reidbaker commented Oct 24, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Oct 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bparrishMines commented Oct 18, 2024 •

edited

Loading

bparrishMines commented Oct 24, 2024 •

edited

Loading