[flutter_adaptive_scaffold] Add breakpoint extension to get the current active breakpoint by martijn00 · Pull Request #7347 · flutter/packages

martijn00 · 2024-08-08T20:26:02Z

This enables people to check what the current breakpoint is and adjust UI based on that.

List which issues are fixed by this PR. You must list at least one issue.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-08-08T20:26:05Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

martijn00 · 2024-08-08T20:26:58Z

@gspencergoog I just wanted to get your opinion on this before working further on it.

It needs a rebase after #7300 is merged

packages/flutter_adaptive_scaffold/lib/src/breakpoints.dart

martijn00 · 2024-08-09T21:57:06Z

@gspencergoog @Renzo-Olivares do you have some more feedback on this? Otherwise i'll go ahead and add some tests and other changes required.

packages/flutter_adaptive_scaffold/lib/src/breakpoints.dart

martijn00 · 2024-08-13T15:22:49Z

@Renzo-Olivares @gspencergoog this is ready to review now.

gspencergoog

packages/flutter_adaptive_scaffold/lib/src/breakpoints.dart

diegotori · 2024-08-14T17:41:03Z

@gspencergoog I know that you have already approved it, but I did add some feedback that might make @martijn00's changes a bit more concise.

In other words, I added suggestions in terms of breaking up the static method into smaller components, thus making it more manageable.

Please let me know if it makes sense for you to rescind your approval for these proposed suggestions. Thanks.

martijn00 · 2024-08-14T19:35:00Z

@diegotori some good feedback! I've made the changes for it. @gspencergoog can you review again and let me know if you agree?

packages/flutter_adaptive_scaffold/lib/src/breakpoints.dart

diegotori · 2024-08-14T19:37:15Z

@diegotori some good feedback! I've made the changes for it. @gspencergoog can you review again and let me know if you agree?

Added one more nit.

gspencergoog

Works for me.

packages/flutter_adaptive_scaffold/lib/src/slot_layout.dart

diegotori

LGTM.

diegotori · 2024-08-15T19:20:10Z

@gspencergoog looks like the PR's all green.

diegotori

LGTM again.

martijn00 · 2024-08-15T19:59:58Z

@Renzo-Olivares @gspencergoog What do you think?

Renzo-Olivares

I added a few fly-by nits. Still going over the changes to pickWidget.

packages/flutter_adaptive_scaffold/test/breakpoint_test.dart

packages/flutter_adaptive_scaffold/lib/src/slot_layout.dart

packages/flutter_adaptive_scaffold/CHANGELOG.md

martijn00 · 2024-08-15T20:21:24Z

@Renzo-Olivares fixed those now.

packages/flutter_adaptive_scaffold/test/breakpoint_test.dart

gspencergoog

Sorry, I need to put this PR on hold for a bit while I check on our policies about AI-generated code. Hopefully it won't affect things.

gspencergoog

Ok, all good to go.

(Sorry, policy has changed a lot over the last year, and I wanted to make sure we could still accept it).

martijn00 · 2024-08-15T21:04:19Z

@Renzo-Olivares fixed the dots.

…he current active breakpoint (flutter/packages#7347)

flutter/packages@86d15a6...2c37fb0 2024-08-16 engine-flutter-autoroll@skia.org Manual roll Flutter from 99f00a1 to bced008 (13 revisions) (flutter/packages#7424) 2024-08-16 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds IMA plugin to labeler yaml (flutter/packages#7420) 2024-08-15 matanlurey@users.noreply.github.com Roll `avd_cipd_verison` to latest to use the `crashreport` tool. (flutter/packages#7422) 2024-08-15 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add breakpoint extension to get the current active breakpoint (flutter/packages#7347) 2024-08-15 engine-flutter-autoroll@skia.org Roll Flutter from cc13cd1 to 99f00a1 (24 revisions) (flutter/packages#7419) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

martijn00 requested a review from gspencergoog as a code owner August 8, 2024 20:26

github-actions bot added the p: flutter_adaptive_scaffold label Aug 8, 2024

gspencergoog changed the title ~~Add breakpoint extension to get the current active breakpoint~~ [flutter_adaptive_scaffold] Add breakpoint extension to get the current active breakpoint Aug 8, 2024

gspencergoog reviewed Aug 8, 2024

View reviewed changes

packages/flutter_adaptive_scaffold/lib/src/breakpoints.dart Outdated Show resolved Hide resolved

martijn00 force-pushed the extension branch from f7c6480 to fe3d032 Compare August 9, 2024 21:57

Renzo-Olivares reviewed Aug 10, 2024

View reviewed changes

packages/flutter_adaptive_scaffold/lib/src/breakpoints.dart Outdated Show resolved Hide resolved

martijn00 force-pushed the extension branch from fe3d032 to e2b2f13 Compare August 12, 2024 19:37

martijn00 requested review from Renzo-Olivares and gspencergoog August 12, 2024 19:39

martijn00 mentioned this pull request Aug 12, 2024

Improvements and Tests caseycrogers/flutter_gutter#6

Merged

4 tasks

martijn00 force-pushed the extension branch from 4a44765 to f8a09ca Compare August 13, 2024 13:24

martijn00 force-pushed the extension branch from 53e7656 to 757638c Compare August 14, 2024 12:04

gspencergoog approved these changes Aug 14, 2024

View reviewed changes

diegotori reviewed Aug 14, 2024

View reviewed changes

packages/flutter_adaptive_scaffold/lib/src/breakpoints.dart Outdated Show resolved Hide resolved

packages/flutter_adaptive_scaffold/lib/src/breakpoints.dart Outdated Show resolved Hide resolved

diegotori reviewed Aug 14, 2024

View reviewed changes

packages/flutter_adaptive_scaffold/lib/src/breakpoints.dart Outdated Show resolved Hide resolved

gspencergoog approved these changes Aug 14, 2024

View reviewed changes

martijn00 commented Aug 14, 2024

View reviewed changes

packages/flutter_adaptive_scaffold/lib/src/slot_layout.dart Outdated Show resolved Hide resolved

diegotori reviewed Aug 14, 2024

View reviewed changes

martijn00 mentioned this pull request Aug 15, 2024

[flutter_adaptive_scaffold] Add expanded and extra large breakpoints #7300

Merged

11 tasks

martijn00 force-pushed the extension branch from 141b1de to f4450ca Compare August 15, 2024 15:07

martijn00 requested a review from diegotori August 15, 2024 18:59

martijn00 added 2 commits August 15, 2024 20:59

Add breakpoint extension to get the current active breakpoint

8bdb34a

As static

4ce6c5a

martijn00 added 7 commits August 15, 2024 20:59

Split up methods

a9d8a3c

Tests

4469147

Fix

89a277f

Fix

69a951b

Fix

68cd508

Fixes

e78e4ee

Fix

892796e

martijn00 force-pushed the extension branch from 1c1f4c0 to 892796e Compare August 15, 2024 18:59

diegotori reviewed Aug 15, 2024

View reviewed changes

Renzo-Olivares approved these changes Aug 15, 2024

View reviewed changes

Spelling

a687748

Renzo-Olivares reviewed Aug 15, 2024

View reviewed changes

packages/flutter_adaptive_scaffold/test/breakpoint_test.dart Outdated Show resolved Hide resolved

Renzo-Olivares self-requested a review August 15, 2024 20:47

gspencergoog requested changes Aug 15, 2024

View reviewed changes

gspencergoog approved these changes Aug 15, 2024

View reviewed changes

Dot

10cbd43

gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2024

auto-submit bot merged commit acb6a29 into flutter:main Aug 15, 2024

kaboc mentioned this pull request Aug 16, 2024

[flutter_adaptive_scaffold] Body becomes blank if window is a particular size within specified breakpoints flutter/flutter#153496

Closed

engine-flutter-autoroll mentioned this pull request Aug 16, 2024

Roll Packages from 86d15a65d091 to 7695c4538f6e (4 revisions) flutter/flutter#153569

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2024

acb6a29 [flutter_adaptive_scaffold] Add breakpoint extension to get t…

0e15d79

…he current active breakpoint (flutter/packages#7347)

engine-flutter-autoroll mentioned this pull request Aug 16, 2024

Roll Packages from 86d15a65d091 to 2c37fb052cd4 (5 revisions) flutter/flutter#153571

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2024

acb6a29 [flutter_adaptive_scaffold] Add breakpoint extension to get t…

7c37d95

…he current active breakpoint (flutter/packages#7347)

Conversation

martijn00 commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Aug 8, 2024

Uh oh!

martijn00 commented Aug 8, 2024

Uh oh!

Uh oh!

martijn00 commented Aug 9, 2024

Uh oh!

Uh oh!

martijn00 commented Aug 13, 2024

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

diegotori commented Aug 14, 2024

Uh oh!

martijn00 commented Aug 14, 2024

Uh oh!

Uh oh!

diegotori commented Aug 14, 2024

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

diegotori left a comment

Choose a reason for hiding this comment

Uh oh!

diegotori commented Aug 15, 2024

Uh oh!

diegotori left a comment

Choose a reason for hiding this comment

Uh oh!

martijn00 commented Aug 15, 2024

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

martijn00 commented Aug 15, 2024

Uh oh!

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

martijn00 commented Aug 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

martijn00 commented Aug 8, 2024 •

edited

Loading