[shared_preferences] Fixes get-all when suite name is used by fertrig · Pull Request #7335 · flutter/packages

fertrig · 2024-08-07T17:51:01Z

In shared_preferences_foundation, fixes getting all preferences when suite name is used. Bug was reading only the standard user defaults. The fix uses suite name when available.

Issues fixed by this PR:

Cannot get shared preferences keys using suite name flutter#153042

Pre-launch Checklist

...d_preferences_foundation/Sources/shared_preferences_foundation/SharedPreferencesPlugin.swift

In shared_preferences_foundation, fixes getting all preferences when suite name is used. Bug was reading only the standard user defaults. The fix uses suite name when available.

tarrinneal

If you could run the format tool and update the changelog here those last two tests will pass. Thank you for putting this together.

tarrinneal · 2024-08-08T04:52:25Z

packages/shared_preferences/shared_preferences_foundation/CHANGELOG.md

@@ -1,5 +1,5 @@
 ## NEXT


This will need to be changed to 2.5.1

fertrig · 2024-08-08T18:52:28Z

@tarrinneal I think this PR is good now.

tarrinneal · 2024-08-08T18:57:29Z

I forgot during my last review that this will need testing in the integration tests (shared_preferences_foundation/example/integration_tests/shared_preferences_tests.dart), perhaps just running the entire test suite again with suite name.

fertrig · 2024-08-08T20:54:12Z

I added a couple of integration tests. Let me know what you think.

Also, there may be a bug with the SharedPreferencesPlugin.clear method. Since it is using dictionaryRepresentation, it may try to delete keys in the global domain.

tarrinneal · 2024-08-09T07:20:20Z

I added a couple of integration tests. Let me know what you think.

Also, there may be a bug with the SharedPreferencesPlugin.clear method. Since it is using dictionaryRepresentation, it may try to delete keys in the global domain.

Did you want to test/fix that with this pr as well? (no pressure)

fertrig · 2024-08-10T03:44:48Z

No, when I test it I'll create a separate PR.

tarrinneal

one (required) nit and the conflict updated and it's good to go. Thanks for finding and fixing this :)

packages/shared_preferences/shared_preferences_foundation/CHANGELOG.md

stuartmorgan-g

LGTM

auto-submit · 2024-08-12T12:06:23Z

auto label is removed for flutter/packages/7335, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

stuartmorgan-g · 2024-08-12T13:53:02Z

That failure was the known infra flake, not related to the PR.

auto-submit · 2024-08-12T14:16:22Z

auto label is removed for flutter/packages/7335, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

…lutter/packages#7335)

flutter/packages@f7b1256...d9a6de8 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/camera/camera_android/android (flutter/packages#7371) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/path_provider/path_provider_android/android (flutter/packages#7376) 2024-08-12 tarrinneal@gmail.com [pigeon] removes restriction on number of custom types per file (flutter/packages#6840) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.0 to 2.0.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7370) 2024-08-12 fertrig@gmail.com [shared_preferences] Fixes get-all when suite name is used (flutter/packages#7335) 2024-08-12 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add expanded and extra large breakpoints (flutter/packages#7300) 2024-08-12 engine-flutter-autoroll@skia.org Manual roll Flutter from b12d861 to 9b84701 (8 revisions) (flutter/packages#7366) 2024-08-10 engine-flutter-autoroll@skia.org Manual roll Flutter from 76107bd to b12d861 (14 revisions) (flutter/packages#7358) 2024-08-09 tarrinneal@gmail.com [shared_preferences] fix cast error and mutable list error with `getStringList` (flutter/packages#7355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fertrig requested a review from tarrinneal as a code owner August 7, 2024 17:51

github-actions bot added platform-ios platform-macos p: shared_preferences labels Aug 7, 2024

stuartmorgan-g reviewed Aug 7, 2024

View reviewed changes

...d_preferences_foundation/Sources/shared_preferences_foundation/SharedPreferencesPlugin.swift Outdated Show resolved Hide resolved

fertrig force-pushed the shared-prefs-fix branch from 9146aa8 to c875838 Compare August 7, 2024 20:52

fertrig mentioned this pull request Aug 7, 2024

[shared_preferences] Fixes get-all when suite name is used teamsynco/flutter_packages#1

Merged

fertrig added 2 commits August 7, 2024 17:01

[shared_prefs] Fixes get-all when suite name is used

eef760f

In shared_preferences_foundation, fixes getting all preferences when suite name is used. Bug was reading only the standard user defaults. The fix uses suite name when available.

Comment to clarify fix

f0e9d5f

fertrig force-pushed the shared-prefs-fix branch from 98f1f7e to f0e9d5f Compare August 7, 2024 21:02

fertrig mentioned this pull request Aug 7, 2024

[shared_preferences][synco] Fixes get-all when suite name is used teamsynco/flutter_packages#2

Merged

tarrinneal reviewed Aug 8, 2024

View reviewed changes

fertrig added 2 commits August 8, 2024 14:24

Bump version. Formatting.

d2d0ecf

Merge branch 'main' into shared-prefs-fix

cff8ad8

Add integration tests.

e7c8efd

fertrig added 2 commits August 8, 2024 17:57

Tests pass on local machine. Clearing preferences for CI.

00f0cb1

Merge branch 'main' into shared-prefs-fix

e1d3329

tarrinneal approved these changes Aug 10, 2024

View reviewed changes

packages/shared_preferences/shared_preferences_foundation/CHANGELOG.md Show resolved Hide resolved

tarrinneal requested a review from stuartmorgan-g August 10, 2024 06:48

stuartmorgan-g approved these changes Aug 12, 2024

View reviewed changes

stuartmorgan-g added 2 commits August 12, 2024 04:42

Merge branch 'main' into shared-prefs-fix

e9902f6

Re-bump version

0165741

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 12, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 12, 2024

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 12, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 12, 2024

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 12, 2024

auto-submit bot merged commit c0109e2 into flutter:main Aug 12, 2024

engine-flutter-autoroll mentioned this pull request Aug 12, 2024

Roll Packages from f7b12561aeb6 to c0109e25a037 (5 revisions) flutter/flutter#153286

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 12, 2024

c0109e2 [shared_preferences] Fixes get-all when suite name is used (f…

b17623b

…lutter/packages#7335)

engine-flutter-autoroll mentioned this pull request Aug 12, 2024

Roll Packages from f7b12561aeb6 to 687c8a5038c3 (6 revisions) flutter/flutter#153287

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 12, 2024

c0109e2 [shared_preferences] Fixes get-all when suite name is used (f…

171d25d

…lutter/packages#7335)

engine-flutter-autoroll mentioned this pull request Aug 12, 2024

Roll Packages from f7b12561aeb6 to d9a6de802e1f (9 revisions) flutter/flutter#153291

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 12, 2024

c0109e2 [shared_preferences] Fixes get-all when suite name is used (f…

2abc82e

…lutter/packages#7335)

Conversation

fertrig commented Aug 7, 2024

Pre-launch Checklist

Uh oh!

Uh oh!

tarrinneal left a comment

Choose a reason for hiding this comment

Uh oh!

tarrinneal Aug 8, 2024

Choose a reason for hiding this comment

Uh oh!

fertrig commented Aug 8, 2024

Uh oh!

tarrinneal commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fertrig commented Aug 8, 2024

Uh oh!

tarrinneal commented Aug 9, 2024

Uh oh!

fertrig commented Aug 10, 2024

Uh oh!

tarrinneal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Aug 12, 2024

Uh oh!

stuartmorgan-g commented Aug 12, 2024

Uh oh!

auto-submit bot commented Aug 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tarrinneal commented Aug 8, 2024 •

edited

Loading