Roll Flutter (stable) from b0850beeb25f to 80c2e84975bb (1397 revisions) by engine-flutter-autoroll · Pull Request #7322 · flutter/packages

engine-flutter-autoroll · 2024-08-06T17:31:43Z

flutter/flutter@b0850be...80c2e84

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-stable-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter (stable): https://github.com/flutter/flutter/issues/new/choose
To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixes flutter/flutter#151869

…#149383)

…r/flutter#150045)

…flutter#150051)

…isions) (flutter/flutter#150069)

…or message according to platform (flutter/flutter#149877)

…ee` (flutter/flutter#150010)

…ter#150055)

…utter/flutter#149737)

…5) (flutter/flutter#150047)

…149682)

…lutter#150115)

… a bit. (flutter/flutter#149933)

…r#149681)

…r#150124)

…50071)

… (#149739) (flutter/flutter#150090)

…cus widget (#142942) (flutter/flutter#149840)

…ter#150133)

…0132)

…ter/flutter#150129)

…ve" (flutter/flutter#150142)

…s not possible (flutter/flutter#149925)

…ter/flutter#150147)

…isions) (flutter/flutter#150199)

…flutter#150198)

auto-submit · 2024-08-06T18:47:57Z

auto label is removed for flutter/packages/7322, due to - The status or check suite cla/google has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2024-08-06T18:50:45Z

auto label is removed for flutter/packages/7322, due to - The status or check suite Mac_arm64 custom_package_tests stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Mac_arm64 macos_platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 macos_repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux_desktop build_all_packages master has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux_web web_platform_tests_shard_1 stable has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux_web web_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux_web web_platform_tests_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux_android android_device_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux analyze_legacy N-2 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux analyze_downgraded stable has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux_web web_dart_unit_test_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux_web web_dart_unit_test_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux dart_unit_test_shard_1 stable has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux dart_unit_test_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

ditman · 2024-08-06T19:46:18Z

I think the last web flakiness (in stable) that's not reproducing in master might require this to be cherry-picked to stable:

Reland (x2) "Output .js files as ES6 modules. (flutter#52023)" engine#53718

(I've pinged the web team about this, because I'm about to be OOO for a couple of weeks)

auto-submit · 2024-08-06T19:52:22Z

auto label is removed for flutter/packages/7322, due to - The status or check suite Mac_arm64 macos_platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite cla/google has failed. Please fix the issues identified (or deflake) before re-applying this label.

engine-flutter-autoroll · 2024-08-06T19:53:56Z

Commit queue failed; closing this roll.

ditman · 2024-08-06T20:48:31Z

Here's the tracking issue for the pending CPs to stable:

Urgent Flutter 3.24.1 Cherry picks for web flutter#152953

stuartmorgan-g · 2024-08-07T11:32:35Z

I'm going to try removing the cleanup parts, so stable is still running with html for now, and see if the flake is tolerable that way, since if so this roll (which in turn blocks other things) doesn't have to be blocked on a new stable release.

This reverts commit 92f534f.

This reverts commit ac8deab.

stuartmorgan-g · 2024-08-07T12:46:39Z

All the web tests passed, so it looks like we can stick with html on stable for now, and do the switch after the cherry picks.

flutter/packages#7322)

flutter/packages@551bde5...5cc0a01 2024-08-07 stuartmorgan@google.com [ci] Update repository for the release of Flutter 3.24 (flutter/packages#7331) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter (stable) from b0850be to 80c2e84 (1397 revisions) (flutter/packages#7322) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.5 to 4.3.6 (flutter/packages#7330) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.7 to 1.13.12 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7189) 2024-08-07 joonas.kerttula@codemate.com [google_maps_flutter] Marker clustering support (flutter/packages#4319) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.15 to 3.26.0 (flutter/packages#7329) 2024-08-07 engine-flutter-autoroll@skia.org Manual roll Flutter from 1dd7141 to 0a7f8af (23 revisions) (flutter/packages#7328) 2024-08-06 magder@google.com [image_picker_ios] Update image picker UI test query for iOS 18 (flutter/packages#7325) 2024-08-06 joonas.kerttula@codemate.com [google_maps_flutter] Add marker clustering support - iOS implementation (flutter/packages#6186) 2024-08-06 8014077+Frank3K@users.noreply.github.com [url_launcher] launchUrl always returns true for valid schemes on the web. (flutter/packages#7229) 2024-08-06 rexios@rexios.dev [google_maps_flutter] Add heatmap support (flutter/packages#3257) 2024-08-06 stuartmorgan@google.com [local_auth] Endorse macOS (flutter/packages#7274) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

engine-flutter-autoroll added 30 commits August 6, 2024 17:31

aad70e5 Add tests for scaffold drawer and end drawer (flutter/flutter…

fb9459e

…#149383)

14df7be Revert "Add tests for scaffold drawer and end drawer" (flutte…

4768a74

…r/flutter#150045)

966d2b9 Fix ColorScheme example and tests (flutter/flutter#150018)

ee78af4

9983ced Roll Packages from e95fe4a to 8c24fd4 (7 revisions) (flutter/…

49146a6

…flutter#150051)

cc24f87 Roll Flutter Engine from 1cdbebee1901 to c7fcbfce608f (54 rev…

ac8eb5e

…isions) (flutter/flutter#150069)

c5e5e0c closes #issue136763, changed a command to generate gradle err…

5c97841

…or message according to platform (flutter/flutter#149877)

1f93809 Add new WidgetInspector service extension: `getRootWidgetTr…

6472a5d

…ee` (flutter/flutter#150010)

962ae8a Remove double MaterialApp wrap from api samples (flutter/flut…

38d72b4

…ter#150055)

ad462e2 Roll pub packages (flutter/flutter#150070)

e0243c8

fdb74fd Fix DropdownMenu can be focused and updated when disabled (fl…

2754222

…utter/flutter#149737)

9b3c936 Reland "Add tests for scaffold drawer and end drawer" (#15004…

0c85526

…5) (flutter/flutter#150047)

4afadea Add a doc for the flutter/packages gardener (flutter/flutter#…

fb970e9

…149682)

2f03097 Roll Packages from 8c24fd4 to 260102b (1 revision) (flutter/f…

002598c

…lutter#150115)

b1f9d71 Update to Chrome for Testing 125, since we haven't updated in…

8c45e29

… a bit. (flutter/flutter#149933)

3db2ece Add mouse cursor property to CupertinoRadio (flutter/flutte…

991be29

…r#149681)

0d5bf0f Update packages desktop PR triage link lables (flutter/flutte…

55dfbfa

…r#150124)

a8f9032 Fix markdown hyperlinks in the style guide (flutter/flutter#1…

25baeae

…50071)

04dc553 [Reland] Fix SegmentedButton clipping when drawing segments…

b5e99fe

… (#149739) (flutter/flutter#150090)

0c692b8 Update WidgetStatesController docs (flutter/flutter#150081)

2ff9571

d68e05b Reland: Request focus if accessibility focus is given to a Fo…

7bb1fcf

…cus widget (#142942) (flutter/flutter#149840)

e18c5e2 Improve build time when using SwiftPM (flutter/flutter#150052)

8cb988a

a8ffe53 Bump github/codeql-action from 3.25.8 to 3.25.9 (flutter/flut…

50deee4

…ter#150133)

3832475 Bump actions/checkout from 4.1.6 to 4.1.7 (flutter/flutter#15…

3953c39

…0132)

bb9daf5 Reland 2: [CupertinoActionSheet] Match colors to native (flut…

9c9eff1

…ter/flutter#150129)

7b6d667 Revert "Reland 2: [CupertinoActionSheet] Match colors to nati…

11020eb

…ve" (flutter/flutter#150142)

034966b Update testowners (flutter/flutter#150141)

e6ba222

1b8dc90 RawScrollbar: don't listen for drag gestures when scrolling i…

e020f03

…s not possible (flutter/flutter#149925)

317ad4a Revert "[CupertinoActionSheet] Add sliding tap gesture" (flut…

608aa9f

…ter/flutter#150147)

01db23b Roll Flutter Engine from c7fcbfce608f to 4cb3025d3abf (28 rev…

5b2edd5

…isions) (flutter/flutter#150199)

39edf2a Roll Packages from 260102b to 7805455 (2 revisions) (flutter/…

1b0fb03

…flutter#150198)

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

Fix logic

92f534f

engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

engine-flutter-autoroll closed this Aug 6, 2024

stuartmorgan-g reopened this Aug 6, 2024

domesticmouse approved these changes Aug 6, 2024

View reviewed changes

ditman mentioned this pull request Aug 6, 2024

Urgent Flutter 3.24.1 Cherry picks for web flutter/flutter#152953

Closed

7 tasks

stuartmorgan-g added 2 commits August 7, 2024 07:53

Revert "Fix logic"

06bd4e3

This reverts commit 92f534f.

Revert "Flip stable web testing to canvaskit"

6ecf0b0

This reverts commit ac8deab.

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2024

auto-submit bot merged commit f330ca3 into flutter:main Aug 7, 2024

engine-flutter-autoroll mentioned this pull request Aug 7, 2024

Roll Packages from 551bde53f6ea to f330ca3c2fa3 (11 revisions) flutter/flutter#153025

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 7, 2024

f330ca3 Roll Flutter (stable) from b0850be to 80c2e84 (1397 revisions) (

70891e2

flutter/packages#7322)

engine-flutter-autoroll mentioned this pull request Aug 7, 2024

Roll Packages from 551bde53f6ea to 5cc0a0160194 (12 revisions) flutter/flutter#153040

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 7, 2024

f330ca3 Roll Flutter (stable) from b0850be to 80c2e84 (1397 revisions) (

d163c71

flutter/packages#7322)

engine-flutter-autoroll deleted the flutter-stable-packages-1a52c3d0-15b5-4f7a-8bb8-3b7f0ca6900a-1722965498 branch August 13, 2024 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Roll Flutter (stable) from b0850beeb25f to 80c2e84975bb (1397 revisions)#7322

Roll Flutter (stable) from b0850beeb25f to 80c2e84975bb (1397 revisions)#7322
auto-submit[bot] merged 1403 commits intoflutter:mainfrom
engine-flutter-autoroll:flutter-stable-packages-1a52c3d0-15b5-4f7a-8bb8-3b7f0ca6900a-1722965498

engine-flutter-autoroll commented Aug 6, 2024 •

edited by ditman

Loading

Uh oh!

auto-submit bot commented Aug 6, 2024

Uh oh!

auto-submit bot commented Aug 6, 2024

Uh oh!

ditman commented Aug 6, 2024 •

edited

Loading

Uh oh!

auto-submit bot commented Aug 6, 2024

Uh oh!

engine-flutter-autoroll commented Aug 6, 2024

Uh oh!

ditman commented Aug 6, 2024

Uh oh!

stuartmorgan-g commented Aug 7, 2024

Uh oh!

stuartmorgan-g commented Aug 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

engine-flutter-autoroll commented Aug 6, 2024 • edited by ditman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

auto-submit bot commented Aug 6, 2024

Uh oh!

auto-submit bot commented Aug 6, 2024

Uh oh!

ditman commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

auto-submit bot commented Aug 6, 2024

Uh oh!

engine-flutter-autoroll commented Aug 6, 2024

Uh oh!

ditman commented Aug 6, 2024

Uh oh!

stuartmorgan-g commented Aug 7, 2024

Uh oh!

stuartmorgan-g commented Aug 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

engine-flutter-autoroll commented Aug 6, 2024 •

edited by ditman

Loading

ditman commented Aug 6, 2024 •

edited

Loading