[Tool] Add ability to check dependencies independently of dev-dependencies, exclude integration_test from dependencies#6446
Merged
auto-submit[bot] merged 9 commits intomainfrom Apr 3, 2024
Conversation
…exclude integration_test from dependencies
Contributor
|
auto label is removed for flutter/packages/6446, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
reidbaker
commented
Apr 2, 2024
| // pigeon/platform_tests/shared_test_plugin_code is allowed to violate | ||
| // the dev only dependencies rule beause pidgeon has generated tests that | ||
| // are intended to ship to customers. | ||
| if (pubspec.name == 'shared_test_plugin_code') { |
Contributor
Author
There was a problem hiding this comment.
@stuartmorgan requesting re-review because I am not a fan of how I exempted pidgeon from the new check and am hoping you have a better idea.
Collaborator
There was a problem hiding this comment.
You can just conditionalize this whole new check on being publishable, and remove the warning:
stuartmorgan-g
approved these changes
Apr 3, 2024
Collaborator
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with one minor comment-comment.
Contributor
|
auto label is removed for flutter/packages/6446, due to - The status or check suite Mac_arm64 macos_platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2024
…-dependencies, exclude integration_test from dependencies (flutter/packages#6446)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 4, 2024
flutter/packages@0e848fa...dce6f0c 2024-04-04 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.3.3 to 1.3.4 (flutter/packages#6459) 2024-04-03 tarrinneal@gmail.com [pigeon] Allow multi instance support with message channel name suffix (flutter/packages#6224) 2024-04-03 reidbaker@google.com [Tool] Add ability to check dependencies independently of dev-dependencies, exclude integration_test from dependencies (flutter/packages#6446) 2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter from a418568 to e868e2b (34 revisions) (flutter/packages#6455) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
…6472) *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* Additional checks as a followup to #6446 *List which issues are fixed by this PR. You must list at least one issue.* Related to flutter/flutter#145992 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@0e848fa...dce6f0c 2024-04-04 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.3.3 to 1.3.4 (flutter/packages#6459) 2024-04-03 tarrinneal@gmail.com [pigeon] Allow multi instance support with message channel name suffix (flutter/packages#6224) 2024-04-03 reidbaker@google.com [Tool] Add ability to check dependencies independently of dev-dependencies, exclude integration_test from dependencies (flutter/packages#6446) 2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter from a418568 to e868e2b (34 revisions) (flutter/packages#6455) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…ncies, exclude integration_test from dependencies (flutter#6446) Create a linter that ensures that `integration_test` is not used in dependencies. Will be paired with a change to documentation ``` If you are considering adding an external dependency: Consider other options, and discuss with #hackers-ecosystem in Discord. * If you add a dev_dependency on an external package, pin it to a specific version if at all possible. * If you add a dependency on an external package in an example/, pin it to a specific version if at all possible. * Some dependencies should only be linked as dev dependencies like integration_test ``` Related to flutter/flutter/issues/145992
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…lutter#6472) *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* Additional checks as a followup to flutter#6446 *List which issues are fixed by this PR. You must list at least one issue.* Related to flutter/flutter#145992 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a linter that ensures that
integration_testis not used in dependencies.Will be paired with a change to documentation
Related to flutter/flutter/issues/145992
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).