[in_app_purchase] Convert refreshReceipt(), startObservingPaymentQueue(), stopObservingPaymentQueue(), registerPaymentQueueDelegate(), removePaymentQueueDelegate(), showPriceConsentIfNeeded() to Pigeon#6165
Merged
auto-submit[bot] merged 19 commits intoflutter:mainfrom Feb 21, 2024
Conversation
gaaclarke
reviewed
Feb 21, 2024
Member
gaaclarke
left a comment
There was a problem hiding this comment.
Awesome, nice to see this all fall into place. I just have a few minor style notes.
packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.m
Outdated
Show resolved
Hide resolved
..._app_purchase/in_app_purchase_storekit/example/shared/RunnerTests/InAppPurchasePluginTests.m
Show resolved
Hide resolved
| NSDictionary *details = ((FlutterError *)result).details; | ||
|
|
||
| FlutterError *error; | ||
| id result = [self.plugin retrieveReceiptDataWithError:&error]; |
Member
There was a problem hiding this comment.
Can you remove the use of id here too please?
| XCTAssertTrue(result); | ||
| } | ||
|
|
||
| #if TARGET_OS_IOS |
Member
There was a problem hiding this comment.
Why is this only for iOS? Add a quick comment in the code if you intended this.
gaaclarke
approved these changes
Feb 21, 2024
| @@ -1,3 +1,7 @@ | |||
| ## 0.3.12 | |||
|
|
|||
| * Converts `refreshReceipt()`, `startObservingPaymentQueue()`, `stopObservingPaymentQueue()`, `registerPaymentQueueDelegate()`, `removePaymentQueueDelegate()`, `showPriceConsentIfNeeded()` to pigeon. | |||
Member
There was a problem hiding this comment.
Can you limit this to 80 columns please.
| } | ||
|
|
||
| #if TARGET_OS_IOS | ||
| /// presentCodeRedemptionSheetWithError:error is only available on iOS |
Member
There was a problem hiding this comment.
Can you put this before the #if please?
Contributor
|
auto label is removed for flutter/packages/6165, due to - The status or check suite Mac_arm64 macos_platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 22, 2024
…mentQueue(), stopObservingPaymentQueue(), registerPaymentQueueDelegate(), removePaymentQueueDelegate(), showPriceConsentIfNeeded() to Pigeon (flutter/packages#6165)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 22, 2024
flutter/packages@48048f6...078c2a3 2024-02-22 engine-flutter-autoroll@skia.org Manual roll Flutter from 5129806 to efee280 (47 revisions) (flutter/packages#6180) 2024-02-22 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from bae5e49 to abb292a (1 revision) (flutter/packages#6179) 2024-02-21 louisehsu@google.com [in_app_purchase] Convert refreshReceipt(), startObservingPaymentQueue(), stopObservingPaymentQueue(), registerPaymentQueueDelegate(), removePaymentQueueDelegate(), showPriceConsentIfNeeded() to Pigeon (flutter/packages#6165) 2024-02-21 43054281+camsim99@users.noreply.github.com [camerax] Modifies initialized camera info to reflect default AF/AE modes and the ability to set focus points for each (flutter/packages#6109) 2024-02-21 43054281+camsim99@users.noreply.github.com [camerax] Implements `setFocusPoint`, `setExposurePoint`, `setExposureOffset` (flutter/packages#6059) 2024-02-21 stuartmorgan@google.com [various] Commit Windows build migrations (flutter/packages#6175) 2024-02-21 kevmoo@users.noreply.github.com [flutter_markdown] Support wasm (flutter/packages#6168) 2024-02-21 737941+loic-sharma@users.noreply.github.com [ci] Run Windows Arm64 build tests post-submit (flutter/packages#6166) 2024-02-21 stuartmorgan@google.com [url_launcher] Remove `renderView` usage (flutter/packages#6137) 2024-02-21 b@sdevaan.nl [camera_android_camerax] Fix typo in readme (flutter/packages#6143) 2024-02-21 stuartmorgan@google.com [local_auth] Switch iOS endorsement to `local_auth_darwin` (flutter/packages#6107) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of flutter/flutter#117910
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.