[pigeon] Adds ProxyApi to AST generation#5861
Merged
auto-submit[bot] merged 20 commits intoflutter:mainfrom Jan 30, 2024
Merged
[pigeon] Adds ProxyApi to AST generation#5861auto-submit[bot] merged 20 commits intoflutter:mainfrom
auto-submit[bot] merged 20 commits intoflutter:mainfrom
Conversation
11 tasks
tarrinneal
reviewed
Jan 23, 2024
Contributor
tarrinneal
left a comment
There was a problem hiding this comment.
First read through. Nothing too problematic imo. Will approve after another read through.
tarrinneal
approved these changes
Jan 25, 2024
Contributor
tarrinneal
left a comment
There was a problem hiding this comment.
Thanks for making those changes. I think this is good to land as is. If @stuartmorgan wants to weigh in, now's the time!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 31, 2024
flutter/packages@25abb5d...5b48c44 2024-01-30 ian@hixie.ch [rfw] Enable subscribing to the root of a DynamicContent (flutter/packages#5848) 2024-01-30 10687576+bparrishMines@users.noreply.github.com [pigeon] Adds ProxyApi to AST generation (flutter/packages#5861) 2024-01-30 stuartmorgan@google.com [tool] Exempt federated impl examples from CHANGELOG (flutter/packages#6018) 2024-01-30 engine-flutter-autoroll@skia.org Manual roll Flutter from 2f6fdf2 to ace9181 (57 revisions) (flutter/packages#6013) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#134777.
This adds the
@ProxyApi,@attached, and@staticannotations and parsing to create the new ProxyApi.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.