[local_auth]: Renamed local_auth_ios to local_auth_darwin#5809
[local_auth]: Renamed local_auth_ios to local_auth_darwin#5809auto-submit[bot] merged 9 commits intoflutter:mainfrom OutdatedGuy:feat/rename-local-auth-ios
local_auth_ios to local_auth_darwin#5809Conversation
..._auth_darwin/example/ios/Runner/Assets.xcassets/AppIcon.appiconset/Icon-App-1024x1024@1x.png
Outdated
Show resolved
Hide resolved
packages/local_auth/local_auth_darwin/example/ios/Runner.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
packages/local_auth/local_auth_darwin/example/ios/Runner.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
stuartmorgan-g
left a comment
There was a problem hiding this comment.
I'll do a full re-review sometime this week, but one initial note from CI:
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Mostly looks good now! Just some minor things.
packages/local_auth/local_auth_darwin/darwin/local_auth_darwin.podspec
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This file should move to darwin/Tests/, and the reference in the Xcode project updated accordingly. (You'll want to change the file's reference type from group-local to project-local in the Xcode UI).
There was a problem hiding this comment.
Hi, I don't use XCode much so I have no idea what you mean. Can someone else do this instead?
There was a problem hiding this comment.
@jmagman @stuartmorgan @LouiseHsu Any updates on this?
There was a problem hiding this comment.
@OutdatedGuy We all have a lot of other things we're working on; if you want someone else to do this, you'll need to wait until one of us has time.
There was a problem hiding this comment.
I've pushed this change.
|
This will need to be reconciled with main due to the change from iOS 11 to iOS 12 as a minimum version. |
jmagman
left a comment
There was a problem hiding this comment.
LGTM! Can you rebase and fix up the merge conflicts again, then we're ready to merge. Really appreciate you tackling this, looking forward to the macOS support on top of this!
There was a problem hiding this comment.
Actually this needs the PrivacyInfo.xcprivacy pulled in and resource_bundles updated to local_auth_darwin_privacy:
-> local_auth_darwin (0.0.1)
- NOTE | url: The URL (https://pub.dev/packages/local_auth_darwin) is not reachable.
- ERROR | [iOS] file patterns: The `resource_bundles` pattern for `local_auth_ios_privacy` did not match any file.
|
Can you also switch Line 91 in 316bde0 Hopefully almost done 🤞 |
|
@stuartmorgan can you take a look at this again? Blocked on your change request. |
|
I'll prep a PR to switch |
flutter/packages@11152d2...0a69259 2024-02-09 everythingoutdated@gmail.com [local_auth]: Renamed `local_auth_ios` to `local_auth_darwin` (flutter/packages#5809) 2024-02-09 ltv.luongthevinh@gmail.com [webview_flutter] Add listener for content offset (flutter/packages#3444) 2024-02-09 David.Chopin@wwt.com [go_router] Expose full `Uri` on `GoRouterState` in `GoRouterRedirect` (flutter/packages#5742) 2024-02-09 stuartmorgan@google.com [webview_flutter] Minor test cleanup (flutter/packages#6031) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Renames
local_auth_iostolocal_auth_darwinresolves flutter/flutter#141020
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.