[rfw] Add OverflowBar widget and Update ButtonBar widget implementation#5807
[rfw] Add OverflowBar widget and Update ButtonBar widget implementation#5807auto-submit[bot] merged 2 commits intoflutter:mainfrom TahaTesser:replace_button_bar
OverflowBar widget and Update ButtonBar widget implementation#5807Conversation
OverflowBar and Replace ButtonBar with a backwards compatible implementationOverflowBar widget and Update ButtonBar widget implementation
This comment was marked as resolved.
This comment was marked as resolved.
|
I don't understand the diff, can you explain it in more detail? Why is the new rendering different? |
There is no more diff now (there was one before because I ran run_tests.sh --update-goldens on my M1 MacBook) |
|
@Hixie Resolved version conflicts. |
|
Resolved new conflicts |
There was a problem hiding this comment.
this all needs to be markdown with hyperlinks and so on (sorry if i wasn't clear in the earlier comment).
What I mean is e.g. ButtonBar needs to be [ButtonBar], package:flutter/material.dart needs to be whatever the magic incantation is to reference the material library (maybe just [material]?), rfw needs to either be in backticks or uppercase, the parameters in the list should be in backticks, etc.
There was a problem hiding this comment.
Ahh my bad. Thanks for the suggestion!
package:flutter/material.dart can be simply referenced as "Flutter's material library". We reference like this in the framework too in various classes
Hixie
left a comment
There was a problem hiding this comment.
modulo the documentation fixes requested above
…implementation (flutter/packages#5807)
flutter/packages@516648a...25abb5d 2024-01-30 tessertaha@gmail.com [rfw] Add `OverflowBar` widget and Update `ButtonBar` widget implementation (flutter/packages#5807) 2024-01-30 stuartmorgan@google.com [ci] Reduce tasks slightly (flutter/packages#6011) 2024-01-29 stuartmorgan@google.com Clarify issue requirement (flutter/packages#6010) 2024-01-29 stuartmorgan@google.com [various] Disambiguate TestDefaultBinaryMessengerBinding (flutter/packages#6009) 2024-01-29 engine-flutter-autoroll@skia.org Manual roll Flutter from a8efa77 to 2f6fdf2 (23 revisions) (flutter/packages#6008) 2024-01-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.1 to 3.23.2 (flutter/packages#5987) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Looks like the test coverage is no longer at 100% since this PR. |
Filed a fix #6020 |
fixes [
RFW] ReplaceButtonBarwith a backwards compatible implementation usingOverflowBarDescription
This adds
OverflowBarwidget to material widgets and updatesButtonBar(to be deprecated widget) to useOverflowBarunderneath for backwards compatibility.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.