[camera] Camera with MediaSettings: platform implementations (federated) by PROGrand · Pull Request #5223 · flutter/packages

PROGrand · 2023-10-24T19:51:01Z

Platform implementations of federated plugin

This is the platform implementations part of camera PR #3586.

camera_platform_interface: 2.6.0 merged and published in PR #3615.

Now repeating steps 3,4 (see Changing federated plugins), because camera/camera depends on implementations camera/camera_android, camera/camera_web etc.

MediaSettings.low changed to const MediaSettings(resolutionPreset: ResolutionPreset.low).

Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>

Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>

jmagman · 2024-03-13T21:15:05Z

@stuartmorgan this is blocked on your review

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.h

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettingsAVWrapper.h

packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraSettingsTests.m

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m

PROGrand · 2024-03-14T19:27:31Z

@stuartmorgan Thank, you for review. Your suggestions are applied.

vashworth · 2024-04-03T20:59:59Z

@stuartmorgan Can you take a look when you have time?

stuartmorgan-g

Sorry for the delay again; just a few last small things.

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.h

packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m

packages/camera/camera_avfoundation/ios/Classes/FLTCam.m

PROGrand · 2024-04-05T11:47:16Z

@stuartmorgan suggestions applied

stuartmorgan-g

LGTM! Could you rebase and squash a few of the commits together to get this under 250 commits, so that the CLA check will pass without intervention?

suggestions applied AssertPositiveNumberOrNil: macro to inline formatted .class to +class Update packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m Co-authored-by: Jenn Magder <magder@google.com> applied suggestions. 02/25/2024. dependency injection (DI) variant for unit test ObjC suggestions applied suggestion applied updated camera_platform_interface versions reverted changes to camera merged 01/07/2024 refactored and co0mmented warning suppressions. renamed MediaRecorderBuilder.RecordingParameters merged 12/07/2023

stuartmorgan-g

A bunch of files showed as changed since review, and because of the squash I can't tell if that's a GitHub artifact of the squash, or actual changes, so I re-reviewed those files. That turned up a few more minor comments which may be things I just didn't previously review, but I've flagged them regardless. Sorry that means one more quick pass.

packages/camera/camera_web/example/pubspec.yaml

packages/camera/camera_windows/example/pubspec.yaml

packages/camera/camera_avfoundation/example/lib/camera_controller.dart

packages/camera/camera_avfoundation/example/lib/main.dart

packages/camera/camera_android_camerax/example/pubspec.yaml

packages/camera/camera_android_camerax/pubspec.yaml

two lines

PROGrand · 2024-04-05T15:29:59Z

@stuartmorgan resolved

stuartmorgan-g

Thanks!

…(federated) (flutter/packages#5223)

flutter/packages@764d997...6b4d8b6 2024-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.9 to 3.24.10 (flutter/packages#6480) 2024-04-07 pdenert09@gmail.com Add limit to image_picker_platform_interface (flutter/packages#6434) 2024-04-07 engine-flutter-autoroll@skia.org Roll Flutter from 477ebd8 to 98d23f7 (16 revisions) (flutter/packages#6478) 2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter from ac2ca93 to 477ebd8 (32 revisions) (flutter/packages#6470) 2024-04-05 PROGrand@users.noreply.github.com [camera] Camera with MediaSettings: platform implementations (federated) (flutter/packages#5223) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ed) (flutter#5223) This is the `platform implementations` part of `camera` PR flutter#3586. `camera_platform_interface: 2.6.0` merged and published in PR flutter#3615. Now repeating steps 3,4 (see [Changing federated plugins](https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins)), because `camera/camera` depends on implementations `camera/camera_android`, `camera/camera_web` etc.

PROGrand and others added 30 commits March 29, 2023 17:46

added MediaSettings

f294625

updated changelog

5ca79b9

MediaSettings introduced.

e08e046

Merge branch 'flutter:main' into main

21617de

excerpts added. formatted.

59d66d3

versions and changelogs

aeec92e

CameraPlatform.createCameraWithSettings

869b787

Merge branch 'main' into main

3cf6030

Merge branch 'flutter:main' into main

6ac763e

Update CHANGELOG.md

a40177a

Update camera_test.dart

fea1fc7

MediaSettings.low changed to const MediaSettings(resolutionPreset: ResolutionPreset.low).

Update main.dart

9f71f8d

MediaSettings.low removed

4a0ac77

media settings low

8fcf1ae

merger mediasettings

da4ecd8

resolved multiple @hellohuanlin зкщзÑproposals

16645ef

fps control

d7dea54

Fixed pausing preview on already paused or closed session.

6caea7e

Prevent pausing preview on uninitialized controller.

4bec8f3

Prevent pausing preview on disposed controller.

11b43c1

Merge branch 'flutter:main' into main

772e011

formatted

dbb752d

Merge branch 'main' into main

7f01b93

Update packages/camera/camera_android/CHANGELOG.md

3506af1

Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>

Update packages/camera/camera/CHANGELOG.md

8f95dc2

Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>

bump gradle:7.20 in CHANGELOG

6b1f96c

commented feature properties

6f97b51

android_camera_camerax CHANGELOD update

d96f9d5

revert default enableAudio to false

401adce

properly commented IntFeature

8edd212

PROGrand marked this pull request as draft March 6, 2024 23:03

PROGrand marked this pull request as ready for review March 7, 2024 11:52

mossmana changed the title ~~Camera with MediaSettings: platform implementations (federated)~~ [camera] Camera with MediaSettings: platform implementations (federated) Mar 13, 2024

jmagman approved these changes Mar 13, 2024

View reviewed changes

stuartmorgan-g requested changes Mar 14, 2024

View reviewed changes

PROGrand requested a review from stuartmorgan-g March 14, 2024 19:26

stuartmorgan-g requested changes Apr 4, 2024

View reviewed changes

PROGrand requested a review from stuartmorgan-g April 5, 2024 11:46

stuartmorgan-g approved these changes Apr 5, 2024

View reviewed changes

PROGrand force-pushed the camera-with-settings-platform-implementations branch from faa7b8f to adf6929 Compare April 5, 2024 14:14

PROGrand and others added 2 commits April 5, 2024 17:24

Merge branch 'main' into camera-with-settings-platform-implementations

864b2e1

rebased, squashed, merged

30837eb

stuartmorgan-g requested changes Apr 5, 2024

View reviewed changes

suggestions applied

8b29fa0

two lines

PROGrand requested a review from stuartmorgan-g April 5, 2024 15:27

stuartmorgan-g approved these changes Apr 5, 2024

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2024

auto-submit bot merged commit caf48bc into flutter:main Apr 5, 2024

engine-flutter-autoroll mentioned this pull request Apr 8, 2024

Roll Packages from 764d9974522b to 6b4d8b6cdb39 (5 revisions) flutter/flutter#146429

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 8, 2024

caf48bc [camera] Camera with MediaSettings: platform implementations …

ae305b2

…(federated) (flutter/packages#5223)

Conversation

PROGrand commented Oct 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Platform implementations of federated plugin

Uh oh!

jmagman commented Mar 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PROGrand commented Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vashworth commented Apr 3, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PROGrand commented Apr 5, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PROGrand commented Apr 5, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

PROGrand commented Oct 24, 2023 •

edited

Loading

PROGrand commented Mar 14, 2024 •

edited

Loading