[image_picker_ios] requestFullMetadata property should convert from NSNumber to boolValue#5188
[image_picker_ios] requestFullMetadata property should convert from NSNumber to boolValue#5188codingiran wants to merge 1 commit intoflutter:mainfrom codingiran:main
requestFullMetadata property should convert from NSNumber to boolValue#5188Conversation
…SNumber to boolValue
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@codingiran Thank you for the contribution! Before I can review this PR, can you please complete the steps in the Pre-launch Checklist (which I added back to the PR description). This includes signing the CLA and adding tests. |
requestFullMetadata property should convert from NSNumber to boolValuerequestFullMetadata property should convert from NSNumber to boolValue
Remove this issue and open a new one, please check |
In objective-c, NSNumber should always convert to Bool manually by type conversion, otherwise nonnull NSNumber will convert to "YES" automatically
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.