[url_launcher] Add support for setting show title on Chrome Custom Tabs by Alex-Usmanov · Pull Request #5166 · flutter/packages

Alex-Usmanov · 2023-10-18T04:49:16Z

Added showTitle option to platform interface & app-facing api
Made use of that parameter on android platform in order to set show title on Chrome Custom Tabs, when it is being used
Made android implementation use both legacy & new api (instead of passthrough from new to legacy), in order to allow use of the aforementioned parameter
Added a button to the example to test this parameter
Added tests

(Notice title at the top of the page "CyLog Software - HTTP ...")

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Alex-Usmanov · 2023-10-18T04:52:33Z

packages/url_launcher/url_launcher_android/lib/url_launcher_android.dart

    required Map<String, String> headers,
    String? webOnlyWindowName,
  }) async {
+    final WebViewOptions webViewOptions = WebViewOptions(


There is a fair share of code duplication here, but it could only be resolved after flutter/flutter#66721 unfortunately (could not make it a passthrough because there is no way to pass the useWebView parameter to launchUrl).

Did my best to reduce it

ditman · 2023-10-19T05:25:01Z

This cannot be implemented on the web, since the browser controls how tabs/windows are displayed.

(Feel free to @ me if I can be of any help with the rest of the PR!)

stuartmorgan-g · 2023-10-19T15:14:31Z

packages/url_launcher/url_launcher_macos/example/pubspec.yaml

All the packages where the only change is dependency_overrides can be reverted.

Did not think of that, done ✅

packages/url_launcher/url_launcher_platform_interface/lib/src/types.dart

Alex-Usmanov · 2023-10-20T10:10:51Z

Added a configuration object for in app browser
Removed unnecessary dependency overrides

*Will update docs once #5155 lands

stuartmorgan-g

Generally looks good, just small comments. Thanks for your patience!

stuartmorgan-g · 2023-12-04T18:31:50Z

packages/url_launcher/url_launcher_platform_interface/lib/src/types.dart

+  /// Creates a new InAppBrowserConfiguration with given settings.
+  const InAppBrowserConfiguration({this.showTitle = false});
+
+  /// Whether or not to show the webpage title when using Chrome Custom Tabs.


Please remove "when using Chrome Custom Tabs."

stuartmorgan-g · 2023-12-04T18:33:26Z

packages/url_launcher/url_launcher_platform_interface/lib/src/types.dart

+
+  /// Whether or not to show the webpage title when using Chrome Custom Tabs.
+  ///
+  /// Only works on Android.


"May not be supported on all platforms."

stuartmorgan-g · 2023-12-04T18:35:36Z

packages/url_launcher/url_launcher_platform_interface/lib/src/types.dart

The changes in this file will need a simple test (e.g., testing the default InAppBrowserConfiguration behavior).

Done. Did not quite think of a lot of testcases, you can find those in packages/url_launcher/url_launcher_platform_interface/test/in_app_browser_configuration_test.dart and packages/url_launcher/url_launcher_platform_interface/test/launch_options_test.dart

stuartmorgan-g · 2023-12-04T18:36:03Z

packages/url_launcher/url_launcher_platform_interface/lib/src/types.dart

This package will need a version bump and changelog.

stuartmorgan-g · 2023-12-04T18:37:31Z

packages/url_launcher/url_launcher_android/pubspec.yaml

This will need a version change.

stuartmorgan-g · 2023-12-04T18:44:55Z

...r/url_launcher_android/android/src/main/java/io/flutter/plugins/urllauncher/UrlLauncher.java

-  private static boolean openCustomTab(
-      @NonNull Context context, @NonNull Uri uri, @NonNull Bundle headersBundle) {
-    CustomTabsIntent customTabsIntent = new CustomTabsIntent.Builder().build();
+  @VisibleForTesting


Why was this made public for testing? Testing should be done via public interface whenever possible to make tests easier to maintain and less likely to miss important behavior.

Reverted this change as well

stuartmorgan-g · 2023-12-04T18:45:01Z

...r/url_launcher_android/android/src/main/java/io/flutter/plugins/urllauncher/UrlLauncher.java

  }

-  private static @NonNull Bundle extractBundle(Map<String, String> headersMap) {
+  @VisibleForTesting


Same question here.

stuartmorgan-g · 2023-12-04T18:45:34Z

...l_launcher_android/android/src/test/java/io/flutter/plugins/urllauncher/UrlLauncherTest.java

+    String url = "https://flutter.dev";
+    HashMap<String, String> headers = new HashMap<>();
+    String headerKey = "Content-Type";
+    headers.put(headerKey, "text/plain");


Headers don't seem relevant to this test, so shouldn't need to be set up.

Yes, you are right. Removed this

stuartmorgan-g · 2023-12-04T18:45:38Z

...l_launcher_android/android/src/test/java/io/flutter/plugins/urllauncher/UrlLauncherTest.java

+    String url = "https://flutter.dev";
+    HashMap<String, String> headers = new HashMap<>();
+    String headerKey = "Content-Type";
+    headers.put(headerKey, "text/plain");


stuartmorgan-g · 2023-12-04T18:48:49Z

packages/url_launcher/url_launcher/lib/src/types.dart

+
+  /// Whether or not to show the webpage title when using Chrome Custom Tabs.
+  ///
+  /// Only works on Android.


Same comments here as on the platform interface; platform details shouldn't be documented at this level.

Made this comment platform-independent

Alex-Usmanov · 2023-12-11T07:40:13Z

Thank you for your valuable feedback and your time!
I am pretty sure I've fixed everything regarding the code part of this PR. CI seems to be failing due to specifics of landing PRs. I can split this up in two as soon as we get over the final touches

stuartmorgan-g

This looks good with a few minor nits; please feel free to split out the first sub-PR with just the platform interface changes.

stuartmorgan-g · 2023-12-15T19:20:12Z

packages/url_launcher/url_launcher/example/lib/main.dart

+                onPressed: () => setState(() {
+                  _launched = _launchInAppWithBrowserOptions(toLaunch);
+                }),
+                child: const Text('Launch in app with showTitle'),


"[...] with title displayed"

stuartmorgan-g · 2023-12-15T19:21:38Z

packages/url_launcher/url_launcher_android/CHANGELOG.md

-## NEXT
+## 6.3.0

+* Implement taking in `BrowserConfiguration` parameter


These need to follow the CHANGELOG style guide linked from the PR checklist (verb form, punctuation).

stuartmorgan-g · 2023-12-15T19:23:22Z

packages/url_launcher/url_launcher_android/pigeons/messages.dart

+
+  /// Whether or not to show the webpage title.
+  ///
+  /// May not be supported on all platforms.


This file is internal to the Android implementation, so this sentence doesn't make sense here.

stuartmorgan-g · 2023-12-15T19:24:26Z

packages/url_launcher/url_launcher_platform_interface/lib/src/types.dart

  final Map<String, String> headers;
 }

+/// Additional configuration options for [PreferredLaunchMode.inAppBrowserView]


Nit: Missing a period.

This is #5166 portion of platform interface changes. Adds `InAppBrowserConfiguration` parameter, as well as `InAppBrowserConfiguration.showTitle` parameter that configures whether to show or not to show webpage title

stuartmorgan-g · 2024-01-30T20:54:09Z

Update from triage: This is blocked on #5759, which is currently in review.

Alex-Usmanov · 2024-02-12T17:36:21Z

I made a terrible mistake with source control and #5166 was automatically closed. The restored version is in #6097.

Once again sorry for the inconvenience 😔

…ations (#5759) Platform implementation portion of #5166. Implements `InAppBrowserConfiguration` support on Android, as well as support for `InAppBrowserConfiguration.showTitle` parameter for hiding/showing webpage title in Android Custom Tabs.

Alex-Usmanov requested review from cbracken, chunhtai, ditman, gmackall and stuartmorgan-g as code owners October 18, 2023 04:49

github-actions bot added p: go_router platform-android platform-ios platform-linux platform-macos platform-web platform-windows p: url_launcher labels Oct 18, 2023

Alex-Usmanov commented Oct 18, 2023

View reviewed changes

ditman removed their request for review October 19, 2023 05:25

stuartmorgan-g reviewed Oct 19, 2023

View reviewed changes

github-actions bot removed p: go_router platform-ios platform-linux platform-macos platform-web platform-windows labels Oct 20, 2023

cbracken removed their request for review October 21, 2023 01:36

chunhtai requested review from mdebbar and removed request for chunhtai October 23, 2023 21:40

Alex-Usmanov requested a review from stuartmorgan-g October 30, 2023 06:13

stuartmorgan-g requested changes Dec 4, 2023

View reviewed changes

Alex-Usmanov requested a review from stuartmorgan-g December 11, 2023 07:40

stuartmorgan-g reviewed Dec 15, 2023

View reviewed changes

This was referenced Dec 26, 2023

[url_launcher] Add InAppBrowserConfiguration parameter #5758

Merged

[url_launcher] Add InAppBrowserConfiguration parameter in implementations #5759

Merged

mdebbar removed their request for review February 6, 2024 15:45

Alex-Usmanov closed this Feb 12, 2024

Alex-Usmanov force-pushed the main branch from 1ad83a2 to 0a69259 Compare February 12, 2024 12:04

Alex-Usmanov mentioned this pull request Feb 12, 2024

[url_launcher] Add support for setting show title on Chrome Custom Tabs #6097

Merged

11 tasks

Conversation

Alex-Usmanov commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Alex-Usmanov Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ditman commented Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Alex-Usmanov commented Oct 20, 2023

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Alex-Usmanov commented Dec 11, 2023

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Jan 30, 2024

Uh oh!

Alex-Usmanov commented Feb 12, 2024

Uh oh!

Reviewers

Alex-Usmanov commented Oct 18, 2023 •

edited

Loading

Alex-Usmanov Oct 18, 2023 •

edited

Loading

ditman commented Oct 19, 2023 •

edited

Loading