[google_maps_flutter_web] Adds missing MapOptions parameters. by Franreno · Pull Request #4553 · flutter/packages

Franreno · 2023-07-23T20:32:08Z

As the linked issue states, there are some MapOptions parameters that can't be modified on the MapConfiguration when using google_maps_flutter_web package.

The parameters are:

mapTypeControl: Enables the user to change mapTypes.
fullscreenControl: Enables the user make the map fullscreen.
streetViewControl: Enables the user to use the streetview functionality.

There parameters where previously set to false by default at the MapConfiguration class. With this Pull Request, these parameters could be setted to true or false.

As the previous version handles these options as false by default, I opted to keep them as false if the user has not setted them to true.

Using this approach and creating a simple example app that uses this new implementation, we can see that these new controllers can be used on the google_maps_flutter_web package.

new_options_parameters.mp4

Fixes #104111

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…ontrols.

…tion

ditman · 2023-07-24T18:45:27Z

@Franreno these web-only options are a little bit unexpected. We're deciding on how to best land this. We might have to create a new WebMapConfiguration type to group together all the web-only config: the 3 values you're adding + fortyFiveDegreeImagery and webGestureHandling that have landed very recently (in fact they're still not available from the core plugin).

ditman · 2023-07-24T22:19:30Z

(Discussed on chat with @stuartmorgan and we decided to go with the PRs as they are, and then maybe do a more thorough refactor of per-platform settings, for example "liteMode" doesn't make sense in the web or iOS either)

ditman · 2023-07-24T22:23:42Z

@Franreno there's some automated "checks" failing, please work on the branch until all automated checks pass, otherwise we can't merge it. Currently, there's the following warnings/errors being reported:

Analyzing google_maps_flutter_web...

  error - example/integration_test/google_maps_controller_test.dart:411:13 - The named parameter 'mapTypeControl' isn't defined. Try correcting the name to an existing named parameter's name, or defining a named parameter with the name 'mapTypeControl'. - undefined_named_parameter
  error - example/integration_test/google_maps_controller_test.dart:412:13 - The named parameter 'fullscreenControl' isn't defined. Try correcting the name to an existing named parameter's name, or defining a named parameter with the name 'fullscreenControl'. - undefined_named_parameter
  error - example/integration_test/google_maps_controller_test.dart:413:13 - The named parameter 'streetViewControl' isn't defined. Try correcting the name to an existing named parameter's name, or defining a named parameter with the name 'streetViewControl'. - undefined_named_parameter
  error - lib/src/convert.dart:77:42 - The getter 'mapTypeControl' isn't defined for the type 'MapConfiguration'. Try importing the library that defines 'mapTypeControl', correcting the name to the name of an existing getter, or defining a getter or field named 'mapTypeControl'. - undefined_getter
  error - lib/src/convert.dart:78:45 - The getter 'fullscreenControl' isn't defined for the type 'MapConfiguration'. Try importing the library that defines 'fullscreenControl', correcting the name to the name of an existing getter, or defining a getter or field named 'fullscreenControl'. - undefined_getter
  error - lib/src/convert.dart:79:45 - The getter 'streetViewControl' isn't defined for the type 'MapConfiguration'. Try importing the library that defines 'streetViewControl', correcting the name to the name of an existing getter, or defining a getter or field named 'streetViewControl'. - undefined_getter
   info - example/integration_test/google_maps_controller_test.dart:410:33 - The value of the argument is redundant because it matches the default value. Try removing the argument. - avoid_redundant_argument_values

7 issues found.

You can find more on the "View more" link of each check (search for the stdout of the failing step).

In this case, the analyzer is complaining about missing types because this PR isn't setup with the correct dependencies. Read instructions on how this PR needs to be configured here:

https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins

ditman · 2023-07-24T22:24:34Z

(Moving this to draft until it's more ready to review!)

Franreno · 2023-07-25T00:26:49Z

Hello @ditman, I really appreciate your suggestions and thank you for helping me!

(Discussed on chat with @stuartmorgan and we decided to go with the PRs as they are, and then maybe do a more thorough refactor of per-platform settings, for example "liteMode" doesn't make sense in the web or iOS either)

As your comment states, this PR would be valid if the tests are passing? If so, only the web google maps would receive these new parameters?

I'm currently working to get the tests fixed!
As always, thank you for your help.

Franreno · 2023-07-25T00:49:32Z

@ditman I think the version_check check is failing because I haven't updated the changelogs for the other packages that were included in the dependancies override. If I shall update them, please, let me know.

stuartmorgan-g · 2023-07-25T16:24:36Z

@ditman I think the version_check check is failing because I haven't updated the changelogs for the other packages that were included in the dependancies override. If I shall update them, please, let me know.

Packages that don't actually need dependency overrides should just have the dependency overrides reverted.

Franreno · 2023-07-25T17:13:09Z

Packages that don't actually need dependency overrides should just have the dependency overrides reverted.

I have reverted the other packages that didn't needed the dependancies overrides.

The only checks failing are the submit-queue and the Linux repo_checks. I think the repo_checks failing is supposed to happen because I'm making changes to the platform_interface package. But I don't know why the submit-queue is failing.

stuartmorgan-g · 2023-07-25T17:26:24Z

But I don't know why the submit-queue is failing.

It's unrelated to the PR; see https://github.com/flutter/flutter/wiki/Understanding-Packages-tests#specific-tests

Franreno · 2023-07-25T17:40:47Z

Oh okay! Thanks!

Franreno · 2023-07-25T17:42:15Z

Would this PR be valid for review now? If there is anything else that I need to do let me know.

ditman · 2023-07-25T19:47:31Z

Yes, this is ready for review now @Franreno, thanks for keeping the CI happy!

reidbaker

Android +1

stuartmorgan-g · 2023-08-17T16:03:34Z

...gle_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/map_configuration.dart

  final bool? buildingsEnabled;

+  /// True if the control to toggle between map types should be displayed.
+  final bool? mapTypeControl;


These should all end with Enabled, like the existing comparable properties.

stuartmorgan-g · 2023-08-17T16:06:26Z

packages/google_maps_flutter/google_maps_flutter_android/example/pubspec.yaml

  assets:
    - assets/
+
+# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.


Please revert the changes to google_maps_flutter_android and google_maps_flutter_ios.

stuartmorgan-g · 2023-08-17T16:07:50Z

packages/google_maps_flutter/google_maps_flutter/example/pubspec.yaml

Why aren't there any actual changes in this package? Isn't the intent of the PR to allow clients of google_maps_flutter to configure these options?

stuartmorgan-g · 2023-08-17T16:08:39Z

...ps_flutter/google_maps_flutter_web/example/integration_test/google_maps_controller_test.dart

        });

+        testWidgets(
+            'translates mapTypeControl, fullscreenControl, streetViewControl configurations',


Three unrelated things should not be tested in the same test.

stuartmorgan-g · 2023-08-17T16:09:14Z

packages/google_maps_flutter/google_maps_flutter_platform_interface/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.4.1


New functionality is a minor update, not a bugfix update.

stuartmorgan-g · 2023-08-17T16:09:41Z

packages/google_maps_flutter/google_maps_flutter_web/pubspec.yaml

 repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_web
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
-version: 0.5.2
+version: 0.5.2+1


Same here; this should be 0.5.3.

reidbaker · 2023-08-24T18:19:01Z

@Franreno is this still something you are planning to work on?

stuartmorgan-g · 2023-09-21T18:53:30Z

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks!

Franreno added 3 commits July 23, 2023 17:09

Updating configuration to accept mapType, fullscreen and streetview c…

9410577

…ontrols.

Including mapType, fullscreen and streetview controls to MapConfigura…

2ebad26

…tion

Updating changelog

69c8b91

Franreno requested review from ditman and stuartmorgan-g as code owners July 23, 2023 20:32

github-actions bot added p: google_maps_flutter platform-web labels Jul 23, 2023

Adding dependancies override

2198581

ditman mentioned this pull request Jul 24, 2023

[google_maps_flutter_web] Options to disable tilt controls and configure gesture handling #3258

Merged

11 tasks

ditman marked this pull request as draft July 24, 2023 22:25

github-actions bot added platform-android platform-ios labels Jul 25, 2023

Removing unnecessary dependancies overrides

a723032

ditman marked this pull request as ready for review July 25, 2023 19:47

ditman requested review from cyanglaz and reidbaker as code owners July 25, 2023 19:47

Merge branch 'main' into fix104111

c79f485

reidbaker approved these changes Jul 25, 2023

View reviewed changes

stuartmorgan-g requested changes Aug 17, 2023

View reviewed changes

stuartmorgan-g closed this Sep 21, 2023

stuartmorgan-g mentioned this pull request Sep 21, 2023

[google_maps_flutter_web] Add missing MapOptions parameters flutter/flutter#104111

Open

Conversation

Franreno commented Jul 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

ditman commented Jul 24, 2023

Uh oh!

ditman commented Jul 24, 2023

Uh oh!

ditman commented Jul 24, 2023

Uh oh!

ditman commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Franreno commented Jul 25, 2023

Uh oh!

Franreno commented Jul 25, 2023

Uh oh!

stuartmorgan-g commented Jul 25, 2023

Uh oh!

Franreno commented Jul 25, 2023

Uh oh!

stuartmorgan-g commented Jul 25, 2023

Uh oh!

Franreno commented Jul 25, 2023

Uh oh!

Franreno commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ditman commented Jul 25, 2023

Uh oh!

reidbaker left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

reidbaker commented Aug 24, 2023

Uh oh!

stuartmorgan-g commented Sep 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Franreno commented Jul 23, 2023 •

edited

Loading

ditman commented Jul 24, 2023 •

edited

Loading

Franreno commented Jul 25, 2023 •

edited

Loading