[ci] Enable Android emulator-based tests#4494
Merged
auto-submit[bot] merged 15 commits intoflutter:mainfrom Jul 24, 2023
Merged
[ci] Enable Android emulator-based tests#4494auto-submit[bot] merged 15 commits intoflutter:mainfrom
auto-submit[bot] merged 15 commits intoflutter:mainfrom
Conversation
This was referenced Jul 17, 2023
tarrinneal
approved these changes
Jul 21, 2023
reidbaker
approved these changes
Jul 24, 2023
reidbaker
approved these changes
Jul 24, 2023
Contributor
reidbaker
left a comment
There was a problem hiding this comment.
Are the skipped test being run in the older system or are they not being run?
Collaborator
Author
All FTL tests are still being run, this particular change is purely additive. We'll figure out what we want to do with FTL as a follow-up. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 25, 2023
flutter/packages@8028caf...406eac1 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter from d7ed5dc to 9def8f6 (21 revisions) (flutter/packages#4561) 2023-07-25 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Fixes bug where `PlatformWebViewWidget` doesn't rebuild when the controller changes (flutter/packages#4533) 2023-07-24 stuartmorgan@google.com [ci] Enable Android emulator-based tests (flutter/packages#4494) 2023-07-24 rexios@rexios.dev [google_maps_flutter_web] Options to disable tilt controls and configure gesture handling (flutter/packages#3258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
flutter/packages@8028caf...406eac1 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter from d7ed5dc to 9def8f6 (21 revisions) (flutter/packages#4561) 2023-07-25 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Fixes bug where `PlatformWebViewWidget` doesn't rebuild when the controller changes (flutter/packages#4533) 2023-07-24 stuartmorgan@google.com [ci] Enable Android emulator-based tests (flutter/packages#4494) 2023-07-24 rexios@rexios.dev [google_maps_flutter_web] Options to disable tilt controls and configure gesture handling (flutter/packages#3258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
flutter/packages@8028caf...406eac1 2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter from d7ed5dc to 9def8f6 (21 revisions) (flutter/packages#4561) 2023-07-25 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Fixes bug where `PlatformWebViewWidget` doesn't rebuild when the controller changes (flutter/packages#4533) 2023-07-24 stuartmorgan@google.com [ci] Enable Android emulator-based tests (flutter/packages#4494) 2023-07-24 rexios@rexios.dev [google_maps_flutter_web] Options to disable tilt controls and configure gesture handling (flutter/packages#3258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds emulators to the Android platform test tasks, and enable both native integration tests and
flutter testDart integration tests. This finally gives us presubmit coverage of Android integration tests for non-team-member PRs, as well as giving us a path to reducing the dependency on FTL for all of our Android testing.Currently this uses Android 13 emulators; we could expand this to a set of legacy version emulator tests in the future once this is in place.
Some specific notes:
shared_preferenceswas missing its debug entitlement, which prevented the debug service from running, and thus brokeflutter test; we'd just never noticed because FTL tests don't need that mechanism to work.testinstead oftestWidget, which we only check for indrive-examples, so hadn't noticed.Fixes flutter/flutter#93810