[pointer_interceptor] Remove iOS and Android from example#442
Conversation
The package is web-only, and doesn't build for other platforms, so the example shouldn't be configured for them. This may be a point of user confusion, but it also fails if we fix the repo script to build example apps (which it currently isn't, I believe due to a long-ago regression that hadn't been noticed).
ditman
left a comment
There was a problem hiding this comment.
The package is web-only, and doesn't build for other platforms
The package is only active in the web, but it should compile (and noop) in mobile platforms (see the conditional export here)
I remember running the example app on Android a while back, but maybe it has bit rotted since then? :S
|
Hm, I'll take another look. IIRC it was complaining about |
Thanks for taking another look, I might have screwed up the example since I've written it... or maybe its integration tests :S |
That's not the problem, this is
That line dates back to #256 so I'm not sure how you could ever have run the example on anything but web. So do you want to rewrite the example, or move forward with this PR? |
|
Gosh, you're right, that's bad...
Nah, let's move on with the PR and I'll look at adding an Android version later, since I need to reshuffle a bunch of code to make it work :/ |
Fix analyzer warnings and errors
Bumps [plugin_platform_interface](https://github.com/flutter/packages/tree/main/packages) from 2.1.4 to 2.1.5. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/plugin_platform_interface-v2.1.5/packages) --- updated-dependencies: - dependency-name: plugin_platform_interface dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The package is web-only, and the example doesn't build for other platforms,
so it shouldn't be configured for them.
This may be a point of user confusion, but it also fails if we fix the
repo script to build example apps (which it currently isn't, I believe
due to a long-ago regression that hadn't been noticed).
Pre-launch Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy.CHANGELOG.mdto add a description of the change.///).