[camera_android] Support concurrently image capture and image streaming#4332
Merged
auto-submit[bot] merged 43 commits intoflutter:mainfrom Jun 30, 2023
Merged
[camera_android] Support concurrently image capture and image streaming#4332auto-submit[bot] merged 43 commits intoflutter:mainfrom
auto-submit[bot] merged 43 commits intoflutter:mainfrom
Conversation
camsim99
commented
Jun 27, 2023
| if (image == null) { | ||
| return; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Unrelated fix: acquireNextImage may return null, so added null check.
camsim99
commented
Jun 27, 2023
| }; | ||
|
|
||
| try { | ||
| captureSession.stopRepeating(); |
Contributor
Author
There was a problem hiding this comment.
Unrelated fix: This call should not be necessary for still capture to proceed.
johnmccutchan
approved these changes
Jun 29, 2023
bparrishMines
approved these changes
Jun 30, 2023
Contributor
bparrishMines
left a comment
There was a problem hiding this comment.
LGTM
I believe we were originally concerned with attempting preview, image streaming, and still image capture simultaneously due to hardware limitations on some devices. But it looks like all hardware supports all three simultaneously: https://developer.android.com/reference/android/hardware/camera2/CameraDevice#regular-capture.
However they can be limited by resolutions.
Contributor
Author
Oh, I did not realize this, but that context makes sense. Definitely good to be aware of, though, if we start seeing related bugs. Thanks! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 3, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 3, 2023
flutter/packages@53ed5a0...cdae854 2023-07-01 engine-flutter-autoroll@skia.org Roll Flutter from ff838bc to aa5f4a2 (29 revisions) (flutter/packages#4363) 2023-07-01 stuartmorgan@google.com [tool] Add a flag to skip cleanup (flutter/packages#4357) 2023-07-01 stuartmorgan@google.com [file_selector] Endorse Android (flutter/packages#4329) 2023-07-01 stuartmorgan@google.com [google_sign_in] Convert Android to Pigeon (flutter/packages#4344) 2023-06-30 tarrinneal@gmail.com [Pigeon] readme updates (flutter/packages#3705) 2023-06-30 43054281+camsim99@users.noreply.github.com [camera_android] Support concurrently image capture and image streaming (flutter/packages#4332) 2023-06-30 kustermann.martin@gmail.com Prepare for utf8.encode() to return more precise Uint8List type (flutter/packages#4342) 2023-06-30 tarrinneal@gmail.com [shared_preferences] Adds allowList to setPrefix method. (flutter/packages#3794) 2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter from 51bef1b to ff838bc (12 revisions) (flutter/packages#4346) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly configures surface needed for image capture when image streaming/recording is started to support concurrently still capture and image streaming.
Fixes flutter/flutter#125314.
Apologies for the many commits :(
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).