[go_router] Reduces excessive rebuilds due to inherited look up.#4227
[go_router] Reduces excessive rebuilds due to inherited look up.#4227auto-submit[bot] merged 3 commits intoflutter:mainfrom
Conversation
packages/go_router/CHANGELOG.md
Outdated
There was a problem hiding this comment.
| - Removes GoRouter.location and GoRouter.canPop. | |
| - Removes GoRouter.location and GoRouter.canPop. Use GoRouterState.of().location and Navigator.of().canPop instead. |
breaking change doc for flutter/packages#4227 ## Presubmit checklist - [ ] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [ ] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [ ] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
|
auto label is removed for flutter/packages, pr: 4227, due to - The status or check suite cla/google has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
auto label is removed for flutter/packages, pr: 4227, due to - The status or check suite cla/google has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
auto label is removed for flutter/packages, pr: 4227, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
auto label is removed for flutter/packages, pr: 4227, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@d041934...6b70804 2023-06-23 47866232+chunhtai@users.noreply.github.com [go_router] Reduces excessive rebuilds due to inherited look up. (flutter/packages#4227) 2023-06-23 stuartmorgan@google.com [image_picker] Update to 1.0 (flutter/packages#4285) 2023-06-23 stuartmorgan@google.com [tool] Consider comment-only changes to be dev-only (flutter/packages#4279) 2023-06-23 stuartmorgan@google.com [ci] Switch to LUCI for Android build-all (flutter/packages#4274) 2023-06-23 stuartmorgan@google.com [file_selector] Add file group to save return value (flutter/packages#4222) 2023-06-23 47866232+chunhtai@users.noreply.github.com [go_router] Adds onException to GoRouter constructor. (flutter/packages#4216) 2023-06-23 stuartmorgan@google.com [file_selector] Add file group to save return value - implementations (flutter/packages#4273) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
the solutions for it for my case , is to make the build method don't break ui or duplicate data make it handling the case when data is already loaded class ReportsScreen extends StatefulWidget { class _ReportsScreenState extends State { bool isLoaded = false; @OverRide } |
fixes flutter/flutter#123570
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.