[file_selector] Add getDirectoryPaths#3871
Merged
auto-submit[bot] merged 5 commits intoflutter:mainfrom May 4, 2023
Merged
Conversation
Exposes the new `getDirectoryPaths` API, and updates the desktop implementation package constraints to ensure that the implementations are present. This is a slightly updated recreation of flutter/plugins#6576 Fixes flutter/flutter#74323
This comment was marked as off-topic.
This comment was marked as off-topic.
cbracken
approved these changes
May 4, 2023
Member
cbracken
left a comment
There was a problem hiding this comment.
Looks good modulo a tiny nit on comments.
| /// Screen that allows the user to select one or more directories using `getDirectoryPaths`, | ||
| /// then displays the selected directories in a dialog. | ||
| class GetMultipleDirectoriesPage extends StatelessWidget { | ||
| /// Default Constructor |
Member
There was a problem hiding this comment.
We can probably kill this line. It doesn't add anything. If for some reason we need it, it should end in a period.
Collaborator
Author
There was a problem hiding this comment.
It's because we have public_member_api_docs on, so you have to either put a basically useless comment, or an override. I'll replace this with my go-to not very helpful comment for example constructors that it returns a new instance of the page, since at least that's explaining what it does rather than what it is.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 5, 2023
flutter/packages@6bd59cd...a0f8fd8 2023-05-05 tarrinneal@gmail.com tree fix (flutter/packages#3910) 2023-05-05 tarrinneal@gmail.com manual roll and fix (flutter/packages#3903) 2023-05-04 stuartmorgan@google.com [file_selector] Add `getDirectoryPaths` (flutter/packages#3871) 2023-05-04 75943909+TheUltimateOptimist@users.noreply.github.com [go_router_builder] fixed typo in README (flutter/packages#3835) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
This was referenced Jul 7, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
Exposes the new `getDirectoryPaths` API, and updates the desktop implementation package constraints to ensure that the implementations are present. This is a slightly updated recreation of flutter/plugins#6576 Fixes flutter/flutter#74323
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the new
getDirectoryPathsAPI, and updates the desktop implementation package constraints to ensure that the implementations are present.This is a slightly updated recreation of
flutter/plugins#6576
Fixes flutter/flutter#74323
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).