[pointer_interceptor] Shadow dom tweaks#364
Conversation
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with a couple of questions.
| ..style.left = '0' | ||
| ..style.position = 'relative'; | ||
| ..style.width = '100%' | ||
| ..style.height = '100%'; |
There was a problem hiding this comment.
Is this change fine for stable as well? (If not, you could always update the Flutter SDK requirement so Flutter 2.2 won't versions that have this change.)
There was a problem hiding this comment.
Yes, thanks for asking. I tested this both with stable and master, manually and with the driver tests.
This is backwards compatible, it's just that there's many ways to "cover a parent div" with CSS, but in the engine we only check "are style.width and style.height set (to any value?) else: warn user".
This code is to disable that warning from our own packages.
No need to bump a whole z version.
|
Is this chat still opened? I am trying to avoid reload of iframe url using master/stable channel but can't make it works with slot like you said. Please, help! |
|
@abnerh69 Please don't spam PRs for help. PRs are for discussing the specific PR, nothing else. |
Change the pointer_interceptor so that it works better with the new
slotsway of embedding HtmlElementViews in flutter web master.Related to: flutter/flutter#80524
Pre-launch Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy.CHANGELOG.mdto add a description of the change.///).If you need help, consider asking for advice on the
#hackers-newchannel on Discord.