Skip to content

Comments

[various] Update flutter/plugins links#3256

Merged
stuartmorgan-g merged 11 commits intoflutter:mainfrom
stuartmorgan-g:source-link-updates
Feb 22, 2023
Merged

[various] Update flutter/plugins links#3256
stuartmorgan-g merged 11 commits intoflutter:mainfrom
stuartmorgan-g:source-link-updates

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Feb 22, 2023

Updates links and references to flutter/plugins to use flutter/packages instead, including making the repository pubspec.yaml check stricter in the repo tooling to ensure all packages are pointing to the right place.

Exceptions to the updates are:

  • Changelog entries.
  • Links to pull requests.

This will re-publish all the moved plugins, thus fixing the current redness of release (due to the current versions not being tagged in this repository).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

bparrishMines
bparrishMines approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Feb 22, 2023

Hm, the dart_unit_tests timeouts are a problem. We're touching so many packages that the pathified re-run is running everything again, and that's too much extra time.

I think I'll need to turn the pathified version off in this PR, then back on in a follow-up.

ditman
ditman approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@ditman
Copy link
Member

ditman commented Feb 22, 2023

I think I'll need to turn the pathified version off in this PR, then back on in a follow-up.

Yeah, that sounds good to me!

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Feb 22, 2023

Landing on red to fix the tree. Everything but pathified Dart unit tests had passed in the previous run, and those are now off, so in the interested of getting the tree open again I'm going to land without waiting for everything to run again.

@stuartmorgan-g stuartmorgan-g merged commit 25f0f70 into flutter:main Feb 22, 2023
@stuartmorgan-g stuartmorgan-g deleted the source-link-updates branch February 22, 2023 18:45
ditman added a commit to ditman/flutter-flutter that referenced this pull request Feb 24, 2023
@ditman
Roll Packages from 6c04c74 to ad48ee5 (28 revisions)
e3abb78 
* ad48ee5 [go_router] Fix some broken links in doc (flutter/packages#3288)
* 58ac45e [go_router_builder] Add support for Iterable, List  and Set to TypedGoRoute (flutter/packages#2679)
* 0edae25 Export super types in route_data.dart library (flutter/packages#3286)
* 8ad3fde [go_router] Add `GoRouter.maybeOf` (flutter/packages#3216)
* 13ee644 [flutter_migrate] Skip slow tests (flutter/packages#3270)
* 3cc754a Update .gitignore with missing values from flutter/plugins (flutter/packages#3265)
* c0f0a22 [ci] Re-enable pathified unit tests (flutter/packages#3268)
* 5834b4c [go_router]: implemented helpers for ShellRoute (flutter/packages#2730)
* af5906b [extension_gsi] Update extension to support gsi 5 and 6. (flutter/packages#3235)
* 195f4e8 Merge in plugin README and CONTRIBUTING (flutter/packages#3252)
* fab47af [go_router] Disable logging in tests (flutter/packages#3263)
* 25f0f70 [various] Update flutter/plugins links (flutter/packages#3256)
* 2e16733 Merge flutter/plugins (flutter/packages#3233)
* 324a7f2 Exclude more tests on Windows
* 334b58e Adjust test configs
* 69e6dac [go_router_builder] Generate replace method in RouteExtension (flutter/packages#2838)
* 193e454 Merge repository metadata
* 18715d7 Merge remote-tracking branch 'plugins-packages/main' into merge-flutter-plugins
* f2d802d Roll Flutter from ae8d051 to 7175de4 (4 revisions) (flutter/packages#3232)
* 6f1b1e8 Roll Flutter from 33e4d21 to ae8d051 (6 revisions) (flutter/packages#3229)
* a162a98 Roll Flutter from 0be7c3f to 33e4d21 (5 revisions) (flutter/packages#3227)
* ab5a8c0 [tool] Allow importing packages with NEXT (flutter/packages#3215)
* ce9c61b Roll Flutter from 170539f to 0be7c3f (38 revisions) (flutter/packages#3225)
* 9747469 Fix deprecation message for GoRouterState.namedLocation (flutter/packages#3092)
* 6e4431f [go_router] Bump example `compileSdkVersion` and `package_info_plus` dependency version (flutter/packages#3219)
* 925bea8 [pigeon] Validate generated files in CI (flutter/packages#3224)
* 3094867 Move iOS Swift unit tests back to Cirrus (flutter/packages#3221)
* 763d025 [pigeon] Eliminate some of the test pigeons (flutter/packages#3213)
@ditman ditman mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

@ditman ditman ditman approved these changes

@bparrishMines bparrishMines bparrishMines approved these changes

@hellohuanlin hellohuanlin hellohuanlin approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@jmagman jmagman Awaiting requested review from jmagman

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu LouiseHsu is a code owner

@vashworth vashworth Awaiting requested review from vashworth vashworth is a code owner

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

@reidbaker reidbaker Awaiting requested review from reidbaker reidbaker is a code owner

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

Assignees

No one assigned

Labels

p: camera p: espresso p: extension_google_sign_in_as_googleapis_auth p: file_selector p: flutter_plugin_android_lifecycle p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: ios_platform_images p: local_auth p: path_provider p: pigeon p: plugin_platform_interface p: quick_actions p: shared_preferences p: url_launcher p: video_player p: webview_flutter platform-android platform-ios platform-linux platform-macos platform-web platform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stuartmorgan-g @ditman @cbracken @bparrishMines @hellohuanlin