Skip to content

[flutter_adaptive_scaffold] Fix leading Navigation Rail Widgets#3080

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
rlshumat:main
Jan 24, 2023
Merged

[flutter_adaptive_scaffold] Fix leading Navigation Rail Widgets#3080
auto-submit[bot] merged 1 commit intoflutter:mainfrom
rlshumat:main

Conversation

@rlshumat
Copy link
Contributor

@rlshumat rlshumat commented Jan 23, 2023 •
edited
Loading

The leading Navigation Rail widgets were not being passed through to the Navigation Rail. This PR passes through the leading widget and adds a test to verify that the leading widget is displayed correctly based on the screen size.

Fixes flutter/flutter#114684

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@google-cla
Copy link

google-cla bot commented Jan 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rlshumat
Copy link
Contributor Author

rlshumat commented Jan 23, 2023

The linux-build_all_packages failed due to:

fatal: unable to access 'https://github.com/flutter/flutter.git/': Failed to connect to github.com port 443 after 129622 ms: Connection timed out

Is there a way to re-run this check?

gspencergoog
gspencergoog reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This change looks good, but we'll need you to accept the CLA before we can accept it.

@rlshumat
[flutter_adaptive_scaffold] Fix leading and trailing Navigation Rail …
12d189e 
…Widgets

The leading and trailing Navigation Rail widgets were not being passed
through to the Navigation Rail.

Fixes flutter/flutter#114684
@rlshumat
Copy link
Contributor Author

rlshumat commented Jan 24, 2023

CLA accepted! I also updated the patch to include a fix for the trailing widget which should resolve all of flutter/flutter#114684.

gspencergoog
gspencergoog approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

yaakovschectman
yaakovschectman approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@yaakovschectman yaakovschectman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2023
@auto-submit auto-submit bot merged commit dbd24ef into flutter:main Jan 24, 2023
sybrands-place pushed a commit to sybrands-place/packages that referenced this pull request Jan 30, 2023
Merge branch 'main' into null_status_retriable
577bbb1 
* main: (479 commits)
  removes raw ArrayLists (flutter#3101)
  Roll Flutter from c9affdb to 27f8ebd (15 revisions) (flutter#3098)
  [ci] Fix the new LUCI iOS build-all tasks (flutter#3099)
  [pigeon] [ObjC] Removes unused GetNullableObject function (flutter#3100)
  [pigeon] Swift host error handling (flutter#3084)
  Roll Flutter from a815ee6 to c9affdb (23 revisions) (flutter#3093)
  [ci] Enable min SDK version checks (flutter#3095)
  [pigeon] Fix C++ config handling (flutter#3094)
  [ci] Add LUCI version of iOS build-all (flutter#3096)
  [pigeon] Adds SwiftFunction annotation (flutter#2304)
  [flutter_adaptive_scaffold] Change `selectedIndex` on `standardNavigationRail` to allow null value. (flutter#3088)
  [pigeon] requires analyzer 5.2.0 (flutter#3090)
  Roll Flutter from c35efda to a815ee6 (22 revisions) (flutter#3089)
  [ci] Update legacy Flutter version tests (flutter#3087)
  Roll Flutter (stable) from 135454a to b06b8b2 (2551 revisions) (flutter#3086)
  [flutter_adaptive_scaffold] Fix leading and trailing Navigation Rail Widgets (flutter#3080)
  Roll Flutter from bd7bee0 to c35efda (24 revisions) (flutter#3085)
  [pigeon] Minor C++ output adjustments (flutter#3083)
  [pigeon] Updates writeScoped and addScoped to disallow symbol-less use. (flutter#3081)
  Roll Flutter from f33e8d3 to bd7bee0 (5 revisions) (flutter#3082)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

+1 more reviewer

@yaakovschectman yaakovschectman yaakovschectman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: flutter_adaptive_scaffold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[flutter_adaptive_scaffold] Leading and Trailing widgets are not visible on NavigationRail

3 participants

@rlshumat @gspencergoog @yaakovschectman