[pigeon] Fix enum parameters in Dart test#2749
[pigeon] Fix enum parameters in Dart test#2749auto-submit[bot] merged 3 commits intoflutter:mainfrom
Conversation
Fixes the handling of enum parameters in the Dart test class generation for testing host APIs. Fixes flutter/flutter#105742
|
This generated the same code that I wrote manually as a workaround in flutter/plugins#6635. |
|
Seems to be failing the dart analyze tool. I'm not sure why, as you didn't change anything that would result in those failures. |
852d908 to
dd419d8
Compare
|
That failure will be fixed by #2751 (see link there for an explanation of the issue). |
|
auto label is removed for flutter/packages, pr: 2749, due to - This commit is not mergeable and has conflicts. Please rebase your PR and fix all the conflicts. |
|
auto label is removed for flutter/packages, pr: 2749, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Ugh, the workaround we did isn't enough for Pigeon's unusual package structure (dart-lang/pub#3618 (comment)). I think we'll need to flip |
|
I forgot that |
Fixes the handling of enum parameters in the Dart test class generation for testing host APIs.
Fixes flutter/flutter#105742
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.