feat(ios): add audio track selection support for AVFoundation by nateshmbhat · Pull Request #10313 · flutter/packages

nateshmbhat · 2025-10-28T15:06:34Z

Implemented getAudioTracks() method to retrieve available audio tracks from both HLS streams and regular video files

AVFoundation Platform PR for : #9925

Pre-Review Checklist

gemini-code-assist

Code Review

This pull request introduces audio track selection support for AVFoundation, enabling users to retrieve and select audio tracks from both HLS streams and regular video files. The changes include modifications to the CHANGELOG, platform-specific code (ObjC, Swift), example app, and test files. The minimum supported SDK versions have been updated, and new methods (getAudioTracks(), selectAudioTrack()) have been implemented. The code adheres to the repository's style guide, focusing on objective summaries and using code as the source of truth.

packages/video_player/video_player_avfoundation/CHANGELOG.md

packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation.podspec

packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation/Package.swift

gemini-code-assist · 2025-10-28T15:12:30Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+      // Skip nil options
+      if (!option || [option isKindOfClass:[NSNull class]]) {
+        continue;


Consider adding a comment explaining why nil options are skipped. This will help future developers understand the logic behind this check.

+1, why are we checking against NSNull or checking if the option is nil?

gemini-code-assist · 2025-10-28T15:12:30Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+  }
+  // For asset tracks, we don't have a direct way to select them in AVFoundation
+  // This would require more complex track selection logic that's not commonly used


Add a comment explaining why direct selection isn't possible and what the limitations are. This will help future developers understand the current implementation and potential areas for improvement.

packages/video_player/video_player_avfoundation/example/ios/Flutter/AppFrameworkInfo.plist

packages/video_player/video_player_avfoundation/example/ios/Runner.xcodeproj/project.pbxproj

packages/video_player/video_player_avfoundation/example/macos/Podfile

packages/video_player/video_player_avfoundation/example/macos/Runner.xcodeproj/project.pbxproj

gemini-code-assist · 2025-10-28T15:12:31Z

packages/video_player/video_player_avfoundation/example/pubspec.yaml

  assets:
    - assets/flutter-mark-square-64.png
    - assets/Butterfly-209.mp4
+# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.


Per the repository style guide, the review agent should not comment about dependency_overrides sections in pubspec.yaml files that have a comment starting with: "FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE." ¹

Style Guide References

Footnotes

The review agent should not comment about dependency_overrides sections in pubspec.yaml files that have a comment starting with: "FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE." (link) ↩

- Added getAudioTracks() method supporting both HLS media selection and regular asset tracks - Added selectAudioTrack() method with support for both track selection mechanisms - Included comprehensive test coverage for audio track functionality with edge cases

- Update iOS minimum deployment target from 12.0 to 13.0 - Update macOS minimum deployment target from 10.14 to 10.15 - Add CocoaPods framework embedding build phases to Xcode projects

nateshmbhat · 2025-11-07T17:18:01Z

@LongCatIsLooong @tarrinneal could you please review this PR

tarrinneal · 2025-11-24T19:29:11Z

🥲

Sorry, I've been out as my wife is recovering from surgery. I'll try to get to this in the next couple days.

LongCatIsLooong · 2025-11-25T00:23:10Z

(just started reviewing this, I'll finish doing the review tomorrow, sorry for the delay I was working on a bugfix).

LongCatIsLooong

So far I've only looked at the objective-c implementation.
My biggest question: why is it required to drop down to lower-level AVAssetTrack stuff? I went to read a little about media selection group and my understanding is that it should be sufficient for most user-facing use cases. What are the use cases for the tracks information?

Additionally, track loading is lazy and asynchronous according to the documentation. I don't see logic that handles the asynchronism.

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

LongCatIsLooong · 2025-11-25T19:18:44Z

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

+      // Skip nil options
+      if (!option || [option isKindOfClass:[NSNull class]]) {
+        continue;


+1, why are we checking against NSNull or checking if the option is nil?

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

…layer_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>

- Remove _cachedAudioSelectionOptions instance variable - Fetch options from media selection group each time in selectAudioTrack - Address PR review feedback from LongCatIsLooong

- Remove unnecessary nil checks for AVMediaSelectionOption - Remove redundant equality check in isSelected comparison - Simplify commonMetadataTitle extraction - Remove try-catch block and type validation for format description parsing - Remove defensive checks for Core Media format descriptions - Streamline audio format description extraction logic

…ayer - Return FlutterError instead of empty data when video not loaded in getAudioTracks - Return FlutterError instead of silently failing in selectAudioTrack when no video loaded - Remove test for nil media selection option handling (no longer needed) - Add getAudioTracks and selectAudioTrack helper methods to _PlayerInstance - Apply dart format to fix code style inconsistencies

…/flutter_packages into 28-oct-platform-avfoundation

…ction tracks

…/flutter_packages into 28-oct-platform-avfoundation

nateshmbhat · 2026-01-06T17:10:50Z

Thanks for the review! I've removed all the AVAssetTrack related code based on your comments. This also simplifies the API to only expose tracks that are actually selectable (HLS MediaSelection tracks)

LongCatIsLooong

The implementation LGTM, but it seems the tests are not compiling.

LongCatIsLooong · 2026-01-07T23:01:22Z

packages/video_player/video_player_avfoundation/lib/src/avfoundation_video_player.dart

+    final tracks = <VideoAudioTrack>[];
+
+    for (final track in nativeData) {
+      final String? label = track.commonMetadataTitle ?? track.displayName;


Shouldn't displayName be preferred over metadata title, because the display name is potentially localized?

Also should the fallback happen in the objective c part of this implementation so that we don't have to encode / decode both common metadata title and display name in case both are present?

Our general direction in the repo is to have logic in Dart when there's not a strong reason to have it on the native side; encoding a couple of short short strings isn't something we would expect to have non-trivial perf impact.

nateshmbhat · 2026-01-09T15:31:13Z

The implementation LGTM, but it seems the tests are not compiling.

fixed the tests @LongCatIsLooong

LouiseHsu · 2026-01-09T22:40:05Z

Can you resolve the conflicts and merge master?

LongCatIsLooong

The CI is failing because the changes in the video_player package doesn't have associated CHANGELOG entries:

Changed packages: video_player/video_player,video_player_avfoundation
[0:00] Running for packages/video_player/video_player...
  No version change.
  Found NEXT; validating next version in the CHANGELOG.
No CHANGELOG change found.
If this PR needs an exemption from the standard policy of listing all changes in the CHANGELOG,
comment in the PR to explain why the PR is exempt, and add (or ask your reviewer to add) the
"override: no changelog needed" label.
Otherwise, please add a NEXT entry in the CHANGELOG as described in the contributing guide.

[0:00] Running for packages/video_player/video_player_avfoundation...
  2.8.9 -> 2.9.0


The following packages had errors:
  packages/video_player/video_player:
    Missing CHANGELOG change

nateshmbhat · 2026-01-12T09:24:11Z

The CI is failing because the changes in the video_player package doesn't have associated CHANGELOG entries:

This is the main package changelog which I will update in the main PR once we merge this ios specific PR.

tarrinneal · 2026-01-12T22:45:18Z

The CI is failing because the changes in the video_player package doesn't have associated CHANGELOG entries:

This is the main package changelog which I will update in the main PR once we merge this ios specific PR.

You will need to either remove the video_player/video_player changes (if that works), or add a next section to the changelog for them.

nateshmbhat · 2026-01-19T11:57:50Z

@tarrinneal updated the PR with a fix

…updates

…on (flutter/packages#10313)

flutter/packages@d80c60e...9010299 2026-01-21 jhy03261997@gmail.com [batch-release] Step2 : Publish packages from the release branch (flutter/packages#10459) 2026-01-21 dpxhfxywang@163.com [two_dimensional_scrollables] optimizes tableview janks with >250k rows (flutter/packages#10738) 2026-01-21 magder@google.com [url_launcher_ios] Migrate XCTest to Swift Testing (flutter/packages#10780) 2026-01-21 edpizzi@gmail.com [in_app_purchase] Fix an issue causing StoreKit 2 transactions remain unfinished (flutter/packages#10656) 2026-01-21 stuartmorgan@google.com [google_maps_flutter] Restructure iOS to prep for SwiftPM (flutter/packages#10839) 2026-01-21 jhy03261997@gmail.com [batch-release] Step3: Adds github action to create a PR to sync changes on the go_router release branch back to the main branch (flutter/packages#10393) 2026-01-21 nateshmbhat1@gmail.com feat(ios): add audio track selection support for AVFoundation (flutter/packages#10313) 2026-01-21 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in /packages/image_picker/image_picker_android/android (flutter/packages#10504) 2026-01-21 38853913+AlexDochioiu@users.noreply.github.com [vector_graphics_compiler] Fix rgb/rgba color parsing to support modern CSS syntax (flutter/packages#10538) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#181323) flutter/packages@d80c60e...9010299 2026-01-21 jhy03261997@gmail.com [batch-release] Step2 : Publish packages from the release branch (flutter/packages#10459) 2026-01-21 dpxhfxywang@163.com [two_dimensional_scrollables] optimizes tableview janks with >250k rows (flutter/packages#10738) 2026-01-21 magder@google.com [url_launcher_ios] Migrate XCTest to Swift Testing (flutter/packages#10780) 2026-01-21 edpizzi@gmail.com [in_app_purchase] Fix an issue causing StoreKit 2 transactions remain unfinished (flutter/packages#10656) 2026-01-21 stuartmorgan@google.com [google_maps_flutter] Restructure iOS to prep for SwiftPM (flutter/packages#10839) 2026-01-21 jhy03261997@gmail.com [batch-release] Step3: Adds github action to create a PR to sync changes on the go_router release branch back to the main branch (flutter/packages#10393) 2026-01-21 nateshmbhat1@gmail.com feat(ios): add audio track selection support for AVFoundation (flutter/packages#10313) 2026-01-21 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in /packages/image_picker/image_picker_android/android (flutter/packages#10504) 2026-01-21 38853913+AlexDochioiu@users.noreply.github.com [vector_graphics_compiler] Fix rgb/rgba color parsing to support modern CSS syntax (flutter/packages#10538) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ection feature (#9925) ## Description This PR adds comprehensive audio track retrieval and selection support to the video_player package, enabling developers to access detailed information about available audio tracks and switch between them during playback. Breakout PRs: 1. Platform interface : #10171 2. Andrioid : #10312 3. ios : #10313 ### Changes Made #### Core Features - **Added `VideoAudioTrack` model** with comprehensive metadata fields: `id`, `label`, `language`, `isSelected`, `bitrate`, `sampleRate`, `channelCount`, `codec` - **Added [getAudioTracks()]() method** to retrieve all available audio tracks with real metadata - **Added [selectAudioTrack()]() method** to switch between audio tracks during playback - **Updated `VideoPlayerController`** to expose audio track functionality #### Platform Implementations - **Android**: - Real metadata extraction using ExoPlayer's `getCurrentTracks()` API - Robust track selection using `TrackSelectionOverride` with proper error handling - Support for multiple audio formats (AAC, AC3, EAC3, MP3, etc.) - **iOS**: - Metadata extraction from AVFoundation using `AVAssetTrack` for regular videos - HLS stream support using `AVMediaSelectionGroup` for adaptive streams - Proper track selection for both asset tracks and media selection options #### Technical Infrastructure - **Updated Pigeon interfaces** for both Android and iOS with new data structures: - `AudioTrackMessage`, `ExoPlayerAudioTrackData`, `AssetAudioTrackData`, `MediaSelectionAudioTrackData`, `NativeAudioTrackData` - **Enhanced platform interface** with new methods and data classes - **Has native unit tests** for both Android and iOS platforms - **Created demo screen** showcasing audio track functionality with interactive UI ### Demo Features - Interactive video player with audio track selection - Real-time metadata display (bitrate, sample rate, channels, codec) - Support for multiple video sources including HLS streams - Visual indicators for currently selected tracks ## Related Issues Fixes flutter/flutter#59437 ### Testing - Added native unit tests for both Android and iOS - Tested with various video formats and HLS streams - Verified backward compatibility with existing functionality - Demo screen widget for manual testing and validation ### Breaking Changes None - all changes are additive and backward compatible. ## Pre-Review Checklist

nateshmbhat requested review from LongCatIsLooong and hellohuanlin as code owners October 28, 2025 15:06

github-actions bot added platform-ios platform-macos p: video_player labels Oct 28, 2025

nateshmbhat mentioned this pull request Oct 28, 2025

[video_player] Adds audio track metadata fetching and audio track selection feature #9925

Merged

11 tasks

gemini-code-assist bot reviewed Oct 28, 2025

View reviewed changes

stuartmorgan-g added the triage-ios Should be looked at in iOS triage label Oct 28, 2025

nateshmbhat force-pushed the 28-oct-platform-avfoundation branch from 4784bd8 to 459e7f8 Compare November 7, 2025 16:32

nateshmbhat changed the title ~~feat(video): add audio track selection support for AVFoundation~~ feat(ios): add audio track selection support for AVFoundation Nov 7, 2025

chore(video_player): bump minimum OS versions for iOS and macOS

272ff1d

- Update iOS minimum deployment target from 12.0 to 13.0 - Update macOS minimum deployment target from 10.14 to 10.15 - Add CocoaPods framework embedding build phases to Xcode projects

nateshmbhat requested a review from tarrinneal as a code owner November 7, 2025 17:15

Merge branch 'main' into 28-oct-platform-avfoundation

6905f0a

This comment was marked as off-topic.

Sign in to view

nateshmbhat added 2 commits November 19, 2025 20:27

Merge branch 'main' into 28-oct-platform-avfoundation

b253fa4

Merge branch 'main' into 28-oct-platform-avfoundation

1bfefef

This comment was marked as off-topic.

Sign in to view

LongCatIsLooong reviewed Nov 25, 2025

View reviewed changes

nateshmbhat and others added 7 commits November 26, 2025 21:23

Update packages/video_player/video_player_avfoundation/darwin/video_p…

32ab95d

…layer_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>

Merge branch 'main' into 28-oct-platform-avfoundation

9f13dc2

refactor(ios): remove audio selection options caching

dcb886d

- Remove _cachedAudioSelectionOptions instance variable - Fetch options from media selection group each time in selectAudioTrack - Address PR review feedback from LongCatIsLooong

Merge branch 'main' into 28-oct-platform-avfoundation

3c8b5d4

Merge branch '28-oct-platform-avfoundation' of github.com:nateshmbhat…

aee5360

…/flutter_packages into 28-oct-platform-avfoundation

nateshmbhat added 3 commits January 6, 2026 22:29

Merge branch 'main' into 28-oct-platform-avfoundation

b129b5e

feat: Simplify audio track selection by unifying asset and media sele…

b15346e

…ction tracks

Merge branch '28-oct-platform-avfoundation' of github.com:nateshmbhat…

b577344

…/flutter_packages into 28-oct-platform-avfoundation

nateshmbhat requested a review from LongCatIsLooong January 6, 2026 17:11

removed unnecessary files

02fe575

LongCatIsLooong reviewed Jan 7, 2026

View reviewed changes

fix(tests) : fix test compile errors

8d38697

Merge branch 'main' into 28-oct-platform-avfoundation

0457a98

nateshmbhat requested a review from LongCatIsLooong January 10, 2026 09:49

Merge branch 'main' into 28-oct-platform-avfoundation

6a64bd8

LongCatIsLooong approved these changes Jan 12, 2026

View reviewed changes

Merge branch 'main' into 28-oct-platform-avfoundation

175495c

hellohuanlin removed the triage-ios Should be looked at in iOS triage label Jan 15, 2026

nateshmbhat added 3 commits January 19, 2026 20:11

fix: updated changelog

938f86b

Merge branch 'main' into 28-oct-platform-avfoundation

48c8fb8

docs: add video track selection implementation plan and initial test …

2c84abe

…updates

LouiseHsu approved these changes Jan 21, 2026

View reviewed changes

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 21, 2026

auto-submit bot merged commit 93c9395 into flutter:main Jan 21, 2026
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2026

93c93956e feat(ios): add audio track selection support for AVFoundati…

67686c8

…on (flutter/packages#10313)

engine-flutter-autoroll mentioned this pull request Jan 22, 2026

Roll Packages from d80c60eef034 to 90102991452d (9 revisions) flutter/flutter#181323

Merged

Conversation

nateshmbhat commented Oct 28, 2025

Pre-Review Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

Style Guide References

Footnotes

Uh oh!

nateshmbhat commented Nov 7, 2025

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

tarrinneal commented Nov 24, 2025

Uh oh!

LongCatIsLooong commented Nov 25, 2025

Uh oh!

LongCatIsLooong left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

LongCatIsLooong Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nateshmbhat commented Jan 6, 2026

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

nateshmbhat commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LouiseHsu commented Jan 9, 2026

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

nateshmbhat commented Jan 12, 2026

Uh oh!

tarrinneal commented Jan 12, 2026

Uh oh!

LongCatIsLooong left a comment •

edited

Loading

nateshmbhat commented Jan 9, 2026 •

edited

Loading

nateshmbhat commented Jan 19, 2026 •

edited

Loading