Revert "Add libblkid / liblzma / libgcrypt as an explicit dependancy on Linux"#78415
Merged
jonahwilliams merged 2 commits intoflutter:masterfrom Mar 18, 2021
MarcusTomlinson:master
Merged
Revert "Add libblkid / liblzma / libgcrypt as an explicit dependancy on Linux"#78415jonahwilliams merged 2 commits intoflutter:masterfrom MarcusTomlinson:master
jonahwilliams merged 2 commits intoflutter:masterfrom
MarcusTomlinson:master
Conversation
This reverts commit bf65b3d.
10 tasks
Contributor
Author
|
@jonahwilliams, know why “Google testing” is failing on this PR? |
Contributor
|
Failure looks unrelated, I'll merge |
8 tasks
This was referenced Jul 26, 2021
stuartmorgan-g
added a commit
to google/flutter-desktop-embedding
that referenced
this pull request
Jul 26, 2021
Updates to match flutter/flutter#78415 Avoids having a dependency that doctor no longer flags as necessary. Fixes #867
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following on from this conversation:
Please accept my sincerest apologies for this! The last few updates to
linux.tmpl/flutter/CMakeLists.txtare actually only required for the snap package and thus should not have been made upstream. This PR reverts those changes.See also: flutter/website#5504
Related Issues
Resolves: canonical/flutter-snap#32
Resolves: canonical/flutter-snap#36
Resolves: #77786
Resolves: #77293
Tests
I've updated the relative flutter-doctor tests.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.