Skip to content

Comments

Remove Material dependency from transformed_scrollable_test.dart#182141

Merged
justinmc merged 3 commits intoflutter:masterfrom
gbolahan507:fix-transformed-scrollable-test-cross-import
Feb 13, 2026
Merged

Remove Material dependency from transformed_scrollable_test.dart#182141
justinmc merged 3 commits intoflutter:masterfrom
gbolahan507:fix-transformed-scrollable-test-cross-import

Conversation

@gbolahan507
Copy link
Contributor

Replace MaterialApp with TestWidgetsApp and Colors.blue/Colors.red with named constants to remove the Material library dependency.

Part of #177414

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Feb 10, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Material library dependency from transformed_scrollable_test.dart by replacing MaterialApp with TestWidgetsApp and defining local constants for colors previously imported from the Material library. The change is correct, and I have one suggestion to add documentation to the new color constants to improve code clarity, in line with the repository's style guide.

@gbolahan507 gbolahan507 force-pushed the fix-transformed-scrollable-test-cross-import branch from 740f05b to b1b6f12 Compare February 10, 2026 11:55
import 'widgets_app_tester.dart';

/// The blue color used in this test, equivalent to `Colors.blue`.
const Color _kBlue = Color(0xFF2196F3);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests don't actually require a specific color it seems? Can you use single channel colors, to make the test easier to read? Then the comments can also be omitted, since these no longer apply.

const Color _kBlue = Color(0xFF0000FF);
const Color _kRed = Color(0xFFFFF0000);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updated to use simple single channel colors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navaronbracke Friendly ping for review

Replace MaterialApp with TestWidgetsApp and Colors.blue/red with
simple single channel color constants.

Part of flutter#177414
@gbolahan507 gbolahan507 force-pushed the fix-transformed-scrollable-test-cross-import branch from b1b6f12 to 2cbcf8e Compare February 10, 2026 13:24
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for helping out here!

@justinmc justinmc added this pull request to the merge queue Feb 13, 2026
Merged via the queue into flutter:master with commit 8d238ab Feb 13, 2026
148 checks passed
@gbolahan507 gbolahan507 deleted the fix-transformed-scrollable-test-cross-import branch February 13, 2026 23:26
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 17, 2026
Roll Flutter from 9bda20a11f1e to 6e4a481bdf27 (103 revisions)

flutter/flutter@9bda20a...6e4a481

2026-02-17 okorohelijah@google.com Fix iOS CI tests for Xcode 26 Swift compatibility (flutter/flutter#182132)
2026-02-17 43054281+camsim99@users.noreply.github.com Revert "[Android] Add mechanism for setting Android engine flags via … (flutter/flutter#182388)
2026-02-17 engine-flutter-autoroll@skia.org Roll Skia from 4ed9faf843e6 to dfe78d132e24 (1 revision) (flutter/flutter#182485)
2026-02-17 engine-flutter-autoroll@skia.org Roll Skia from ff0af46bf172 to 4ed9faf843e6 (2 revisions) (flutter/flutter#182483)
2026-02-17 engine-flutter-autoroll@skia.org Roll Skia from 24c7b6f5760f to ff0af46bf172 (1 revision) (flutter/flutter#182481)
2026-02-16 engine-flutter-autoroll@skia.org Roll Dart SDK from ff57548fcf54 to 44895e617182 (1 revision) (flutter/flutter#182479)
2026-02-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YND8TyaxKkkkEvlD9... to mcN42vw48OPH3JDNm... (flutter/flutter#182478)
2026-02-16 engine-flutter-autoroll@skia.org Roll Dart SDK from c819ebe0cbe3 to ff57548fcf54 (1 revision) (flutter/flutter#182472)
2026-02-16 34465683+rkishan516@users.noreply.github.com feat: add routes support in TestWidgetsApp (flutter/flutter#181695)
2026-02-16 engine-flutter-autoroll@skia.org Roll Skia from 5c8a6641902f to 24c7b6f5760f (1 revision) (flutter/flutter#182467)
2026-02-16 engine-flutter-autoroll@skia.org Roll Skia from 94d5d5e5f785 to 5c8a6641902f (6 revisions) (flutter/flutter#182463)
2026-02-16 engine-flutter-autoroll@skia.org Roll Dart SDK from f2289e13a20a to c819ebe0cbe3 (1 revision) (flutter/flutter#182462)
2026-02-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 294e6e248512 to f2289e13a20a (1 revision) (flutter/flutter#182448)
2026-02-15 engine-flutter-autoroll@skia.org Roll Skia from b7cea4cbe546 to 94d5d5e5f785 (1 revision) (flutter/flutter#182446)
2026-02-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pkyhAZ3sQZDzeNZym... to YND8TyaxKkkkEvlD9... (flutter/flutter#182445)
2026-02-15 engine-flutter-autoroll@skia.org Roll Skia from a3a82d359a7b to b7cea4cbe546 (1 revision) (flutter/flutter#182439)
2026-02-15 engine-flutter-autoroll@skia.org Roll Skia from a147ae2d4adc to a3a82d359a7b (1 revision) (flutter/flutter#182435)
2026-02-15 engine-flutter-autoroll@skia.org Roll Dart SDK from f82ec89435f5 to 294e6e248512 (1 revision) (flutter/flutter#182432)
2026-02-14 engine-flutter-autoroll@skia.org Roll Skia from 91d158b0a61e to a147ae2d4adc (2 revisions) (flutter/flutter#182424)
2026-02-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from V30FBkJySjFKXwVjW... to pkyhAZ3sQZDzeNZym... (flutter/flutter#182423)
2026-02-14 engine-flutter-autoroll@skia.org Roll Skia from e5a18f8f0d4a to 91d158b0a61e (1 revision) (flutter/flutter#182422)
2026-02-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 7a2a28dbd0d4 to f82ec89435f5 (2 revisions) (flutter/flutter#182414)
2026-02-14 engine-flutter-autoroll@skia.org Roll Skia from befeec673f1b to e5a18f8f0d4a (1 revision) (flutter/flutter#182412)
2026-02-14 engine-flutter-autoroll@skia.org Roll Skia from 7dc3ba9b1d90 to befeec673f1b (1 revision) (flutter/flutter#182408)
2026-02-14 koji.wakamiya@gmail.com [Web] Fix IME and selection by syncing more text styles (flutter/flutter#180436)
2026-02-14 engine-flutter-autoroll@skia.org Roll Skia from bb69b5b71b4f to 7dc3ba9b1d90 (2 revisions) (flutter/flutter#182401)
2026-02-14 30870216+gaaclarke@users.noreply.github.com Disable multithread opengles, enables remaining fragment shader tests (flutter/flutter#182384)
2026-02-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Standardize on Test* widgets in *_tester.dart files (#182395)" (flutter/flutter#182406)
2026-02-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix cross imports for all Cupertino tests (#181634)" (flutter/flutter#182404)
2026-02-13 victorsanniay@gmail.com Add await to tester.pump callsites (flutter/flutter#182398)
2026-02-13 jwren@google.com refactor: Centralize table formatting logic into a new `formatTable` utility function. (flutter/flutter#182196)
2026-02-13 30870216+gaaclarke@users.noreply.github.com Adds impeller backend to golden workspace name (flutter/flutter#182387)
2026-02-13 jmccandless@google.com Standardize on Test* widgets in *_tester.dart files (flutter/flutter#182395)
2026-02-13 ahabeeblahi1@gmail.com Remove Material dependency from transformed_scrollable_test.dart (flutter/flutter#182141)
2026-02-13 brackenavaron@gmail.com Fix cross imports for all Cupertino tests (flutter/flutter#181634)
2026-02-13 ilyosbek.ibrokhimov@talabat.com remove MaterialApp import from raw_radio_test.dart (flutter/flutter#181721)
2026-02-13 engine-flutter-autoroll@skia.org Roll Skia from e2991aa99710 to bb69b5b71b4f (37 revisions) (flutter/flutter#182390)
2026-02-13 30870216+gaaclarke@users.noreply.github.com Turns on most of fragment_shader_test.dart for opengles (flutter/flutter#182229)
2026-02-13 43054281+camsim99@users.noreply.github.com Update `CHANGELOG` for 3.41.1 release (flutter/flutter#182393)
2026-02-13 ahabeeblahi1@gmail.com Remove Material dependency from semantics_keep_alive_offstage_test.dart (flutter/flutter#182211)
2026-02-13 15619084+vashworth@users.noreply.github.com Update iOS/macOS plugin template to add dependency on FlutterFramework (flutter/flutter#181416)
2026-02-13 15619084+vashworth@users.noreply.github.com Add plugin dependencies to Add to App FlutterPluginRegistrant (flutter/flutter#182304)
2026-02-13 chingjun@google.com Preparation to add contentTextStyle flag to SimpleDialog. (flutter/flutter#182200)
2026-02-13 engine-flutter-autoroll@skia.org Roll Packages from af1d610 to 09104b0 (4 revisions) (flutter/flutter#182383)
2026-02-13 engine-flutter-autoroll@skia.org Roll Dart SDK from de5915148fde to 7a2a28dbd0d4 (2 revisions) (flutter/flutter#182380)
2026-02-13 jason-simmons@users.noreply.github.com [Impeller] Dispose thread local caches on each frame when using GPUSurfaceVulkanImpeller with a delegate (flutter/flutter#182265)
...
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
…tter#182141)

Replace `MaterialApp` with `TestWidgetsApp` and
`Colors.blue`/`Colors.red` with named constants to remove the Material
library dependency.
Part of flutter#177414
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
  - [x] All existing and new tests are passing. 

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants