Skip to content

Marks Windows tool_tests_commands_1_2 to be unflaky#179670

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
fluttergithubbot:RQnAiHctOl
Feb 24, 2026
Merged

Marks Windows tool_tests_commands_1_2 to be unflaky#179670
auto-submit[bot] merged 1 commit intoflutter:masterfrom
fluttergithubbot:RQnAiHctOl

Conversation

@fluttergithubbot
Copy link
Contributor

The test has been passing for 50 consecutive runs.
This test can be marked as unflaky.

@flutter-dashboard flutter-dashboard bot added c: flake Tests that sometimes, but not always, incorrectly pass c: tech-debt Technical debt, code quality, testing, etc. labels Dec 10, 2025
@github-actions github-actions bot removed the c: tech-debt Technical debt, code quality, testing, etc. label Dec 10, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request marks the Windows tool_tests_commands_1_2 test as unflaky by removing the bringup: true property from its configuration in .ci.yaml. This change aligns with the repository's CI best practices for tests that have demonstrated consistent stability, as indicated by the 50 consecutive passing runs. The modification is straightforward and correctly reflects the test's readiness for full CI integration.

@Piinks
Copy link
Contributor

Piinks commented Feb 23, 2026

Looks like it's still unflaky, will land.

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 23, 2026
@auto-submit auto-submit bot added this pull request to the merge queue Feb 24, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 24, 2026
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows tool_tests_commands_1_2"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20tool_tests_commands_1_2%22).
This test can be marked as unflaky.
Merged via the queue into flutter:master with commit c5643e2 Feb 24, 2026
155 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: flake Tests that sometimes, but not always, incorrectly pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants