Fix `Scaffold` having status bar when primary is false by PurplePolyhedron · Pull Request #175156 · flutter/flutter

PurplePolyhedron · 2025-09-10T06:36:15Z

When primary is false, Scaffold is not at the top of screen, so it should not have a status bar.
fixes #175062

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request correctly addresses the issue where a Scaffold with primary: false would incorrectly include a status bar gesture detector. The change is simple and effective, wrapping the status bar logic in a condition that checks widget.primary. The accompanying tests are well-written, covering both the intended behavior and preventing potential regressions. I have one minor suggestion to fix a typo in a test description.

packages/flutter/test/material/scaffold_test.dart

navaronbracke · 2025-09-10T09:48:33Z

packages/flutter/lib/src/material/scaffold.dart

-          removeRightPadding: false,
-          removeBottomPadding: true,
-        );
+        if (widget.primary) {


Drive-by nit: This can use an early return instead, to reduce the diff / indent?

if (!widget.primary) { break; } _addIfNonNull(...);

Good idea! Thanks for the suggestion

dkwingsmt

LGTM, thank you!

dkwingsmt · 2025-10-01T17:47:39Z

packages/flutter/lib/src/material/scaffold.dart

    switch (themeData.platform) {
      case TargetPlatform.iOS:
      case TargetPlatform.macOS:
+        if (!widget.primary) {


Can you also add a paragraph explaining this to the document of [primary]?

Piinks

LGTM with a couple of doc nits, thanks for the contribution!

Piinks · 2025-10-07T23:32:18Z

packages/flutter/lib/src/material/scaffold.dart

  /// If true then the height of the [appBar] will be extended by the height
  /// of the screen's status bar, i.e. the top padding for [MediaQuery].
  ///
+  /// If ture, on iOS and macOS, tapping the status bar scrolls the app's


Suggested change

/// If ture, on iOS and macOS, tapping the status bar scrolls the app's

/// If true, on iOS and macOS, tapping the status bar scrolls the app's

Piinks · 2025-10-07T23:35:46Z

packages/flutter/lib/src/material/scaffold.dart


-  // On iOS, tapping the status bar scrolls the app's primary scrollable to the
-  // top. We implement this by looking up the primary scroll controller and
+  // On iOS and macOS, tapping the status bar scrolls the app's primary scrollable


Suggested change

// On iOS and macOS, tapping the status bar scrolls the app's primary scrollable

// On iOS and macOS, if `primary` is true, tapping the status bar scrolls the app's primary scrollable

auto-submit · 2025-10-08T18:20:52Z

autosubmit label was removed for flutter/flutter/175156, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

Piinks

LGTM

…er/flutter#175156)

When primary is false, `Scaffold` is not at the top of screen, so it should not have a status bar. fixes flutter#175062 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…er/flutter#175156)

PurplePolyhedron added 2 commits September 10, 2025 16:26

fix status bar when primary is false

2cf3473

fix test

3e2aff4

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 10, 2025

gemini-code-assist bot reviewed Sep 10, 2025

View reviewed changes

packages/flutter/test/material/scaffold_test.dart Outdated Show resolved Hide resolved

fix typo

820349a

navaronbracke reviewed Sep 10, 2025

View reviewed changes

PurplePolyhedron and others added 3 commits September 10, 2025 21:44

Merge branch 'master' into scaffold_statusbar

243b73c

formating

5b0697e

fix typo

43e9ee0

dkwingsmt self-requested a review September 17, 2025 18:06

dkwingsmt approved these changes Oct 1, 2025

View reviewed changes

dkwingsmt reviewed Oct 1, 2025

View reviewed changes

dkwingsmt requested a review from Piinks October 1, 2025 18:30

PurplePolyhedron and others added 3 commits October 7, 2025 23:16

update document

19f7209

update document

531572b

Merge branch 'master' into scaffold_statusbar

581d363

Piinks reviewed Oct 7, 2025

View reviewed changes

fix typo

ee1f90e

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2025

Piinks approved these changes Oct 8, 2025

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2025

auto-submit bot added this pull request to the merge queue Oct 9, 2025

Merged via the queue into flutter:master with commit 07928d5 Oct 9, 2025
80 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2025

engine-flutter-autoroll mentioned this pull request Oct 9, 2025

Roll Flutter from e11e2c11288b to 76dbf9113d1e (23 revisions) flutter/packages#10196

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 9, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

eaae5f4

…er/flutter#175156)

engine-flutter-autoroll mentioned this pull request Oct 10, 2025

Roll Flutter from e11e2c11288b to 309bde139aab (46 revisions) flutter/packages#10202

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 10, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

9ea8599

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 10, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

d1bad36

…er/flutter#175156)

engine-flutter-autoroll mentioned this pull request Oct 10, 2025

Roll Flutter from e11e2c11288b to e7980672ba08 (47 revisions) flutter/packages#10204

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 10, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

35e1f3a

…er/flutter#175156)

engine-flutter-autoroll mentioned this pull request Oct 10, 2025

Roll Flutter from e11e2c11288b to 54ac6899b6ba (48 revisions) flutter/packages#10205

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 10, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

1109627

…er/flutter#175156)

engine-flutter-autoroll mentioned this pull request Oct 10, 2025

Roll Flutter from e11e2c11288b to fbfaf35e21d8 (49 revisions) flutter/packages#10207

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 10, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

eb29875

…er/flutter#175156)

engine-flutter-autoroll mentioned this pull request Oct 10, 2025

Roll Flutter from e11e2c11288b to 75caa52df10e (50 revisions) flutter/packages#10209

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 10, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

fac3996

…er/flutter#175156)

engine-flutter-autoroll mentioned this pull request Oct 10, 2025

Roll Flutter from e11e2c11288b to cce24b8a9d3e (51 revisions) flutter/packages#10210

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

17b7c7b

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

e5e5737

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

108cf70

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

4a1c84b

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

9b34a13

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

0403e7a

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

1095130

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

675e3b1

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

cac1246

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

e55326e

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

df487ba

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

0daab12

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

219c61e

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

943d823

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 15, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

dd382a1

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 15, 2025

07928d5 Fix Scaffold having status bar when primary is false (flutt…

d8a79f4

…er/flutter#175156)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

07928d5 Fix Scaffold having status bar when primary is false (flutt…

d8e0299

…er/flutter#175156)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `Scaffold` having status bar when primary is false#175156

Fix `Scaffold` having status bar when primary is false#175156
auto-submit[bot] merged 10 commits intoflutter:masterfrom
PurplePolyhedron:scaffold_statusbar

PurplePolyhedron commented Sep 10, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

navaronbracke Sep 10, 2025 •

edited

Loading

Uh oh!

PurplePolyhedron Sep 10, 2025

Uh oh!

dkwingsmt left a comment

Uh oh!

dkwingsmt Oct 1, 2025 •

edited

Loading

Uh oh!

Piinks left a comment

Uh oh!

Piinks Oct 7, 2025

Uh oh!

Piinks Oct 7, 2025

Uh oh!

auto-submit bot commented Oct 8, 2025

Uh oh!

Piinks left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	/// If ture, on iOS and macOS, tapping the status bar scrolls the app's
	/// If true, on iOS and macOS, tapping the status bar scrolls the app's

	// On iOS and macOS, tapping the status bar scrolls the app's primary scrollable
	// On iOS and macOS, if `primary` is true, tapping the status bar scrolls the app's primary scrollable

Conversation

PurplePolyhedron commented Sep 10, 2025

Pre-launch Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

navaronbracke Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PurplePolyhedron Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Piinks Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Oct 8, 2025

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

navaronbracke Sep 10, 2025 •

edited

Loading

dkwingsmt Oct 1, 2025 •

edited

Loading