Add SliverGrid.list convenience constructor by ahmeddhus · Pull Request #173925 · flutter/flutter

ahmeddhus · 2025-08-17T11:20:37Z

This PR adds a new SliverGrid.list convenience constructor that accepts a List<Widget> children parameter, providing a cleaner API compared to manually creating SliverChildListDelegate.

What was added

The constructor uses SliverChildListDelegate internally and follows the same pattern as existing convenience constructors like SliverGrid.count and SliverGrid.extent. This addresses the use case where developers want to create sliver grids with predefined widget lists without the verbosity of manually constructing the delegate.

Before/After comparison

Before:

SliverGrid(
  gridDelegate: gridDelegate,
  delegate: SliverChildListDelegate([widget1, widget2, widget3]),
)

After:

SliverGrid.list(
  gridDelegate: gridDelegate,
  children: [widget1, widget2, widget3],
)

Implementation details

Added SliverGrid.list constructor in packages/flutter/lib/src/widgets/sliver.dart
Constructor accepts List<Widget> children and all necessary delegate configuration parameters
Uses SliverChildListDelegate internally for consistent behavior
Added comprehensive test coverage in packages/flutter/test/widgets/slivers_test.dart

Issue addressed

Fixes: #173018

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

Add SliverGrid.list constructor that accepts List<Widget> children for cleaner API when working with predefined widget lists. Fixes: flutter#173018

Add test coverage for SliverGrid.list including basic functionality and empty children edge case.

gemini-code-assist

Code Review

This pull request introduces a SliverGrid.list convenience constructor, which simplifies creating a SliverGrid from a list of widgets. The implementation is clean and follows existing patterns in the framework. The accompanying tests cover the basic functionality and edge cases well.

My main feedback is to enhance the documentation for the new constructor to fully align with the Flutter Style Guide by adding a code example and documenting all parameters. This will improve its usability for other developers.

packages/flutter/lib/src/widgets/sliver.dart

…for SliverGrid.list

justinmc · 2025-08-19T22:05:13Z

FYI @loic-sharma since you opened the issue asking for this (#173018).

packages/flutter/lib/src/widgets/sliver.dart

loic-sharma

This looks good to me - thanks for the wonderful contribution!

ahmeddhus · 2025-08-20T20:26:50Z

This looks good to me - thanks for the wonderful contribution!

Thank you! Excited to keep contributing 🙌

victorsanni · 2025-08-20T21:19:39Z

packages/flutter/lib/src/widgets/sliver.dart

+  ///
+  ///


Are these two newlines intentional?

Thanks, that was unintentional. I’ve fixed it 👍

loic-sharma · 2025-08-22T21:44:28Z

@ahmeddhus Looks like there are some formatting issues, can you run dart format?

See: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8705948798842944625/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout

ahmeddhus · 2025-08-24T07:37:51Z

@ahmeddhus Looks like there are some formatting issues, can you run dart format?

See: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8705948798842944625/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout

Fixed 👍🏾

victorsanni

LGTM. Thanks for the PR

auto-submit · 2025-08-28T06:49:23Z

autosubmit label was removed for flutter/flutter/173925, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…173925)

This PR adds a new `SliverGrid.list` convenience constructor that accepts a `List<Widget> children` parameter, providing a cleaner API compared to manually creating `SliverChildListDelegate`. ## What was added The constructor uses `SliverChildListDelegate` internally and follows the same pattern as existing convenience constructors like `SliverGrid.count` and `SliverGrid.extent`. This addresses the use case where developers want to create sliver grids with predefined widget lists without the verbosity of manually constructing the delegate. ## Before/After comparison **Before:** ```dart SliverGrid( gridDelegate: gridDelegate, delegate: SliverChildListDelegate([widget1, widget2, widget3]), ) ``` **After:** ```dart SliverGrid.list( gridDelegate: gridDelegate, children: [widget1, widget2, widget3], ) ``` ## Implementation details - Added `SliverGrid.list` constructor in `packages/flutter/lib/src/widgets/sliver.dart` - Constructor accepts `List<Widget> children` and all necessary delegate configuration parameters - Uses `SliverChildListDelegate` internally for consistent behavior - Added comprehensive test coverage in `packages/flutter/test/widgets/slivers_test.dart` ## Issue addressed Fixes: flutter#173018 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

…173925)

This PR adds a new `SliverGrid.list` convenience constructor that accepts a `List<Widget> children` parameter, providing a cleaner API compared to manually creating `SliverChildListDelegate`. ## What was added The constructor uses `SliverChildListDelegate` internally and follows the same pattern as existing convenience constructors like `SliverGrid.count` and `SliverGrid.extent`. This addresses the use case where developers want to create sliver grids with predefined widget lists without the verbosity of manually constructing the delegate. ## Before/After comparison **Before:** ```dart SliverGrid( gridDelegate: gridDelegate, delegate: SliverChildListDelegate([widget1, widget2, widget3]), ) ``` **After:** ```dart SliverGrid.list( gridDelegate: gridDelegate, children: [widget1, widget2, widget3], ) ``` ## Implementation details - Added `SliverGrid.list` constructor in `packages/flutter/lib/src/widgets/sliver.dart` - Constructor accepts `List<Widget> children` and all necessary delegate configuration parameters - Uses `SliverChildListDelegate` internally for consistent behavior - Added comprehensive test coverage in `packages/flutter/test/widgets/slivers_test.dart` ## Issue addressed Fixes: flutter#173018 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

Ahmed and others added 3 commits August 17, 2025 13:49

feat: Add SliverGrid.list convenience constructor

20f5802

Add SliverGrid.list constructor that accepts List<Widget> children for cleaner API when working with predefined widget lists. Fixes: flutter#173018

Merge branch 'flutter:master' into master

b7e0aa5

test: Add tests for SliverGrid.list constructor

c486107

Add test coverage for SliverGrid.list including basic functionality and empty children edge case.

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Aug 17, 2025

gemini-code-assist bot reviewed Aug 17, 2025

View reviewed changes

packages/flutter/lib/src/widgets/sliver.dart Outdated Show resolved Hide resolved

Ahmed and others added 3 commits August 17, 2025 14:45

docs: Add missing semanticIndexOffset documentation and code example …

5bf197a

…for SliverGrid.list

Merge branch 'master' into master

5e67de2

Merge branch 'master' into master

6749c09

justinmc requested a review from loic-sharma August 19, 2025 22:05

loic-sharma reviewed Aug 19, 2025

View reviewed changes

packages/flutter/lib/src/widgets/sliver.dart Show resolved Hide resolved

loic-sharma reviewed Aug 19, 2025

View reviewed changes

packages/flutter/lib/src/widgets/sliver.dart Outdated Show resolved Hide resolved

loic-sharma added 2 commits August 19, 2025 15:22

Update packages/flutter/lib/src/widgets/sliver.dart

322057d

Update packages/flutter/lib/src/widgets/sliver.dart

72976e7

loic-sharma approved these changes Aug 19, 2025

View reviewed changes

victorsanni reviewed Aug 20, 2025

View reviewed changes

ahmeddhus and others added 2 commits August 21, 2025 09:08

Merge branch 'flutter:master' into master

e628564

Remove duplicate empty comment lines in SliverGrid.list documentation

b3cecd8

ahmeddhus and others added 2 commits August 24, 2025 10:25

Merge branch 'master' into master

62c50c8

Fix formatting issue in sliver.dart

d5611c0

Merge branch 'master' into master

723060a

justinmc requested a review from victorsanni August 26, 2025 22:04

victorsanni approved these changes Aug 28, 2025

View reviewed changes

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2025

engine-flutter-autoroll mentioned this pull request Sep 2, 2025

Roll Flutter from da5523afc3c1 to fd4e3a0a3786 (82 revisions) flutter/packages#9940

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

f6dcff5

…173925)

engine-flutter-autoroll mentioned this pull request Sep 2, 2025

Roll Flutter from da5523afc3c1 to 7a13e1be3a98 (83 revisions) flutter/packages#9941

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

4b3aad7

…173925)

engine-flutter-autoroll mentioned this pull request Sep 2, 2025

Roll Flutter from da5523afc3c1 to a889fae0c20b (84 revisions) flutter/packages#9942

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

cbc9336

…173925)

engine-flutter-autoroll mentioned this pull request Sep 2, 2025

Roll Flutter from da5523afc3c1 to 1d19f9783377 (85 revisions) flutter/packages#9943

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

7219dd5

…173925)

engine-flutter-autoroll mentioned this pull request Sep 2, 2025

Roll Flutter from da5523afc3c1 to 432cfa62aca5 (86 revisions) flutter/packages#9946

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

6544390

…173925)

engine-flutter-autoroll mentioned this pull request Sep 2, 2025

Roll Flutter from da5523afc3c1 to 3cdc9070cc4f (87 revisions) flutter/packages#9947

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

3e43765

…173925)

engine-flutter-autoroll mentioned this pull request Sep 2, 2025

Roll Flutter from da5523afc3c1 to fb754dc30c10 (88 revisions) flutter/packages#9948

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

90fabfe

…173925)

engine-flutter-autoroll mentioned this pull request Sep 3, 2025

Roll Flutter from 6b18740d5a23 to dbe229eba711 (50 revisions) flutter/packages#9950

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

b96121d

…173925)

engine-flutter-autoroll mentioned this pull request Sep 3, 2025

Roll Flutter from 6b18740d5a23 to 3c8479987536 (51 revisions) flutter/packages#9951

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

3d18736

…173925)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

25e9bd4

…173925)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

4412d44

…173925)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

34304f1

…173925)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

9ef902b

…173925)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

6b48921

…173925)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

49d9e23

…173925)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

e2abdb5

…173925)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

05fbe0e Add SliverGrid.list convenience constructor (flutter/flutter#…

2b39a47

…173925)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SliverGrid.list convenience constructor#173925

Add SliverGrid.list convenience constructor#173925
auto-submit[bot] merged 13 commits intoflutter:masterfrom
ahmeddhus:master

ahmeddhus commented Aug 17, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

justinmc commented Aug 19, 2025

Uh oh!

Uh oh!

Uh oh!

loic-sharma left a comment

Uh oh!

ahmeddhus commented Aug 20, 2025

Uh oh!

victorsanni Aug 20, 2025

Uh oh!

ahmeddhus Aug 21, 2025

Uh oh!

loic-sharma commented Aug 22, 2025

Uh oh!

ahmeddhus commented Aug 24, 2025

Uh oh!

victorsanni left a comment

Uh oh!

auto-submit bot commented Aug 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ahmeddhus commented Aug 17, 2025

What was added

Before/After comparison

Implementation details

Issue addressed

Pre-launch Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

justinmc commented Aug 19, 2025

Uh oh!

Uh oh!

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

ahmeddhus commented Aug 20, 2025

Uh oh!

victorsanni Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

ahmeddhus Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

loic-sharma commented Aug 22, 2025

Uh oh!

ahmeddhus commented Aug 24, 2025

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Aug 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants