Add announce support to the engine by ash2moon · Pull Request #169685 · flutter/flutter

ash2moon · 2025-05-29T18:23:10Z

⤵️ Child PR: #168992

Partly re-lands #165531
The PR was originally reverted due to an issue with an internal Google test. I split re-land PR into two separate ones so that we can individually revert in case it fails again.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…' into feat/announcements-part1(engine)

chunhtai

LGTM, left a suggestion on web platform

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/semantics.dart

auto-submit · 2025-06-02T18:22:13Z

autosubmit label was removed for flutter/flutter/169685, because - The status or check suite Linux web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

…' into feat/announcements-part1(engine)

auto-submit · 2025-06-02T19:16:51Z

autosubmit label was removed for flutter/flutter/169685, because - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label.

Part of #165510 ⤴️ Original PR: #169685 ⤵️ Child PR: #168992 This is a renaming of the announce to `supportsAnnounce`. See more info in this comment thread: #168992 (comment) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…165531" (#168992) Partly of #165510 ⤴️ Parent PR: #169685 (✅ Merged) ⤴️ Parent PR (refactor): #170618 (✅ Merged) Re-lands #165531 The PR was originally reverted due to an issue with an internal Google test. I added a new test case under `input_decorator_test.dart` which does something similar to prevent the regression. All other code is the same as #165531. The easiest way to review this would probably be to just check the [diff after the first commit](cb5647c) to see the changes I made. To check if the reland commit is the same, it might be best to just [compare solely that commit](9bd8d56) against the [original PR](https://github.com/flutter/flutter/pull/165531/files). ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Part of flutter#165510 ⤴️ Original PR: flutter#169685 ⤵️ Child PR: flutter#168992 This is a renaming of the announce to `supportsAnnounce`. See more info in this comment thread: flutter#168992 (comment) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…lutter#165531" (flutter#168992) Partly of flutter#165510 ⤴️ Parent PR: flutter#169685 (✅ Merged) ⤴️ Parent PR (refactor): flutter#170618 (✅ Merged) Re-lands flutter#165531 The PR was originally reverted due to an issue with an internal Google test. I added a new test case under `input_decorator_test.dart` which does something similar to prevent the regression. All other code is the same as flutter#165531. The easiest way to review this would probably be to just check the [diff after the first commit](flutter@cb5647c) to see the changes I made. To check if the reland commit is the same, it might be best to just [compare solely that commit](flutter@9bd8d56) against the [original PR](https://github.com/flutter/flutter/pull/165531/files). ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

add announce support to embedders

9619102

ash2moon requested review from cbracken, chinmaygarde and loic-sharma as code owners May 29, 2025 18:23

ash2moon mentioned this pull request May 29, 2025

Add back "Use live region in error text input decorator for Android #165531" #168992

Merged

9 tasks

ash2moon added 5 commits May 29, 2025 11:44

improve docs and apply comment suggestions from flutter#168992

bf7b496

Merge branch 'master' into feat/announcements-part1(engine)

0e782ea

improve docs and apply comment suggestions from flutter#168992

cb97e5e

Merge remote-tracking branch 'origin/feat/announcements-part1(engine)…

a86c8b2

…' into feat/announcements-part1(engine)

Merge branch 'master' into feat/announcements-part1(engine)

c33e6bc

ash2moon requested review from a team, Piinks and chunhtai May 30, 2025 19:03

chunhtai approved these changes Jun 2, 2025

View reviewed changes

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/semantics.dart Show resolved Hide resolved

ash2moon added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 2, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 2, 2025

ash2moon added 2 commits June 2, 2025 12:14

add back trimmed comment

003acfc

Merge remote-tracking branch 'origin/feat/announcements-part1(engine)…

f6b984a

…' into feat/announcements-part1(engine)

ash2moon added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 2, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 2, 2025

ash2moon added 2 commits June 2, 2025 12:17

Merge branch 'master' into feat/announcements-part1(engine)

d5dae09

Merge branch 'master' into feat/announcements-part1(engine)

df78c11

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

c938f22

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to d966d99b680a (127 revisions) flutter/packages#9374

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

74b77c1

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to 0c0406a6158e (128 revisions) flutter/packages#9375

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

8442c8a

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to 99a5b3fb4ec6 (129 revisions) flutter/packages#9376

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

494684d

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to 1fcd888704ea (130 revisions) flutter/packages#9377

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

7cab499

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to 1fcd888704ea (130 revisions) flutter/packages#9378

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

656fc20

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

da2a615

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

5b3d215

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

da75159

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

c8b733c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

b7e7d52

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

76afcac

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

65445b6

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

eb0289f

Piinks mentioned this pull request Jun 6, 2025

Flutter Notable Commits - 2025 #161460

Closed

ash2moon mentioned this pull request Jun 13, 2025

rename from announce to supportsAnnounce on engine #170618

Merged

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

aff27d0

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

4d5bf8f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

79d44cd

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

de91c00

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

694600a Add announce support to the engine (flutter/flutter#169685)

0cfe303

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add announce support to the engine#169685

Add announce support to the engine#169685
auto-submit[bot] merged 10 commits intoflutter:masterfrom
ash2moon:feat/announcements-part1(engine)

ash2moon commented May 29, 2025 •

edited

Loading

Uh oh!

chunhtai left a comment

Uh oh!

Uh oh!

auto-submit bot commented Jun 2, 2025

Uh oh!

auto-submit bot commented Jun 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ash2moon commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auto-submit bot commented Jun 2, 2025

Uh oh!

auto-submit bot commented Jun 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ash2moon commented May 29, 2025 •

edited

Loading