Skip to content

Fix .xcodeproj file name in Setting-up-the-Engine-development-environment.md#168814

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
littleGnAl:littleGnAl-patch-1
Jun 3, 2025
Merged

Fix .xcodeproj file name in Setting-up-the-Engine-development-environment.md#168814
auto-submit[bot] merged 1 commit intoflutter:masterfrom
littleGnAl:littleGnAl-patch-1

Conversation

@littleGnAl
Copy link
Contributor

@littleGnAl littleGnAl commented May 14, 2025

The .xcodeproj file name should be flutter_engine.xcodeproj when compiled with the most recent code.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label May 14, 2025
@jonahwilliams jonahwilliams requested review from cbracken and jmagman May 19, 2025 18:00
jonahwilliams
jonahwilliams approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 2, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 2, 2025

autosubmit label was removed for flutter/flutter/168814, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 2, 2025
@littleGnAl littleGnAl force-pushed the littleGnAl-patch-1 branch from 2d42016 to 10034e0 Compare June 3, 2025 09:06
@littleGnAl
Copy link
Contributor Author

littleGnAl commented Jun 3, 2025

I'm not sure why the check suite failed, I believe it's not caused by this PR, can you take a look? @chinmaygarde @jonahwilliams

@littleGnAl
Fix .xcodeproj file name in Setting-up-the-Engine-development-environ…
5e6e68d 
…ment.md

The `.xcodeproj` file name should be `flutter_engine.xcodeproj` when compiled with the most recent code.
@littleGnAl littleGnAl force-pushed the littleGnAl-patch-1 branch from 10034e0 to 5e6e68d Compare June 3, 2025 12:13
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 3, 2025
Merged via the queue into flutter:master with commit 20c9acd Jun 3, 2025
65 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
91eed65 
…-environment.md (flutter/flutter#168814)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
5914223 
…-environment.md (flutter/flutter#168814)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
8de1c48 
…-environment.md (flutter/flutter#168814)
This was referenced Jun 3, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
35e2b31 
…-environment.md (flutter/flutter#168814)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
6c0a94a 
…-environment.md (flutter/flutter#168814)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
eab1105 
…-environment.md (flutter/flutter#168814)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
6f32538 
…-environment.md (flutter/flutter#168814)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
de62a92 
…-environment.md (flutter/flutter#168814)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
7c73c87 
…-environment.md (flutter/flutter#168814)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
fb2a759 
…-environment.md (flutter/flutter#168814)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
b58a386 
…-environment.md (flutter/flutter#168814)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
530d006 
…-environment.md (flutter/flutter#168814)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
3945449 
…-environment.md (flutter/flutter#168814)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
1fc4f5e 
…-environment.md (flutter/flutter#168814)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
6814548 
…-environment.md (flutter/flutter#168814)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
49d396a 
…-environment.md (flutter/flutter#168814)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
a6bae6a 
…-environment.md (flutter/flutter#168814)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
4f950c3 
…-environment.md (flutter/flutter#168814)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
97db6c5 
…-environment.md (flutter/flutter#168814)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
733f88d 
…-environment.md (flutter/flutter#168814)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
35cc465 
…-environment.md (flutter/flutter#168814)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
e8ebb3c 
…-environment.md (flutter/flutter#168814)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
39a97b8 
…-environment.md (flutter/flutter#168814)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
1e58982 
…-environment.md (flutter/flutter#168814)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
20c9acd Fix .xcodeproj file name in Setting-up-the-Engine-development…
deb8427 
…-environment.md (flutter/flutter#168814)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken Awaiting requested review from cbracken

@jmagman jmagman Awaiting requested review from jmagman

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@littleGnAl @chinmaygarde @jonahwilliams