Skip to content

[Impeller] Move skia_conversions towards retirement#165408

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
flar:gut-skia-conversions
Mar 18, 2025
Merged

[Impeller] Move skia_conversions towards retirement#165408
auto-submit[bot] merged 1 commit intoflutter:masterfrom
flar:gut-skia-conversions

Conversation

@flar
Copy link
Contributor

@flar flar commented Mar 18, 2025

The skia_conversions sources and namespace have been filled with methods that are no longer used now that the DisplayList has its own complete set of APIs and is now mostly obsolete.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 18, 2025
@flar
Copy link
Contributor Author

flar commented Mar 18, 2025 •
edited
Loading

What's left?

  • ToColor - used in a variety of places. (Re)moving this should be combined with fixing up some of our DlColor-v-Color and related discussions.
  • ToSamplerDescriptor - also used in a variety of places. But, could live somewhere less legacy-ish.
  • ToBlendMode - only used in impeller::DlDispatcher, but has unit tests defined here. We should probably combine the 2 data types since they are identical except for naming, and delete it rather than moving it. That will be a fairly large code change to make, but it will be 99.9% just a text substitution with reformatting. For now, I left it here. (See [DisplayList] Use impeller::BlendMode rather than a private DlBlendMode enum #165412)

One thing is for sure - the name skia_conversions itself is now an obsolete legacy.

jonahwilliams
jonahwilliams reviewed Mar 18, 2025
View reviewed changes
engine/src/flutter/impeller/display_list/paint.cc
using DlIRect = flutter::DlIRect;
using DlPath = flutter::DlPath;

void Paint::ConvertStops(const flutter::DlGradientColorSourceBase* gradient,
Copy link
Contributor

@jonahwilliams jonahwilliams Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really do the stop conversion when we record the gradient instead of on each dispatch.

Copy link
Contributor Author

@flar flar Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, move this logic into DL? We could do it when the DlObject is created from Flutter since I don't think there is read back of the stops once Flutter makes one.

Copy link
Contributor Author

@flar flar Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#165409

Copy link
Contributor

@jonahwilliams jonahwilliams Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that SG. We already copy from dart:ui into display list, so the conversion can be done there. Technically this is the same conversion skia does when we dispatch to it, so there should be no change in behavior.

jonahwilliams
jonahwilliams approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 18, 2025

autosubmit label was removed for flutter/flutter/165408, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 18, 2025
Merged via the queue into flutter:master with commit e407d87 Mar 18, 2025
172 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
bc35f68 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
9b61396 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
65b250f 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
3be5f7c 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
cc38601 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
84afc35 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
e42c36e 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
c9ed980 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
7480769 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
185113a 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
13bb08c 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
7496460 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
afdfd4d 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
0f382a0 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
2227948 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
463da16 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
07be1b1 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
2da6e38 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
f11c4bd 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
0bf8976 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
6ffd82a 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
845efda 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
958dd86 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
2e7e417 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
6ac7486 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
72a0713 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
aee7fb6 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
983783b 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
92c73b6 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
0f68294 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
f4ceef2 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
9a7efb6 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
882d33b 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
e5e94d8 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
d98def4 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
b9e5680 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
551e885 
…flutter#165408)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
e407d87 [Impeller] Move skia_conversions towards retirement (flutter/…
2f82a72 
…flutter#165408)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@flar @romanejaquez
[Impeller] Move skia_conversions towards retirement (flutter#165408)
4ec647e 
The skia_conversions sources and namespace have been filled with methods
that are no longer used now that the DisplayList has its own complete
set of APIs and is now mostly obsolete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flar @jonahwilliams