Adds list and list item roles by chunhtai · Pull Request #164809 · flutter/flutter

chunhtai · 2025-03-07T19:49:13Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

yjbanov · 2025-03-07T21:55:39Z

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/list.dart

+///
+/// Uses aria list role to convey this semantic information to the element.
+///
+/// Screen-readers takes advantage of "aria-label" to describe the visual.


nit: s/takes/take/

yjbanov · 2025-03-07T21:55:51Z

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/list.dart

+  bool focusAsRouteDefault() => focusable?.focusAsRouteDefault() ?? false;
+}
+
+/// Indicates a item in a list.


nit: s/a item/an item/

yjbanov · 2025-03-07T21:56:05Z

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/list.dart

+///
+/// Uses aria listitem role to convey this semantic information to the element.
+///
+/// Screen-readers takes advantage of "aria-label" to describe the visual.


nit: s/takes/take/

yjbanov · 2025-03-07T21:58:33Z

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/semantics.dart

  /// A cell in a [table] contains header information for a column.
  columnHeader,

+  /// A container that display its children in a list layout.


nit: s/display/displays/

Instead of saying "list layout" (how is a list laid out? can it be horizontal?), consider saying "...whose children are logically a list of items". We should also probably explain that it is expected that each child node has the role [listItem].

yjbanov · 2025-03-07T21:59:37Z

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/semantics.dart

+  /// A container that display its children in a list layout.
+  list,
+
+  /// An item in a [list].


Does listItem need to be a direct child of a list? We have a similar situation/problem with tables.

yes, it has the same problem, so I think @hannah-hyj 's pr will help fix this issue

Cool. Do we want to document and/or enforce the relationship in the node structure somehow?

for semanticsnode, yes we have check in framework side. i.e. _semanticsListItem

or do you meant in dom structure?

A check in the framework is probably good enough, and it's probably easier to maintain there.

packages/flutter/lib/src/semantics/semantics.dart

auto-submit · 2025-03-12T19:42:32Z

autosubmit label was removed for flutter/flutter/164809, because - The status or check suite Linux_android_emu android_engine_vulkan_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-03-13T16:26:19Z

autosubmit label was removed for flutter/flutter/164809, because Pull request flutter/flutter/164809 is not in a mergeable state.

fixes flutter#162121 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

chunhtai force-pushed the issues/162121 branch from c03d767 to 8716037 Compare March 7, 2025 20:00

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-web Web applications specifically labels Mar 7, 2025

chunhtai requested a review from yjbanov March 7, 2025 21:54

yjbanov reviewed Mar 7, 2025

View reviewed changes

chunhtai requested a review from yjbanov March 7, 2025 22:17

github-actions bot added the f: routes Navigator, Router, and related APIs. label Mar 8, 2025

yjbanov reviewed Mar 11, 2025

View reviewed changes

packages/flutter/lib/src/semantics/semantics.dart Show resolved Hide resolved

yjbanov approved these changes Mar 11, 2025

View reviewed changes

chunhtai force-pushed the issues/162121 branch from abaec45 to dbc568b Compare March 12, 2025 18:51

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2025

chunhtai force-pushed the issues/162121 branch from 6cfe63a to 55ea039 Compare March 12, 2025 20:26

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025

chunhtai added 7 commits March 13, 2025 09:37

WIP

cb9cf11

update

3d05b24

fix ci

bb69a12

update

7104805

update

3698c54

update

04871d8

format

9f941aa

chunhtai force-pushed the issues/162121 branch from a11e06a to 9f941aa Compare March 13, 2025 16:40

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025

auto-submit bot added this pull request to the merge queue Mar 13, 2025

engine-flutter-autoroll mentioned this pull request Mar 16, 2025

Roll Flutter from b16430b2fd57 to d05bba1c41f6 (99 revisions) flutter/packages#8883

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

450f3b3

engine-flutter-autoroll mentioned this pull request Mar 16, 2025

Roll Flutter from b16430b2fd57 to d05bba1c41f6 (99 revisions) flutter/packages#8884

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

33c3353

engine-flutter-autoroll mentioned this pull request Mar 17, 2025

Roll Flutter from b16430b2fd57 to 082a761570e8 (101 revisions) flutter/packages#8886

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

8089d0c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

3e07c97

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

60ea28d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

25e7266

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

c997537

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

857c28d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

b8c6967

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

ddb0b75

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

ffc4e81

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

0b84712

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

e403362

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

f32c129

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

09d8150

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

5ffad6c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

c727d33

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

fb677ca

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

2fa6f13

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

d74c165

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

8b9f864

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

9ad3251

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

a29c8a1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

441a24d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

1f0bf04

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

5122ffd Adds list and list item roles (flutter/flutter#164809)

83383df

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds list and list item roles#164809

Adds list and list item roles#164809
auto-submit[bot] merged 7 commits intoflutter:masterfrom
chunhtai:issues/162121

chunhtai commented Mar 7, 2025

Uh oh!

yjbanov Mar 7, 2025

Uh oh!

yjbanov Mar 7, 2025

Uh oh!

yjbanov Mar 7, 2025

Uh oh!

yjbanov Mar 7, 2025

Uh oh!

yjbanov Mar 7, 2025

Uh oh!

chunhtai Mar 7, 2025

Uh oh!

yjbanov Mar 7, 2025

Uh oh!

chunhtai Mar 7, 2025

Uh oh!

yjbanov Mar 11, 2025

Uh oh!

Uh oh!

auto-submit bot commented Mar 12, 2025

Uh oh!

auto-submit bot commented Mar 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

chunhtai commented Mar 7, 2025

Pre-launch Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auto-submit bot commented Mar 12, 2025

Uh oh!

auto-submit bot commented Mar 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants