material docImports#152060
Conversation
I skipped files that has generated code and did not fix some dubious comment refs. Those will be addressed in a different PR.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
srawlins
left a comment
There was a problem hiding this comment.
Everything looks great! We're still in dogfood so I just checked for a few things that don't work yet:
- using
asdoes not work, - using
showorhidedo not work.
Everything looks good here!
|
test-exempt: doc comments only. |
flutter#150800. I skipped files that contain generated code because the script isn't smart enough, and I did not fix some dubious comment refs. Those will be addressed in a different PR.
flutter#150800. I skipped files that contain generated code because the script isn't smart enough, and I did not fix some dubious comment refs. Those will be addressed in a different PR.
#150800. I skipped files that contain generated code because the script isn't smart enough, and I did not fix some dubious comment refs. Those will be addressed in a different PR.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.