Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Confirmed that |
flutter/flutter@5187cab...ccf3abe 2024-06-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2218a4566765 to 5989f0215fed (9 revisions) (flutter/flutter#150373) 2024-06-17 mit@google.com Update API docs footer (flutter/flutter#150347) 2024-06-17 katelovett@google.com Update old wiki links (flutter/flutter#149544) 2024-06-17 codefu@google.com Fix flaky complex_layout_scroll_perf__memory & flutter_gallery__memory_nav (flutter/flutter#150368) 2024-06-17 engine-flutter-autoroll@skia.org Roll Packages from dd04ab1 to 711b4ac (3 revisions) (flutter/flutter#150359) 2024-06-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9779c273aac3 to 2218a4566765 (3 revisions) (flutter/flutter#150298) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Update API docs footer with a cookie banner (go/cookiebanner) using the glue banner (go/glue-cookiebar)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.