Copy part files and sourcemaps when building with dart2js.#146356
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Apr 5, 2024
Merged
Copy part files and sourcemaps when building with dart2js.#146356auto-submit[bot] merged 1 commit intoflutter:masterfrom
auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
yjbanov
reviewed
Apr 5, 2024
| if (file.basename == 'main.dart.js.map') { | ||
| return compilerConfig.sourceMaps; | ||
| } | ||
| final RegExp partFileRegex = RegExp(r'main\.dart\.js_[0-9].*\.part\.js'); |
Contributor
There was a problem hiding this comment.
Is there a risk of a silent failure if dart2js changes the file structure but we forget to update these regexes? Is there a way to fail hard during a Dart SDK roll?
Contributor
Author
There was a problem hiding this comment.
I think that would require some larger end-to-end integration test. I'm going to file an issue as a follow-on for adding an integration test for this.
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Apr 5, 2024
…46356) This fixes flutter#145653 When dart2js emits deferred part files, they need to be copied from the build folder to the output folder.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 7, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 7, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 7, 2024
flutter/flutter@477ebd8...98d23f7 2024-04-06 31859944+LongCatIsLooong@users.noreply.github.com Prepare for RenderDecorator.computeBaseline changes. (flutter/flutter#146363) 2024-04-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 563bdb1d7976 to 605b3f35fa0a (1 revision) (flutter/flutter#146393) 2024-04-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 482172d16528 to 563bdb1d7976 (1 revision) (flutter/flutter#146385) 2024-04-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from b0d7ac5425e9 to 482172d16528 (1 revision) (flutter/flutter#146382) 2024-04-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from df9f7433fc70 to b0d7ac5425e9 (2 revisions) (flutter/flutter#146377) 2024-04-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from b5039157cbc1 to df9f7433fc70 (1 revision) (flutter/flutter#146373) 2024-04-05 ian@hixie.ch Make FileSystem dependency explicit througout. (flutter/flutter#146008) 2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48604dfd9d49 to b5039157cbc1 (3 revisions) (flutter/flutter#146370) 2024-04-05 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.9 to 3.24.10 (flutter/flutter#146368) 2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from da995a1061c5 to 48604dfd9d49 (2 revisions) (flutter/flutter#146366) 2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6a478d6931b2 to da995a1061c5 (1 revision) (flutter/flutter#146364) 2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 62df3bd5f681 to 6a478d6931b2 (3 revisions) (flutter/flutter#146360) 2024-04-05 jacksongardner@google.com Copy part files and sourcemaps when building with dart2js. (flutter/flutter#146356) 2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from d048b9aed529 to 62df3bd5f681 (1 revision) (flutter/flutter#146357) 2024-04-05 34871572+gmackall@users.noreply.github.com Reland "Bump to AGP 8.1/Gradle 8.3 (almost) everywhere" (flutter/flutter#146307) 2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6974dbac35a1 to d048b9aed529 (1 revision) (flutter/flutter#146355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…46356) This fixes flutter#145653 When dart2js emits deferred part files, they need to be copied from the build folder to the output folder.
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@477ebd8...98d23f7 2024-04-06 31859944+LongCatIsLooong@users.noreply.github.com Prepare for RenderDecorator.computeBaseline changes. (flutter/flutter#146363) 2024-04-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 563bdb1d7976 to 605b3f35fa0a (1 revision) (flutter/flutter#146393) 2024-04-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 482172d16528 to 563bdb1d7976 (1 revision) (flutter/flutter#146385) 2024-04-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from b0d7ac5425e9 to 482172d16528 (1 revision) (flutter/flutter#146382) 2024-04-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from df9f7433fc70 to b0d7ac5425e9 (2 revisions) (flutter/flutter#146377) 2024-04-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from b5039157cbc1 to df9f7433fc70 (1 revision) (flutter/flutter#146373) 2024-04-05 ian@hixie.ch Make FileSystem dependency explicit througout. (flutter/flutter#146008) 2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48604dfd9d49 to b5039157cbc1 (3 revisions) (flutter/flutter#146370) 2024-04-05 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.9 to 3.24.10 (flutter/flutter#146368) 2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from da995a1061c5 to 48604dfd9d49 (2 revisions) (flutter/flutter#146366) 2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6a478d6931b2 to da995a1061c5 (1 revision) (flutter/flutter#146364) 2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 62df3bd5f681 to 6a478d6931b2 (3 revisions) (flutter/flutter#146360) 2024-04-05 jacksongardner@google.com Copy part files and sourcemaps when building with dart2js. (flutter/flutter#146356) 2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from d048b9aed529 to 62df3bd5f681 (1 revision) (flutter/flutter#146357) 2024-04-05 34871572+gmackall@users.noreply.github.com Reland "Bump to AGP 8.1/Gradle 8.3 (almost) everywhere" (flutter/flutter#146307) 2024-04-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6974dbac35a1 to d048b9aed529 (1 revision) (flutter/flutter#146355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #145653
When dart2js emits deferred part files, they need to be copied from the build folder to the output folder.