Refactor JSNumber.toDart and Object.toJS#129436
Merged
srujzs merged 1 commit intoflutter:masterfrom Jul 12, 2023
Merged
Conversation
8 tasks
Contributor
Author
|
@eyebrowsoffire These are the framework changes - PTAL when you get a chance, thanks! |
c6334d5 to
7d4ed54
Compare
Contributor
Author
|
@eyebrowsoffire FYI - I changed the |
8 tasks
JSNumber.toDart will now be two functions: toDartDouble and toDartInt. There was code that did an Object.toJS. This has been changed to use Function.toJS as well to make it consistent with the code in flutter/packages: https://github.com/flutter/packages/blob/0ef393811d0c2653e68ac135733353fcad8fffa9/packages/web_benchmarks/lib/src/recorder.dart#L1223
eyebrowsoffire
approved these changes
Jul 7, 2023
Member
|
(Triage): Is this good to be submitted? If so, can you throw on the auto-submit label? |
Contributor
Author
|
Kind of. I'm waiting to submit this and flutter/engine#43363 at roughly the same time so that I can land the Dart CL that removes some of these members right after. I want to avoid a situation where these members are used in newer code (thus resulting in another CL) before I get to remove them. |
srujzs
added a commit
to flutter/engine
that referenced
this pull request
Jul 12, 2023
This reverts commit dce75ab. This also makes some small changes to make onBenchmark a JSExportedDartFunction instead of a JSBoxedDartObject. This is for changes in flutter/flutter#129436 and to account for the fact that flutter/packages provides an `allowInterop`'d function. Benchmarks tests pass with this CL. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [X] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I signed the [CLA]. - [ ] All existing and new tests are passing.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 13, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 13, 2023
flutter/flutter@544d30d...c40173f 2023-07-13 jonahwilliams@google.com Revert "Roll Flutter Engine from 16e2ab7e986c to 1b1ccdd1f527 (13 revisions)" (flutter/flutter#130479) 2023-07-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 16e2ab7e986c to 1b1ccdd1f527 (13 revisions) (flutter/flutter#130458) 2023-07-13 31859944+LongCatIsLooong@users.noreply.github.com Exclude `Tooltip`'s overlay child from SelectableRegion (flutter/flutter#130181) 2023-07-12 36861262+QuncCccccc@users.noreply.github.com Update `Checkbox` tests for M2/M3 (flutter/flutter#130351) 2023-07-12 58529443+srujzs@users.noreply.github.com Refactor JSNumber.toDart and Object.toJS (flutter/flutter#129436) 2023-07-12 82336674+gilnobrega@users.noreply.github.com Reland [a11y] CupertinoSwitch On/Off labels (flutter/flutter#130173) 2023-07-12 gspencergoog@users.noreply.github.com Add missing links to examples that aren't linked anywhere (flutter/flutter#130422) 2023-07-12 thkim1011@users.noreply.github.com Use platform specific line separator in gen-l10n (flutter/flutter#130090) 2023-07-12 tessertaha@gmail.com Update `Divider`/`VerticalDivider` and theme tests for M2/M3 (flutter/flutter#130415) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5c887028810d to 16e2ab7e986c (2 revisions) (flutter/flutter#130421) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 13, 2023
JSNumber.toDart will now be two functions: toDartDouble and toDartInt. There was code that did an Object.toJS. This has been changed to use Function.toJS as well to make it consistent with the code in flutter/packages: https://github.com/flutter/packages/blob/0ef393811d0c2653e68ac135733353fcad8fffa9/packages/web_benchmarks/lib/src/recorder.dart#L1223 This is to help land this CL: https://dart-review.googlesource.com/c/sdk/+/309082 https://dart-review.googlesource.com/c/sdk/+/309081 is the CL that added the new methods. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing.
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
This reverts commit dce75ab. This also makes some small changes to make onBenchmark a JSExportedDartFunction instead of a JSBoxedDartObject. This is for changes in flutter/flutter#129436 and to account for the fact that flutter/packages provides an `allowInterop`'d function. Benchmarks tests pass with this CL. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [X] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I signed the [CLA]. - [ ] All existing and new tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSNumber.toDart will now be two functions: toDartDouble and toDartInt.
There was code that did an Object.toJS. This has been changed to
use Function.toJS as well to make it consistent with the code
in flutter/packages: https://github.com/flutter/packages/blob/0ef393811d0c2653e68ac135733353fcad8fffa9/packages/web_benchmarks/lib/src/recorder.dart#L1223
This is to help land this CL: https://dart-review.googlesource.com/c/sdk/+/309082
https://dart-review.googlesource.com/c/sdk/+/309081 is the CL that added the new methods.
Pre-launch Checklist
///).