flutter tool: make FlutterOptions abstract final#124178

Merged

auto-submit[bot] merged 6 commits intomasterfrom

flutter_options_abstract_final

Apr 6, 2023

Contributor

kevmoo commented Apr 5, 2023

Never meant to be instantiated, implemented, or extended


          flutter tool: make FlutterOptions abstract final

060067b

Never meant to be instantiated, implemented, or extended

flutter-dashboard bot added the tool label

flutter-dashboard bot commented Apr 5, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

kevmoo requested a review from christopherfujino

April 5, 2023 02:07

Contributor Author

kevmoo commented Apr 5, 2023

Using those fun new Dart language features.

christopherfujino reviewed

View reviewed changes

packages/flutter_tools/lib/src/runner/flutter_command.dart Show resolved Hide resolved

christopherfujino approved these changes

View reviewed changes

Contributor

christopherfujino left a comment

LGTM

kevmoo added the autosubmit label

auto-submit bot removed the autosubmit label

Contributor

auto-submit bot commented Apr 5, 2023

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.


          Merge branch 'master' into flutter_options_abstract_final

9db4a9c

kevmoo added the autosubmit label

auto-submit bot removed the autosubmit label

Contributor

auto-submit bot commented Apr 5, 2023

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.


          Merge branch 'master' into flutter_options_abstract_final

bedfbf1

kevmoo added the autosubmit label

auto-submit bot removed the autosubmit label

Contributor

auto-submit bot commented Apr 5, 2023

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

kevmoo added 2 commits

April 5, 2023 10:23


          Merge branch 'master' into flutter_options_abstract_final

19a29f0


          Merge branch 'master' into flutter_options_abstract_final

kevmoo added the autosubmit label

Contributor

auto-submit bot commented Apr 6, 2023

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit bot removed the autosubmit label


          Merge branch 'master' into flutter_options_abstract_final

23837fb

kevmoo added the autosubmit label

auto-submit bot removed the autosubmit label

Contributor

auto-submit bot commented Apr 6, 2023

auto label is removed for flutter/flutter, pr: 124178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

kevmoo added the autosubmit label

auto-submit bot merged commit d062bfa into master

auto-submit bot deleted the flutter_options_abstract_final branch

April 6, 2023 05:34

zanderso added a commit that referenced this pull request


          Revert "flutter tool: make FlutterOptions abstract final (#124178)"

7eb25fb

This reverts commit d062bfa.

zanderso mentioned this pull request

Revert "flutter tool: make FlutterOptions abstract final" #124303

Merged

auto-submit bot mentioned this pull request

Review request for Revert PR flutter/flutter#124303 #124304

Closed

zanderso mentioned this pull request

Revert "flutter tool: log dart2wasm vs dart2js as appropriate during build" #124305

Merged

engine-flutter-autoroll mentioned this pull request

Roll Flutter from daaa32bc0638 to a086c640dcc4 (27 revisions) flutter/packages#3654

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          d062bfa flutter tool: make FlutterOptions abstract final (flutter/flu…

599a1e9

…tter#124178)

kevmoo mentioned this pull request

flutter tool: make FlutterOptions abstract final #124335

Merged

kevmoo added a commit that referenced this pull request


          flutter tool: make FlutterOptions abstract final

3c35a05

Relands #124178 - d062bfa
Unlands #124303 - 419c1eb

flutter tool: make FlutterOptions abstract final

exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request


          flutter tool: make FlutterOptions abstract final (flutter#124178)

70ab68d

flutter tool: make FlutterOptions abstract final

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          d062bfa flutter tool: make FlutterOptions abstract final (flutter/flu…

50cfafc

…tter#124178)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          d062bfa flutter tool: make FlutterOptions abstract final (flutter/flu…

67739b4

…tter#124178)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit tool