Update Material 3 bottom sheet #122445
Merged
hannah-hyj merged 20 commits intoflutter:masterfrom Mar 19, 2023
Merged
Conversation
8 tasks
guidezpl
requested changes
Mar 13, 2023
Member
guidezpl
left a comment
There was a problem hiding this comment.
Nice! Quick comments about docs and relation with enableDrag
Member
|
Everything LGTM now except what's covered in existing open threads: I'll leave @HansMuller and @guidezpl to wrap those up and approve the PR when they think it's ready. Thanks for all your work on this! |
052f822 to
fe04be7
Compare
HansMuller
reviewed
Mar 15, 2023
guidezpl
approved these changes
Mar 16, 2023
Member
guidezpl
left a comment
There was a problem hiding this comment.
Nice work! Just minor nits about formatting and docs
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
ce7faf5 to
0d7efc7
Compare
Contributor
|
auto label is removed for flutter/flutter, pr: 122445, due to - The status or check suite Windows web_tool_tests_1_2 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
e756a8f to
d45e0e6
Compare
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
Update bottom_sheet_test.dart Update bottom_sheet.dart
d45e0e6 to
2b10969
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 19, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue:#111448
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.