Roll Flutter Engine from 7572fe5b9226 to 9270e3de510e (1 revision)#122438
Closed
Conversation
fluttergithubbot
approved these changes
Mar 10, 2023
Contributor
|
auto label is removed for flutter/flutter, pr: 122438, due to - The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
Author
|
Commit queue failed; closing this roll. |
Contributor
|
@LongCatIsLooong I've regenerated goldens for Tiler using this version, the correct hash is 0f80585f1f7d9a01a463c316e44c59b3cc86f9f0 Please review the differences listed here to ensure they're what you expect - the changes are fairly subtle (for ex. some lines being slightly lighter/thinner) and I'm not familiar with the change that was made and what difference was expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter/engine@7572fe5...9270e3d
2023-03-10 31859944+LongCatIsLooong@users.noreply.github.com Make FlutterTest the default test font (flutter/engine#40188)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md