Clean up scrollable.dart for 2D#122357
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Mar 10, 2023
Merged
Conversation
reidbaker
approved these changes
Mar 10, 2023
Contributor
reidbaker
left a comment
There was a problem hiding this comment.
I have a mild preference for scrollable_helpers to have its own test file but I can see the value in showing that the existing tests still pass after the move.
Contributor
Author
|
I concur! I will move the related tests into a new file in a separate PR to ensure ensure everything still checks out. 👍 |
8 tasks
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
Clean up scrollable.dart for 2D
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the 2D scrolling proposal: flutter.dev/go/2D-Foundation
Part of #122355 (tests will be migrated separately for validation)
This relocates some public APIs to another file in order to make some breathing room for TwoDimensionalScrollable.
I also tidied up some getters that were scattered throughout ScrollableState.
This required exposing 2 new getters on ScrollableState
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.