Remove no-longer-needed clamping of RRect radii#111668
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Sep 15, 2022
Merged
Remove no-longer-needed clamping of RRect radii#111668auto-submit[bot] merged 1 commit intoflutter:masterfrom
auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
test-exempt: code refactor with no semantic change |
This was referenced Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 16, 2022
itsjustkevin
added a commit
that referenced
this pull request
Sep 21, 2022
itsjustkevin
added a commit
that referenced
this pull request
Sep 22, 2022
* update engine version * Prepare the framework for having RRect assert on negative radii (#111515) * Remove no-longer-needed clamping of RRect radii (#111668) * Revert "Use semantics label for backbutton and closebutton for Androi… (#111636) * Roll Flutter Engine from 4096e13 to 6610f3f (11 revisions) (#111240) * Revert Ballistic & Clamping simulation updates (#111201) * Revert "Update `MaterialBanner` to support Material 3" (#111288) * Revert "Use semantics label for backbutton and closebutton for Android" (#111305) Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Casey Hillers <chillers@google.com> Co-authored-by: Xilai Zhang <xilaizhang@google.com> Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com> Co-authored-by: godofredoc <godofredoc@google.com> Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Casey Hillers <chillers@google.com> Co-authored-by: Xilai Zhang <xilaizhang@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes some clamping added in #111515 now that flutter/engine#36062 has landed in the framework.
Related Issues
Tests