Fix DraggableScrollableSheet and ListView has tiny scroll of one pixel#109081
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Aug 9, 2022
Merged
Fix DraggableScrollableSheet and ListView has tiny scroll of one pixel#109081auto-submit[bot] merged 1 commit intoflutter:masterfrom
auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
Piinks
reviewed
Aug 8, 2022
Contributor
Piinks
left a comment
There was a problem hiding this comment.
Hey @xu-baolin good to see you!
| children: <TestSemantics>[ | ||
| TestSemantics( | ||
| flags: <SemanticsFlag>[SemanticsFlag.hasImplicitScrolling], | ||
| actions: <SemanticsAction>[SemanticsAction.scrollDown, SemanticsAction.scrollUp], |
Member
Author
There was a problem hiding this comment.
This is a line of reverting the original fixes. Giving one pixel content dimensions makes it scrollable.
Contributor
There was a problem hiding this comment.
Ah ok, and so it serves as a regression test. Thanks for explaining!
Piinks
approved these changes
Aug 9, 2022
| children: <TestSemantics>[ | ||
| TestSemantics( | ||
| flags: <SemanticsFlag>[SemanticsFlag.hasImplicitScrolling], | ||
| actions: <SemanticsAction>[SemanticsAction.scrollDown, SemanticsAction.scrollUp], |
Contributor
There was a problem hiding this comment.
Ah ok, and so it serves as a regression test. Thanks for explaining!
This was referenced Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 10, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98314
I have change another solution to rework #31832 that remove the side affect.
@dnfield Could you take a look at this?