Skip to content

Added benchmark for early removal of unused raster cache entris mecha…#107918

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
ColdPaleLight:colorfilted_with_unstable_child
Jul 20, 2022
Merged

Added benchmark for early removal of unused raster cache entris mecha…#107918
auto-submit[bot] merged 3 commits intoflutter:masterfrom
ColdPaleLight:colorfilted_with_unstable_child

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Jul 19, 2022 •
edited
Loading

benchmark for flutter/engine#34627

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ColdPaleLight ColdPaleLight requested a review from keyonghan as a code owner July 19, 2022 09:44
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 19, 2022
@ColdPaleLight ColdPaleLight requested a review from flar July 19, 2022 09:47
@ColdPaleLight ColdPaleLight mentioned this pull request Jul 19, 2022
Merged
8 tasks
flar
flar requested changes Jul 19, 2022
View reviewed changes
dev/benchmarks/macrobenchmarks/lib/src/color_filter_with_unstable_child.dart Outdated
super.initState();

_controller = AnimationController(vsync: this, duration: const Duration(seconds: 2));
// Animations are typically implemented using the AnimatedBuilder widget.
Copy link
Contributor

@flar flar Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This benchmark has no history to maintain. It looks like this comment and implementation were cut/pasted from some other benchmark that had to deal with consistency, but that doesn't apply here. Shouldn't it use the more recommended mechanism in this case?

Copy link
Member Author

@ColdPaleLight ColdPaleLight Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, using AnimatedBuilder now.

@ColdPaleLight ColdPaleLight requested a review from flar July 20, 2022 09:02
flar
flar approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 20, 2022
@flar
Copy link
Contributor

flar commented Jul 20, 2022

I went ahead and added the autosubmit label so this can get into the tree to start gathering baseline data.

@auto-submit auto-submit bot merged commit 1919167 into flutter:master Jul 20, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
d17a48d 
…is mecha… (flutter/flutter#107918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
67ef4ff 
…is mecha… (flutter/flutter#107918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
64c65c6 
…is mecha… (flutter/flutter#107918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
3f0848a 
…is mecha… (flutter/flutter#107918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
ea84620 
…is mecha… (flutter/flutter#107918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
fd2aa6e 
…is mecha… (flutter/flutter#107918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
6e607b9 
…is mecha… (flutter/flutter#107918)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
ec48ad7 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
3e9b164 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
422a4f1 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
9106087 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
c97f50e 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
1e37cff 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
3bd625c 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
753ae60 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
5f0783f 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
2b84930 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
ea0ad28 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
6a89a1b 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
f27b96a 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
05f258d 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
f42f768 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
4531f11 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
d70edbc 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
44d0e37 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
8beeb9d 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
f80804e 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
b6b941b 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
6779462 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
2eff4c6 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
b08675c 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
886d760 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
1cdc490 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
c39f763 
…is mecha… (flutter/flutter#107918)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
1919167 Added benchmark for early removal of unused raster cache entr…
edb5a2c 
…is mecha… (flutter/flutter#107918)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@ColdPaleLight @camsim99
Added benchmark for early removal of unused raster cache entris mecha… (
e908b5c 
flutter#107918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flar flar flar approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ColdPaleLight @flar