Expose the duration and curve for theme animation in MaterialApp.#107383
Merged
darrenaustin merged 2 commits intoflutter:masterfrom Jul 11, 2022
darrenaustin:material_theme_animation
Merged
Expose the duration and curve for theme animation in MaterialApp.#107383darrenaustin merged 2 commits intoflutter:masterfrom darrenaustin:material_theme_animation
darrenaustin merged 2 commits intoflutter:masterfrom
darrenaustin:material_theme_animation
Conversation
HansMuller
approved these changes
Jul 11, 2022
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
LGTM
What happens if these parameters are changed while a theme animation is underway?
Contributor
Author
In the underlying flutter/packages/flutter/lib/src/widgets/implicit_animations.dart Lines 382 to 389 in f980d66 Do you think we need to call this out in the docs for MaterialApp? |
Contributor
|
#107383 (comment) sounds OK, I don't think we need to document that case. |
This was referenced Jul 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 12, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
MaterialApp's theme changes, it is animated over time (via theAnimatedThemewidget). This PR exposes the duration and curve used for this animation:Or if you want to turn off the animation altogether, you can set the duration to zero:
Fixed: #105883
Pre-launch Checklist
///).