[fuchsia] Change format of ffx call to debug spam.#105169
[fuchsia] Change format of ffx call to debug spam.#105169auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Pushed a merge from upstream to to fix the JWT error on cirrus |
|
Thanks! |
|
This pull request is not suitable for automatic merging in its current state.
|
|
Let me push a unit test fix, too |
christopherfujino
left a comment
There was a problem hiding this comment.
for consistency, should we also update line 88?
9d21a6b to
0c20d9f
Compare
|
Updated that line now, thanks. |
|
Working to fix unit tests... |
|
This pull request is not suitable for automatic merging in its current state.
|
6e501c3 to
bfe38cf
Compare
|
This pull request is not suitable for automatic merging in its current state.
|
eff97e7 to
3ddcfb9
Compare
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Fuchsia is seeing a large amount of ffx analytics spam with the command `ffx -T 30 target list --format s`. We suspect it is coming from this file but are not sure. We are changing the format of this call to verify that the spammed command also changes in our analytics.
Fuchsia is seeing a large amount of
ffx analytics spam with the command
ffx -T 30 target list --format s. Wesuspect it is coming from this file but are
not 100% sure. We are changing the format of this
call to verify that the spammed command also
changes in our analytics.