Skip to content

Add actionsPadding to dialog theme#105109

Merged
guidezpl merged 3 commits intoflutter:masterfrom
guidezpl:dialogs-theme
Jun 1, 2022
Merged

Add actionsPadding to dialog theme#105109
guidezpl merged 3 commits intoflutter:masterfrom
guidezpl:dialogs-theme

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Jun 1, 2022 •
edited
Loading

Follow-up to #105008

#105007

Internal issue b/224899965

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 1, 2022
TahaTesser
TahaTesser approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidezpl guidezpl merged commit 5d10cf5 into flutter:master Jun 1, 2022
@guidezpl guidezpl deleted the dialogs-theme branch June 1, 2022 13:52
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
a2f1dae
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
e2a1a3b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
767a6d7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
2927295
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
bf95c03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
1d74b3f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
75c5a60
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
17887bd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
c0935a0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
guidezpl added a commit that referenced this pull request Jun 3, 2022
@guidezpl
Revert "Add actionsPadding to dialog theme (#105109)" (#105293)
c4a6ab1 
This reverts commit 5d10cf5.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
032e687
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
df11b53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
0c51da2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
89d917a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
615e09a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
afad33f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
d048bef
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
5acae52
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
195d639
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
7ffff78
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
7f55989
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
57d42b5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
9a9ceda
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
adcee30
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
ba1ffb0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
bd1f9d3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
36320e5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
b9259c9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
4a83737
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
7f14ca1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
d417f55
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
d6ca98d
@guidezpl guidezpl mentioned this pull request Jun 8, 2022
Merged
guidezpl added a commit that referenced this pull request Jun 14, 2022
@guidezpl
reland #105109 (#105588)
1d53378
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@guidezpl @camsim99
Add actionsPadding to dialog theme (flutter#105109)
195d940 
* add actionsPadding to dialog theme and refactor

* fix typo

* remove trailing spaces
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@guidezpl @camsim99
Revert "Add actionsPadding to dialog theme (flutter#105109)" (flutt…
6f49ea1 
…er#105293)

This reverts commit 5d10cf5.
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@guidezpl @camsim99
reland flutter#105109 (flutter#105588)
075ee24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
f7dede2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
5d10cf5 Add actionsPadding to dialog theme (flutter/flutter#105109)
1328765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

1 more reviewer

@TahaTesser TahaTesser TahaTesser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guidezpl @TahaTesser