Skip to content

Improve 'NestedScrollView and internal scrolling' test to account for all the inner children layers#102309

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
NevercodeHQ:fix_nested_scroll_test
Apr 21, 2022
Merged

Improve 'NestedScrollView and internal scrolling' test to account for all the inner children layers#102309
fluttergithubbot merged 1 commit intoflutter:masterfrom
NevercodeHQ:fix_nested_scroll_test

Conversation

@TahaTesser
Copy link
Contributor

@TahaTesser TahaTesser commented Apr 21, 2022 •
edited
Loading

fixes #102307

Layer tree without #102310
layer_tree.txt

Layer tree with #102310
layer_tree_updated.txt

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Apr 21, 2022
@TahaTesser TahaTesser mentioned this pull request Apr 21, 2022
Merged
8 tasks
@TahaTesser
Copy link
Contributor Author

TahaTesser commented Apr 21, 2022 •
edited
Loading

cc: @dnfield
This needs to be landed for #102310

@TahaTesser TahaTesser mentioned this pull request Apr 21, 2022
Closed
8 tasks
@TahaTesser TahaTesser requested a review from dnfield April 21, 2022 16:11
@fluttergithubbot fluttergithubbot merged commit e4edcbc into flutter:master Apr 21, 2022
@TahaTesser TahaTesser deleted the fix_nested_scroll_test branch April 21, 2022 20:55
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
c03af62 
…ount for all the inner children layers (flutter/flutter#102309)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
7c4bab9 
…ount for all the inner children layers (flutter/flutter#102309)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
dd22101 
…ount for all the inner children layers (flutter/flutter#102309)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
e1e4a86 
…ount for all the inner children layers (flutter/flutter#102309)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
0d202e5 
…ount for all the inner children layers (flutter/flutter#102309)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
ef947cc 
…ount for all the inner children layers (flutter/flutter#102309)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
136a809 
…ount for all the inner children layers (flutter/flutter#102309)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
7bcea4b 
…ount for all the inner children layers (flutter/flutter#102309)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
1c3d148 
…ount for all the inner children layers (flutter/flutter#102309)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
ff65ab4 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
5d300d5 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
4e9ff6e 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
2796036 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
dbdf117 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
a7c4d9a 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
fcdd826 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
18face3 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
ff50ac9 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
0a0b057 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
479c7c9 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
acd8401 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
16e5e74 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
1c5eba6 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
a929923 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
0d9dbea 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
4b6ef0c 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
b5edba0 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
a661cd5 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
b8ff3f2 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
f4eab4d 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
2eb126f 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
1aa8d00 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
1adb933 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
5e755e8 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
5b1fdfd 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
30b4dba 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
118d4df 
…ount for all the inner children layers (flutter/flutter#102309)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
e4edcbc Improve 'NestedScrollView and internal scrolling' test to acc…
595f6b4 
…ount for all the inner children layers (flutter/flutter#102309)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@TahaTesser @egramond
Improve 'NestedScrollView and internal scrolling' test to account for…
7c99f8f 
… all the inner children layers (flutter#102309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve NestedScrollView and internal scrolling test in the nested_scroll_view_test.dart

3 participants

@TahaTesser @dnfield @fluttergithubbot