Skip to content

Marks Mac_ios native_ui_tests_ios to be unflaky#102225

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot:gyzgCuX1h5
Apr 21, 2022
Merged

Marks Mac_ios native_ui_tests_ios to be unflaky#102225
fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot:gyzgCuX1h5

Conversation

@fluttergithubbot
Copy link
Contributor

@fluttergithubbot fluttergithubbot commented Apr 20, 2022

The issue #101426 has been closed, and the test has been passing for 50 consecutive runs.
This test can be marked as unflaky.

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. team: flakes c: tech-debt Technical debt, code quality, testing, etc. labels Apr 20, 2022
@jmagman
Copy link
Member

jmagman commented Apr 20, 2022 

.ci.yaml is executable: 111101101
Unhandled exception:
Exception: found 1 unexpected executable file! If this was intended, you must add this file to kExecutableAllowlist in dev/bots/analyze.dart
#0      _checkForNewExecutables (file:///tmp/flutter%20sdk/dev/bots/analyze.dart:1737:5)

Hm, why is the bot making this file executable? 100644 → 100755

@keyonghan keyonghan mentioned this pull request Apr 20, 2022
Closed
jmagman
jmagman approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 2bc539a into flutter:master Apr 21, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
2bc539a Marks Mac_ios native_ui_tests_ios to be unflaky (flutter/flut…
8c1a0bb 
…ter#102225)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
2bc539a Marks Mac_ios native_ui_tests_ios to be unflaky (flutter/flut…
9b2718b 
…ter#102225)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
2bc539a Marks Mac_ios native_ui_tests_ios to be unflaky (flutter/flut…
81d88d8 
…ter#102225)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@fluttergithubbot @egramond
Marks Mac_ios native_ui_tests_ios to be unflaky (flutter#102225)
bad8370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fluttergithubbot @jmagman @keyonghan